)]}'
{"lib/cinder":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"159024c235bb540469cec248a77b4dba4c44b92c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Public facing bits"},{"line_number":64,"context_line":"# Cinder only support SSL when running under mod_wsgi or TLS proxy"},{"line_number":65,"context_line":"if is_ssl_enabled_service cinder \u0026\u0026  [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ] || is_service_enabled tls-proxy ; then"},{"line_number":66,"context_line":"    CINDER_SERVICE_PROTOCOL\u003d\"https\""},{"line_number":67,"context_line":"fi"},{"line_number":68,"context_line":"CINDER_SERVICE_HOST\u003d${CINDER_SERVICE_HOST:-$SERVICE_HOST}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bae84128_b931010e","line":65,"updated":"2016-02-22 00:52:06.000000000","message":"i don\u0027t think this is expressing what you want ... \n\n if [ 1 \u003d\u003d 0 ] \u0026\u0026 [ 1 \u003d\u003d 0 ] || [ 1 \u003d\u003d 1 ]; then\n  echo hi\n fi\n\nevaluates true -- it should be false going by what you\u0027re saying in the change description?\n\nsome ()\u0027s needed i think","commit_id":"06b4c4d09ec393a5e513ed24604b42a7829516cd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"46267fffa619807c5d382294506f158ff78c94b3","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Public facing bits"},{"line_number":64,"context_line":"# Cinder only support SSL when running under mod_wsgi or TLS proxy"},{"line_number":65,"context_line":"if is_ssl_enabled_service cinder \u0026\u0026  [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ] || is_service_enabled tls-proxy ; then"},{"line_number":66,"context_line":"    CINDER_SERVICE_PROTOCOL\u003d\"https\""},{"line_number":67,"context_line":"fi"},{"line_number":68,"context_line":"CINDER_SERVICE_HOST\u003d${CINDER_SERVICE_HOST:-$SERVICE_HOST}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7aa08908_1e676e26","line":65,"in_reply_to":"bae84128_43753f96","updated":"2016-06-10 00:06:41.000000000","message":"hmm, ok, maybe i misread.  i think this would be better just with a sensible check\n\n if ssl_enabled \u0026\u0026 ! mod_wsgi; then\n     die \"Cinder can only use SSL with ...\"\n elif ssl_enabled || tls-proxy; then\n     ...\n fi\n\nthat way it\u0027s clearer to read, and gives a sensible error if someone doesn\u0027t realise what\u0027s going on","commit_id":"06b4c4d09ec393a5e513ed24604b42a7829516cd"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"34d6082d817d46cee18e7fce2de6c48a8e3f60b5","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Public facing bits"},{"line_number":64,"context_line":"# Cinder only support SSL when running under mod_wsgi or TLS proxy"},{"line_number":65,"context_line":"if is_ssl_enabled_service cinder \u0026\u0026  [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ] || is_service_enabled tls-proxy ; then"},{"line_number":66,"context_line":"    CINDER_SERVICE_PROTOCOL\u003d\"https\""},{"line_number":67,"context_line":"fi"},{"line_number":68,"context_line":"CINDER_SERVICE_HOST\u003d${CINDER_SERVICE_HOST:-$SERVICE_HOST}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bae84128_43753f96","line":65,"in_reply_to":"bae84128_b931010e","updated":"2016-02-22 17:17:56.000000000","message":"That\u0027s what I wanted actually. Cinder can only support SSL when running under mod_wsgi or via a TLS Proxy like HAProxy. It does not support SSL when running with eventlet. Therefore, merely have is_ssl_enabled_service_cinder is not good enough, it has to be used in conjunction with CINDER_USER_MOD_WSGI.","commit_id":"06b4c4d09ec393a5e513ed24604b42a7829516cd"}]}