)]}'
{"lib/neutron_plugins/ml2":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"2218ebed368fb7f3459cdc250919623784779e67","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    # Enable ml2 mtu calculation mechanism for networks by providing path mtu"},{"line_number":84,"context_line":"    # value for physical devices that are used for br-tun traffic"},{"line_number":85,"context_line":"    elif [[ \"$ENABLE_TENANT_TUNNELS\" \u003d\u003d \"True\" ]]; then"},{"line_number":86,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ml2 path_mtu \"$Q_ML2_PLUGIN_PATH_MTU\""},{"line_number":87,"context_line":"    fi"},{"line_number":88,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_18863fdb","line":85,"updated":"2016-01-14 16:51:40.000000000","message":"typo? Did you mean if","commit_id":"06487e821fab9c631305ce822fb1c6447cc55a1b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6d13aa5724a1c4aad52cbcd09b33992bb46ef0bf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# L3 Plugin to load for ML2"},{"line_number":41,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Q_ML2_PLUGIN_PATH_MTU\u003d${Q_ML2_PLUGIN_PATH_MTU-1500}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"function populate_ml2_config {"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da6ed579_ebd23bd0","line":43,"updated":"2016-01-15 15:09:49.000000000","message":"Is this supposed to be :-1500 so it defaults to 1500?","commit_id":"73ccb49c39d622add93c1a9ebd5afeceff98d335"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"07ce669ee2223e592b07766142e5cb7dc68183f2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# L3 Plugin to load for ML2"},{"line_number":41,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Q_ML2_PLUGIN_PATH_MTU\u003d${Q_ML2_PLUGIN_PATH_MTU-1500}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"function populate_ml2_config {"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da6ed579_452f623e","line":43,"in_reply_to":"da6ed579_0f48e9cb","updated":"2016-01-18 13:22:21.000000000","message":"I think you are right: there is no reason to allow \"\" value here, though we should be able to disable the mechanism. So we should do nothing if it\u0027s \"\".","commit_id":"73ccb49c39d622add93c1a9ebd5afeceff98d335"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb5c0abcef23fceeb66f8d22b76de894c53e0029","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# L3 Plugin to load for ML2"},{"line_number":41,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Q_ML2_PLUGIN_PATH_MTU\u003d${Q_ML2_PLUGIN_PATH_MTU-1500}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"function populate_ml2_config {"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da6ed579_0f48e9cb","line":43,"in_reply_to":"da6ed579_c8b73083","updated":"2016-01-15 20:24:13.000000000","message":"So if I (mistakenly) define Q_ML2_PLUGIN_PATH_MTU\u003d\"\" it will stay that way and L86 will write \"path_mtu \" into ml2_conf.ini.  Will that cause problems since it\u0027s expecting a value?\n\n(and thanks for the pointer, didn\u0027t know about this format)","commit_id":"73ccb49c39d622add93c1a9ebd5afeceff98d335"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a928b815b9d4b90d4c4d3bb9c462743e496f71f7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# L3 Plugin to load for ML2"},{"line_number":41,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Q_ML2_PLUGIN_PATH_MTU\u003d${Q_ML2_PLUGIN_PATH_MTU-1500}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"function populate_ml2_config {"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da6ed579_c8b73083","line":43,"in_reply_to":"da6ed579_ebd23bd0","updated":"2016-01-15 18:26:14.000000000","message":"http://wiki.bash-hackers.org/syntax/pe#use_a_default_value","commit_id":"73ccb49c39d622add93c1a9ebd5afeceff98d335"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"b147c027dd3fff84ee022538d73a31ef34f5a659","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# L3 Plugin to load for ML2"},{"line_number":41,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Q_ML2_PLUGIN_PATH_MTU\u003d${Q_ML2_PLUGIN_PATH_MTU-1500}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"function populate_ml2_config {"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a68dd71_58e184cf","line":43,"updated":"2016-01-21 13:52:14.000000000","message":":-1500, right?","commit_id":"2d8406df1b52d0311dddf21e29e01ca01a3c76e8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2b908f1654abd9bae59f9b7bf21dbe2c8b080ab1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# L3 Plugin to load for ML2"},{"line_number":41,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN:-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Q_ML2_PLUGIN_PATH_MTU\u003d${Q_ML2_PLUGIN_PATH_MTU-1500}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"function populate_ml2_config {"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a68dd71_9ba61652","line":43,"in_reply_to":"9a68dd71_58e184cf","updated":"2016-01-21 14:13:31.000000000","message":"No, it\u0027s a special bash syntax to allow to unset the value with \"\". Later, we skip writing path_mtu if that\u0027s the case (in that way, we allow to disable the mechanism if it misbehaves or smth).","commit_id":"2d8406df1b52d0311dddf21e29e01ca01a3c76e8"}]}