)]}'
{"id":"openstack%2Fdevstack~26833","triplet_id":"openstack%2Fdevstack~master~I4f66d8fc65c90a309aab478a4df35c77c7669314","project":"openstack/devstack","branch":"master","topic":"fix/polkit-opensuse-12.3","hashtags":[],"change_id":"I4f66d8fc65c90a309aab478a4df35c77c7669314","subject":"Fix nova compute failing to start on openSUSE 12.3","status":"MERGED","created":"2013-04-12 10:42:09.000000000","updated":"2013-05-01 01:22:45.000000000","submitted":"2013-05-01 01:22:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2ed2b46efd4a5fa5429dc878cfda875875901467","_number":26833,"virtual_id_number":26833,"owner":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-05-01 01:22:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-04-25 18:19:53.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"date":"2013-04-25 15:48:59.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":2,"date":"2013-05-01 00:38:03.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-04-25 18:19:53.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"date":"2013-04-25 15:47:15.000000000","_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":1,"date":"2013-05-01 00:38:03.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-12 11:20:26.000000000","updated_by":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"reviewer":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"state":"REVIEWER"},{"updated":"2013-04-25 18:19:53.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-05-01 00:38:03.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-05-01 01:22:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"59e848b31bdd28e6d2b1a047a4200be4900efeaa","author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"date":"2013-04-12 11:20:26.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"368062f75fcc73370e2202bed217d07b2272e338","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-12 11:31:10.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26833/1/check/gate-tempest-devstack-vm-full/12449 : SUCCESS\n- http://logs.openstack.org/26833/1/check/gate-tempest-devstack-vm-postgres-full/12164 : SUCCESS\n- http://logs.openstack.org/26833/1/check/gate-tempest-devstack-vm-quantum/18294 : SUCCESS\n- http://logs.openstack.org/26833/1/check/gate-grenade-devstack-vm/401 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"1d84d1d67d2e38349a33edfa26562f301f41cef4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-04-15 05:02:08.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nI think restructuring the if statements would simplify the checks required.  Pick out the specific exceptions (fedora \u003c 18 and opensuse \u003c 12.3) then let the common fall to the last else clause.  Something like:\n\n if fedora || suse then\n     if opensuse \u003c 12.3 then\n         # Old suse polkit bits\n     else if fedora \u003c 18 then\n         # Old Fedora polkit bits\n     else\n         # everything that reaches here is either suse \u003e 12.2 or fedora \u003e 17\n     fi\n fi","accounts_in_message":[],"_revision_number":1},{"id":"a0eeb0fb05e1c77814269dc2becbcfb822f94ce7","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-22 06:03:03.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"66732abe238d88b3b769b2fc3b9ec37b12f8e689","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-22 06:03:03.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"51752c25e14de94dd3e7847086a2698c4e785e99","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2013-04-25 15:45:57.000000000","message":"Patch Set 1: Restored\n\nRestoring to push an updated patch.","accounts_in_message":[],"_revision_number":1},{"id":"112fbe577fc7496b1b4113ca3f34a9730282af2d","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2013-04-25 15:47:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a54fe1088304858fd4948f32c909f927f50e5649","author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"date":"2013-04-25 15:48:59.000000000","message":"Patch Set 2:\n\nThis should address the issues that were raised against patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"52d7bfe67f5a81515f1eb822874b5e0bfcb497f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-25 16:32:07.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26833/2/check/gate-tempest-devstack-vm-full/13585 : SUCCESS\n- http://logs.openstack.org/26833/2/check/gate-tempest-devstack-vm-postgres-full/13300 : FAILURE (non-voting)\n- http://logs.openstack.org/26833/2/check/gate-tempest-devstack-vm-quantum/19542 : SUCCESS\n- http://logs.openstack.org/26833/2/check/gate-grenade-devstack-vm/1451 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"714eb04aaeb69c12c568091b09caced28c4b1d37","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-04-25 18:19:53.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d0228db4c2eb069fb62cd66d12abb775bf79b933","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-01 00:38:03.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nI don\u0027t love the deep nesting, but I\u0027m at a loss for something cleaner right now.","accounts_in_message":[],"_revision_number":2},{"id":"14daacf55fb7ed2a1c26d2dfcce94a96dec06104","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-01 00:38:06.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"23c738fa2a2e9b995654495f1c0769b597ac3cb9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-01 01:22:45.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/26833/2/gate/gate-tempest-devstack-vm-full/14094 : SUCCESS\n- http://logs.openstack.org/26833/2/gate/gate-tempest-devstack-vm-postgres-full/13809 : FAILURE (non-voting)\n- http://logs.openstack.org/26833/2/gate/gate-tempest-devstack-vm-quantum/20151 : SUCCESS\n- http://logs.openstack.org/26833/2/gate/gate-grenade-devstack-vm/1924 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"b0b4707f9e62df6184b459290a1bf8b97f102589","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-01 01:22:45.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"76ca9a9e235c9f57eaecb387dc22d02e241de402","revisions":{"d450bf1b305d1a105aad561e2464c255ab57f275":{"kind":"REWORK","_number":1,"created":"2013-04-12 10:42:09.000000000","uploader":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"ref":"refs/changes/33/26833/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/33/26833/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/26833/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/26833/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/26833/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/33/26833/1"}}},"commit":{"parents":[{"commit":"a1c183b4effc8a9859ed5529577f209bbd9bb880","subject":"Merge \"Add err()/err_if_not_set()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a1c183b4effc8a9859ed5529577f209bbd9bb880"}]}],"author":{"name":"Ralf Haferkamp","email":"rhafer@suse.de","date":"2013-04-12 10:39:58.000000000","tz":120},"committer":{"name":"Ralf Haferkamp","email":"rhafer@suse.de","date":"2013-04-12 10:39:58.000000000","tz":120},"subject":"Fix nova compute failing to start on openSUSE 12.3","message":"Fix nova compute failing to start on openSUSE 12.3\n\nThe syntax of polkit authorization rules is different now. Using the same code\nas for Fedora 18 now.\n\nChange-Id: I4f66d8fc65c90a309aab478a4df35c77c7669314\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d450bf1b305d1a105aad561e2464c255ab57f275"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d450bf1b305d1a105aad561e2464c255ab57f275"}]},"branch":"refs/heads/master"},"76ca9a9e235c9f57eaecb387dc22d02e241de402":{"kind":"REWORK","_number":2,"created":"2013-04-25 15:47:15.000000000","uploader":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"ref":"refs/changes/33/26833/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/33/26833/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/26833/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/26833/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/33/26833/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/33/26833/2"}}},"commit":{"parents":[{"commit":"63992bcb581b871fabd7181d208ec267e5f5d8d8","subject":"Merge \"Add a generic post-prereq phase\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/63992bcb581b871fabd7181d208ec267e5f5d8d8"}]}],"author":{"name":"Ralf Haferkamp","email":"rhafer@suse.de","date":"2013-04-12 10:39:58.000000000","tz":120},"committer":{"name":"Ralf Haferkamp","email":"rhafer@suse.de","date":"2013-04-25 15:17:57.000000000","tz":120},"subject":"Fix nova compute failing to start on openSUSE 12.3","message":"Fix nova compute failing to start on openSUSE 12.3\n\nThe syntax of polkit authorization rules is different now. Using the same code\nas for Fedora 18 now.\n\nChange-Id: I4f66d8fc65c90a309aab478a4df35c77c7669314\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/76ca9a9e235c9f57eaecb387dc22d02e241de402"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/76ca9a9e235c9f57eaecb387dc22d02e241de402"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}