)]}'
{"lib/quantum_plugins/nicira":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"496b98f92b7b17d924399ef6db5a46e1cec66b8e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE NVP concurrent_connections $CONCURRENT_CONNECTIONS"},{"line_number":86,"context_line":"    fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if [[ \"$DEFAULT_CLUSTER\" !\u003d \"\" ]]; then"},{"line_number":89,"context_line":"        echo \"WARNING: DEFAULT_CLUSTER is no longer used.  See nvp configuration file for details.\""},{"line_number":90,"context_line":"    fi"},{"line_number":91,"context_line":"    if [[ \"$DEFAULT_TZ_UUID\" !\u003d \"\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9zA%3D","line":88,"updated":"2013-05-15 23:07:45.000000000","message":"nit: I\u0027d remove lines 88-90 I don\u0027t think we need the check.","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"47a8421310ba2932f1e7b5932bc3285348bf4533","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE NVP concurrent_connections $CONCURRENT_CONNECTIONS"},{"line_number":86,"context_line":"    fi"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if [[ \"$DEFAULT_CLUSTER\" !\u003d \"\" ]]; then"},{"line_number":89,"context_line":"        echo \"WARNING: DEFAULT_CLUSTER is no longer used.  See nvp configuration file for details.\""},{"line_number":90,"context_line":"    fi"},{"line_number":91,"context_line":"    if [[ \"$DEFAULT_TZ_UUID\" !\u003d \"\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9r8%3D","line":88,"in_reply_to":"AAAAO3%2F%2F9zA%3D","updated":"2013-05-15 23:51:36.000000000","message":"Can do, even though it does no harm.","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"496b98f92b7b17d924399ef6db5a46e1cec66b8e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    if [[ \"$NVP_CONTROLLERS\" !\u003d \"\" ]]; then"},{"line_number":109,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_controllers $NVP_CONTROLLERS"},{"line_number":110,"context_line":"    elif [[ \"$NVP_CONTROLLER_CONNECTION\" !\u003d \"\" ]]; then"},{"line_number":111,"context_line":"        echo \"WARNING: variable NVP_CONTROLLER_CONNECTION is deprecated and may be removed in future releases\""},{"line_number":112,"context_line":"        IFS\u003d\u0027:\u0027 read -ra CONNECTION_PARAMS \u003c\u003c\u003c \"$NVP_CONTROLLER_CONNECTION\""},{"line_number":113,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_controllers \"${CONNECTION_PARAMS[0]}:${CONNECTION_PARAMS[1]}\""},{"line_number":114,"context_line":"        NVP_USER\u003d${CONNECTION_PARAMS[2]}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9yE%3D","line":111,"updated":"2013-05-15 23:07:45.000000000","message":"nit: I don\u0027t think we need to maintain backwards compatibility in devstack what do you think?","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"47a8421310ba2932f1e7b5932bc3285348bf4533","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    if [[ \"$NVP_CONTROLLERS\" !\u003d \"\" ]]; then"},{"line_number":109,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_controllers $NVP_CONTROLLERS"},{"line_number":110,"context_line":"    elif [[ \"$NVP_CONTROLLER_CONNECTION\" !\u003d \"\" ]]; then"},{"line_number":111,"context_line":"        echo \"WARNING: variable NVP_CONTROLLER_CONNECTION is deprecated and may be removed in future releases\""},{"line_number":112,"context_line":"        IFS\u003d\u0027:\u0027 read -ra CONNECTION_PARAMS \u003c\u003c\u003c \"$NVP_CONTROLLER_CONNECTION\""},{"line_number":113,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_controllers \"${CONNECTION_PARAMS[0]}:${CONNECTION_PARAMS[1]}\""},{"line_number":114,"context_line":"        NVP_USER\u003d${CONNECTION_PARAMS[2]}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9rk%3D","line":111,"in_reply_to":"AAAAO3%2F%2F9yE%3D","updated":"2013-05-15 23:51:36.000000000","message":"if we don\u0027t, we would need to fail here; but I loathe the idea of breaking people\u0027s existing environments :)","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"496b98f92b7b17d924399ef6db5a46e1cec66b8e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        NVP_REDIRECTS\u003d${CONNECTION_PARAMS[7]}"},{"line_number":120,"context_line":"    else"},{"line_number":121,"context_line":"        die $LINENO \"The nicira plugin needs at least an NVP controller.\""},{"line_number":122,"context_line":"    fi"},{"line_number":123,"context_line":"    if [[ \"$NVP_USER\" !\u003d \"\" ]]; then"},{"line_number":124,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_user $NVP_USER"},{"line_number":125,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9yI%3D","line":122,"updated":"2013-05-15 23:07:45.000000000","message":"nit: can we remove all these if statements and instead specify the default values at the top of the file. This way i don\u0027t need to specify all of this stuff in my localrc.","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"afb81826af15aa00cef58a67d5a8046e3018aa7e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        NVP_REDIRECTS\u003d${CONNECTION_PARAMS[7]}"},{"line_number":120,"context_line":"    else"},{"line_number":121,"context_line":"        die $LINENO \"The nicira plugin needs at least an NVP controller.\""},{"line_number":122,"context_line":"    fi"},{"line_number":123,"context_line":"    if [[ \"$NVP_USER\" !\u003d \"\" ]]; then"},{"line_number":124,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_user $NVP_USER"},{"line_number":125,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9ps%3D","line":122,"in_reply_to":"AAAAO3%2F%2F9rg%3D","updated":"2013-05-16 00:01:24.000000000","message":"The only danger I see if we specified default values here is that we would need to make sure they are in sync with the codebase. There is no need to specify these in your localrc though, as defaults are enforced via quantum configs.","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"47a8421310ba2932f1e7b5932bc3285348bf4533","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        NVP_REDIRECTS\u003d${CONNECTION_PARAMS[7]}"},{"line_number":120,"context_line":"    else"},{"line_number":121,"context_line":"        die $LINENO \"The nicira plugin needs at least an NVP controller.\""},{"line_number":122,"context_line":"    fi"},{"line_number":123,"context_line":"    if [[ \"$NVP_USER\" !\u003d \"\" ]]; then"},{"line_number":124,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_user $NVP_USER"},{"line_number":125,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAO3%2F%2F9rg%3D","line":122,"in_reply_to":"AAAAO3%2F%2F9yI%3D","updated":"2013-05-15 23:51:36.000000000","message":"good point.","commit_id":"3546f0ce81fb6314d015bb794d2729b2a3617ec9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"579a2dc94f33a2b919d8e06bae94d80e8a00ceac","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        Q_L3_ROUTER_PER_TENANT\u003dTrue"},{"line_number":92,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE NVP enable_metadata_access_network True"},{"line_number":93,"context_line":"    else"},{"line_number":94,"context_line":"        echo \"WARNING: No l3 gw service enabled.  You will not be able to use the L3 API extension\""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":"    if [[ \"$DEFAULT_L2_GW_SVC_UUID\" !\u003d \"\" ]]; then"},{"line_number":97,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT default_l2_gw_service_uuid $DEFAULT_L2_GW_SVC_UUID"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPH%2F%2Fos4%3D","line":94,"updated":"2013-05-28 20:48:46.000000000","message":"remove, no reason to raise this warning.","commit_id":"fef08c265948d70fa906a27b4cd39817dc8905b2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9159cb78ebfd3cd1e76c6d110a4487dfe80947b8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        Q_L3_ROUTER_PER_TENANT\u003dTrue"},{"line_number":92,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE NVP enable_metadata_access_network True"},{"line_number":93,"context_line":"    else"},{"line_number":94,"context_line":"        echo \"WARNING: No l3 gw service enabled.  You will not be able to use the L3 API extension\""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":"    if [[ \"$DEFAULT_L2_GW_SVC_UUID\" !\u003d \"\" ]]; then"},{"line_number":97,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT default_l2_gw_service_uuid $DEFAULT_L2_GW_SVC_UUID"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPH%2F%2FopQ%3D","line":94,"in_reply_to":"AAAAPH%2F%2Fos4%3D","updated":"2013-05-28 21:06:41.000000000","message":"ok","commit_id":"fef08c265948d70fa906a27b4cd39817dc8905b2"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"579a2dc94f33a2b919d8e06bae94d80e8a00ceac","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    fi"},{"line_number":99,"context_line":"    # NVP_CONTROLLERS must be a comma separated string"},{"line_number":100,"context_line":"    if [[ \"$NVP_CONTROLLERS\" !\u003d \"\" ]]; then"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_controllers $NVP_CONTROLLERS"},{"line_number":102,"context_line":"    else"},{"line_number":103,"context_line":"        die $LINENO \"The nicira plugin needs at least an NVP controller.\""},{"line_number":104,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPH%2F%2FotE%3D","line":101,"updated":"2013-05-28 20:48:46.000000000","message":"there is no sane default?","commit_id":"fef08c265948d70fa906a27b4cd39817dc8905b2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9159cb78ebfd3cd1e76c6d110a4487dfe80947b8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    fi"},{"line_number":99,"context_line":"    # NVP_CONTROLLERS must be a comma separated string"},{"line_number":100,"context_line":"    if [[ \"$NVP_CONTROLLERS\" !\u003d \"\" ]]; then"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE DEFAULT nvp_controllers $NVP_CONTROLLERS"},{"line_number":102,"context_line":"    else"},{"line_number":103,"context_line":"        die $LINENO \"The nicira plugin needs at least an NVP controller.\""},{"line_number":104,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAPH%2F%2Foo4%3D","line":101,"in_reply_to":"AAAAPH%2F%2FotE%3D","updated":"2013-05-28 21:06:41.000000000","message":"I am afraid there aren\u0027t, and there is no easy way by which this can be determined.","commit_id":"fef08c265948d70fa906a27b4cd39817dc8905b2"}]}