)]}'
{"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"37cad61e93f372d6ad78151332f57902e9488845","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    # libvirt detects various settings on startup, as we potentially changed"},{"line_number":131,"context_line":"    # the system configuration (modules, filesystems), we need to restart"},{"line_number":132,"context_line":"    # libvirt to detect those changes. Use a stop start as otherwise the new"},{"line_number":133,"context_line":"    # cpu_map is not loaded properly on some systems (Ubuntu)."},{"line_number":134,"context_line":"    stop_service $LIBVIRT_DAEMON"},{"line_number":135,"context_line":"    start_service $LIBVIRT_DAEMON"},{"line_number":136,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_386803b9","side":"PARENT","line":133,"updated":"2016-01-29 17:18:04.000000000","message":"Have you verified that this comment is no longer true?","commit_id":"973fb21de6b21253d2629fae23360dbc08940e69"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"5fd14301b5bca8194f043f48843c0f8aba924013","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    # libvirt detects various settings on startup, as we potentially changed"},{"line_number":131,"context_line":"    # the system configuration (modules, filesystems), we need to restart"},{"line_number":132,"context_line":"    # libvirt to detect those changes. Use a stop start as otherwise the new"},{"line_number":133,"context_line":"    # cpu_map is not loaded properly on some systems (Ubuntu)."},{"line_number":134,"context_line":"    stop_service $LIBVIRT_DAEMON"},{"line_number":135,"context_line":"    start_service $LIBVIRT_DAEMON"},{"line_number":136,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bab6814e_3fdab7e8","side":"PARENT","line":133,"in_reply_to":"7a5de9d1_386803b9","updated":"2016-05-20 13:55:33.000000000","message":"Why should he care about the comment? AFAIK it\u0027s a good practice not to modify anything outside of this patch\u0027s scope.","commit_id":"973fb21de6b21253d2629fae23360dbc08940e69"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"65a9ccd41fcfdb7337f50fa74f74ca664dc83f99","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    # libvirt detects various settings on startup, as we potentially changed"},{"line_number":131,"context_line":"    # the system configuration (modules, filesystems), we need to restart"},{"line_number":132,"context_line":"    # libvirt to detect those changes. Use a stop start as otherwise the new"},{"line_number":133,"context_line":"    # cpu_map is not loaded properly on some systems (Ubuntu)."},{"line_number":134,"context_line":"    stop_service $LIBVIRT_DAEMON"},{"line_number":135,"context_line":"    start_service $LIBVIRT_DAEMON"},{"line_number":136,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_44428c3f","side":"PARENT","line":133,"in_reply_to":"7a5de9d1_386803b9","updated":"2016-02-22 01:00:45.000000000","message":"if you look at the original change, this would have been clarkb working on Ubuntu Trusty in the gate -- I00667713bfba67ab8cedbcb1660ff94d4f4bcc07\n\nthis is still what we\u0027re using, so i imagine the issue is still there, unless it was related to a bug that was fixed.","commit_id":"973fb21de6b21253d2629fae23360dbc08940e69"},{"author":{"_account_id":17527,"name":"Felix Ma","email":"maqi@cmss.chinamobile.com","username":"felix23ma"},"change_message_id":"897ad74d0ea89c8bb8ff131cc18e33364e19c832","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    # libvirt detects various settings on startup, as we potentially changed"},{"line_number":131,"context_line":"    # the system configuration (modules, filesystems), we need to restart"},{"line_number":132,"context_line":"    # libvirt to detect those changes. Use a stop start as otherwise the new"},{"line_number":133,"context_line":"    # cpu_map is not loaded properly on some systems (Ubuntu)."},{"line_number":134,"context_line":"    stop_service $LIBVIRT_DAEMON"},{"line_number":135,"context_line":"    start_service $LIBVIRT_DAEMON"},{"line_number":136,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_e47000df","side":"PARENT","line":133,"in_reply_to":"bae84128_44428c3f","updated":"2016-02-22 01:40:26.000000000","message":"@lan, I\u0027m testing on Ubuntu Trusty(14.04.1 LTS). I don\u0027t know how to verify the cpu_map is loaded properly. Do you know how? \nThe problem I met is the installation is failed if stop/start is used. I don\u0027t know if Clarkb see it.","commit_id":"973fb21de6b21253d2629fae23360dbc08940e69"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"5fd14301b5bca8194f043f48843c0f8aba924013","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    # libvirt detects various settings on startup, as we potentially changed"},{"line_number":131,"context_line":"    # the system configuration (modules, filesystems), we need to restart"},{"line_number":132,"context_line":"    # libvirt to detect those changes. Use a stop start as otherwise the new"},{"line_number":133,"context_line":"    # cpu_map is not loaded properly on some systems (Ubuntu)."},{"line_number":134,"context_line":"    stop_service $LIBVIRT_DAEMON"},{"line_number":135,"context_line":"    start_service $LIBVIRT_DAEMON"},{"line_number":136,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bab6814e_3f7637d7","side":"PARENT","line":133,"in_reply_to":"bae84128_e47000df","updated":"2016-05-20 13:55:33.000000000","message":"I agree with you 100%. The problem you are trying to address and the modification of the comments are totally unrelated. IMHO you should\u0027t modify anything outside the scope here.","commit_id":"973fb21de6b21253d2629fae23360dbc08940e69"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"948ffc01a34055dc40855c94dcd427e84658c836","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    # libvirt detects various settings on startup, as we potentially changed"},{"line_number":131,"context_line":"    # the system configuration (modules, filesystems), we need to restart"},{"line_number":132,"context_line":"    # libvirt to detect those changes. Use a stop start as otherwise the new"},{"line_number":133,"context_line":"    # cpu_map is not loaded properly on some systems (Ubuntu)."},{"line_number":134,"context_line":"    stop_service $LIBVIRT_DAEMON"},{"line_number":135,"context_line":"    start_service $LIBVIRT_DAEMON"},{"line_number":136,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_c4317c0d","side":"PARENT","line":133,"in_reply_to":"bae84128_e47000df","updated":"2016-02-22 01:42:08.000000000","message":"it\u0027s a shame there wasn\u0027t a bug referenced.  maybe ping clarkb in #openstack-infra, he might remember the issue","commit_id":"973fb21de6b21253d2629fae23360dbc08940e69"}]}