)]}'
{"lib/tempest":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"a204e688a93319286b04ff12ff8deeb8beb7654c","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":446,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":447,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":448,"context_line":"       TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # Validation"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a5ae5dd_493758e3","line":447,"range":{"start_line":447,"start_character":71,"end_line":447,"end_character":73},"updated":"2016-02-04 17:01:24.000000000","message":"you should use is_provider_network function.","commit_id":"c282f28ce6627c103376287e0dce72b5414a1574"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"f4514328094e44acd4264dc1576866041c55e498","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":446,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":447,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":448,"context_line":"       TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # Validation"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a5ae5dd_204521b2","line":447,"range":{"start_line":447,"start_character":71,"end_line":447,"end_character":73},"in_reply_to":"5a5ae5dd_493758e3","updated":"2016-02-05 14:35:05.000000000","message":"I\u0027d like to use the is_provider_network function but I believe that would require me to move it into the functions-common file.\n\nNot sure if it belongs there, but if other people think it\u0027s the right way to proceed, I definitely will.","commit_id":"c282f28ce6627c103376287e0dce72b5414a1574"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"557b5b2d4eb0875554824f2bb3407344c7d776c8","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":446,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":447,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":448,"context_line":"       TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # Validation"},{"line_number":451,"context_line":"    iniset $TEMPEST_CONFIG validation run_validation ${TEMPEST_RUN_VALIDATION:-False}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a5ae5dd_604b192b","line":448,"range":{"start_line":448,"start_character":0,"end_line":448,"end_character":7},"updated":"2016-02-05 14:27:10.000000000","message":"you also forgot to close de if","commit_id":"c282f28ce6627c103376287e0dce72b5414a1574"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"f4514328094e44acd4264dc1576866041c55e498","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":446,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":447,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":448,"context_line":"       TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # Validation"},{"line_number":451,"context_line":"    iniset $TEMPEST_CONFIG validation run_validation ${TEMPEST_RUN_VALIDATION:-False}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a5ae5dd_a0b351e8","line":448,"range":{"start_line":448,"start_character":0,"end_line":448,"end_character":7},"in_reply_to":"5a5ae5dd_604b192b","updated":"2016-02-05 14:35:05.000000000","message":"Done","commit_id":"c282f28ce6627c103376287e0dce72b5414a1574"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"1f3911f3e51e7fdada3ef65f39742c04722c1064","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":446,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":447,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":448,"context_line":"       TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":449,"context_line":"    fi"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # Validation"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a5ae5dd_983d122d","line":448,"updated":"2016-02-08 20:04:24.000000000","message":"This needs to be indented - multiples of 4. So two more whitespaces please.","commit_id":"8e93c8a6c38b77ae070ef02c0f61c24f40d31970"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"4d50d7b2d9cc137db5b6528cd6e9ff2bddcd6cfe","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":446,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":447,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":448,"context_line":"       TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":449,"context_line":"    fi"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    # Validation"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_9b9b81c9","line":448,"in_reply_to":"5a5ae5dd_983d122d","updated":"2016-04-12 19:00:10.000000000","message":"Done","commit_id":"8e93c8a6c38b77ae070ef02c0f61c24f40d31970"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"c466694917a638ec7512fd3349a17c885429ac83","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":417,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"},{"line_number":418,"context_line":"    if [ \"$Q_USE_PROVIDER_NETWORKING\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$Q_L3_ENABLED\" \u003d\u003d \"False\" ]; then"},{"line_number":419,"context_line":"        TEMPEST_SSH_NETWORK_NAME\u003d$PHYSICAL_NETWORK"},{"line_number":420,"context_line":"    fi"},{"line_number":421,"context_line":"    # Validation"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a122d0e_0a1094a7","line":418,"updated":"2016-04-18 16:53:26.000000000","message":"This appears to be copied from function is_provider_network in neutron-legacy. Consider moving it out of neutron-legacy and into functions-common instead of copying and pasting please.","commit_id":"144a0c7a1aef454f67ed8aad2e3e688127c5cc3c"}]}