)]}'
{"lib/quantum_plugins/cisco":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c58af63abaf67a9639f6a354afa8d3ba3b77fa87","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Specify ncclient package information"},{"line_number":36,"context_line":"NCCLIENT_DIR\u003d$DEST/ncclient"},{"line_number":37,"context_line":"NCCLIENT_VERSION\u003d${NCCLIENT_VERSION:-0.3.1}"},{"line_number":38,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":39,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# This routine put a prefix in an existing fucntion name"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAPH%2F%2Fz9U%3D","line":38,"updated":"2013-05-22 14:33:14.000000000","message":"Does it make more sense to put these in stackrc at the toplevel? I\u0027m fine either way, but noticed most of the *_VERSION and *_BRANCH variables are there.","commit_id":"d225ca09b82eb6a822cdf94c9889a4413f53e645"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"9b54a42e71f6995ba5ea7ce4abb47fcedcfbbda7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Specify ncclient package information"},{"line_number":36,"context_line":"NCCLIENT_DIR\u003d$DEST/ncclient"},{"line_number":37,"context_line":"NCCLIENT_VERSION\u003d${NCCLIENT_VERSION:-0.3.1}"},{"line_number":38,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":39,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# This routine put a prefix in an existing fucntion name"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAPH%2F%2FzlE%3D","line":38,"in_reply_to":"AAAAPH%2F%2Fz48%3D","updated":"2013-05-22 16:31:16.000000000","message":"I think this is the way to do it, as you said, Ryu does it there.","commit_id":"d225ca09b82eb6a822cdf94c9889a4413f53e645"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"de4da3f6ac7df0f3c4759f13484de8ea3e98b216","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Specify ncclient package information"},{"line_number":36,"context_line":"NCCLIENT_DIR\u003d$DEST/ncclient"},{"line_number":37,"context_line":"NCCLIENT_VERSION\u003d${NCCLIENT_VERSION:-0.3.1}"},{"line_number":38,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":39,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# This routine put a prefix in an existing fucntion name"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAPH%2F%2Fz48%3D","line":38,"in_reply_to":"AAAAPH%2F%2Fz9U%3D","updated":"2013-05-22 15:11:36.000000000","message":"I originally thought that I should not put vendor required package in stackrc. Now I see that it has ryu specific stuff over there. So  let me move it into stackrc if no objection from other reviewers","commit_id":"d225ca09b82eb6a822cdf94c9889a4413f53e645"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c58af63abaf67a9639f6a354afa8d3ba3b77fa87","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# vlans to be used will be reset."},{"line_number":161,"context_line":"function reset_nexus_switch() {"},{"line_number":162,"context_line":"    python \u003c\u003c-EOF"},{"line_number":163,"context_line":"\tnexus_host \u003d \u0027$1\u0027"},{"line_number":164,"context_line":"\tnexus_info \u003d \u0027$2\u0027"},{"line_number":165,"context_line":"\tvlan_ranges \u003d \u0027$3\u0027"},{"line_number":166,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAPH%2F%2Fz8g%3D","line":163,"updated":"2013-05-22 14:33:14.000000000","message":"Looks like a lot of tabs in here in some places, can you clean those up and be consistent with the rest of devstack, which I believe uses spaces?","commit_id":"d225ca09b82eb6a822cdf94c9889a4413f53e645"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"de4da3f6ac7df0f3c4759f13484de8ea3e98b216","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# vlans to be used will be reset."},{"line_number":161,"context_line":"function reset_nexus_switch() {"},{"line_number":162,"context_line":"    python \u003c\u003c-EOF"},{"line_number":163,"context_line":"\tnexus_host \u003d \u0027$1\u0027"},{"line_number":164,"context_line":"\tnexus_info \u003d \u0027$2\u0027"},{"line_number":165,"context_line":"\tvlan_ranges \u003d \u0027$3\u0027"},{"line_number":166,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAPH%2F%2Fz3Q%3D","line":163,"in_reply_to":"AAAAPH%2F%2Fz8g%3D","updated":"2013-05-22 15:11:36.000000000","message":"With bash here doc, tabs rather than spaces have to be used for indentation. But I think some cleanup definitely can be done in here. I\u0027ll try to cleanup as much as possible","commit_id":"d225ca09b82eb6a822cdf94c9889a4413f53e645"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"ec360b984377fc5b5b742769aa910978bb288d79","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    fi"},{"line_number":350,"context_line":"}"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"function _config_nexus_subplugin() {"},{"line_number":353,"context_line":"    local cisco_cfg_file\u003d$1"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    # Install Cisco ncclient if necessary"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAPH%2F%2FzlU%3D","line":352,"updated":"2013-05-22 16:30:40.000000000","message":"I think this should be _configure_nexus_subplugin, as that is how it is called on line 943.","commit_id":"d225ca09b82eb6a822cdf94c9889a4413f53e645"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"e4594d8e5003773fae146389e8803f1189f8aae6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# vlans to be used will be reset."},{"line_number":161,"context_line":"function reset_nexus_switch() {"},{"line_number":162,"context_line":"    python \u003c\u003c-EOF"},{"line_number":163,"context_line":"\tnexus_host \u003d \u0027$1\u0027"},{"line_number":164,"context_line":"\tnexus_info \u003d \u0027$2\u0027"},{"line_number":165,"context_line":"\tvlan_ranges \u003d \u0027$3\u0027"},{"line_number":166,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAPH%2F%2Fzbk%3D","line":163,"updated":"2013-05-22 17:39:43.000000000","message":"Still see some space vs. tabs issue here, but I think some of these are cleaned up.","commit_id":"747b9e1627f8a268fd2df14cf4d6aaf0e74568be"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4031ab3c80e67fc4279b74b3600a5c0514e14213","unresolved":false,"context_lines":[{"line_number":437,"context_line":"}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"# This routine creates a virtual machine that runs VSM"},{"line_number":440,"context_line":"function _create_devstack_vsm() {"},{"line_number":441,"context_line":"    local vsm_image_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.img"},{"line_number":442,"context_line":"    local vsm_xml_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.xml"},{"line_number":443,"context_line":"    local vsm_state"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2FusQ%3D","line":440,"updated":"2013-05-24 09:52:39.000000000","message":"wait, really, you build a vm?","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"89780ee7f85b92c175dd7214959df77b30375bbe","unresolved":false,"context_lines":[{"line_number":437,"context_line":"}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"# This routine creates a virtual machine that runs VSM"},{"line_number":440,"context_line":"function _create_devstack_vsm() {"},{"line_number":441,"context_line":"    local vsm_image_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.img"},{"line_number":442,"context_line":"    local vsm_xml_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.xml"},{"line_number":443,"context_line":"    local vsm_state"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2FtGE%3D","line":440,"in_reply_to":"AAAAPH%2F%2Ft98%3D","updated":"2013-05-24 22:24:19.000000000","message":"Ok. let me take them out.","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"adade8a506034c805afaffdf4a1192197e8ef5c9","unresolved":false,"context_lines":[{"line_number":437,"context_line":"}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"# This routine creates a virtual machine that runs VSM"},{"line_number":440,"context_line":"function _create_devstack_vsm() {"},{"line_number":441,"context_line":"    local vsm_image_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.img"},{"line_number":442,"context_line":"    local vsm_xml_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.xml"},{"line_number":443,"context_line":"    local vsm_state"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2Ft98%3D","line":440,"in_reply_to":"AAAAPH%2F%2Fubk%3D","updated":"2013-05-24 15:39:10.000000000","message":"yeah.... devstack should just be used to point openstack to the VSM, not to build VSM itself.  Look at the example of how the NVP plugin works.  We do not use devstack to install NVP, we use it to setup a configuration file with the IP address of an NVP controller that was configured outside of devstack.  Other \"controller\" solutions should already follow a similar model as well.","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8929ecb12131619671c0bc3626379787fe32ccf4","unresolved":false,"context_lines":[{"line_number":437,"context_line":"}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"# This routine creates a virtual machine that runs VSM"},{"line_number":440,"context_line":"function _create_devstack_vsm() {"},{"line_number":441,"context_line":"    local vsm_image_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.img"},{"line_number":442,"context_line":"    local vsm_xml_file\u003d$DATA_DIR/quantum/cisco/DEVSTACK_VSM.xml"},{"line_number":443,"context_line":"    local vsm_state"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2Fubk%3D","line":440,"in_reply_to":"AAAAPH%2F%2FusQ%3D","updated":"2013-05-24 12:05:23.000000000","message":"Cisco n1kv plugin requires cisco n1kv software in order to operate. A critical component of n1kv is the VSM (virtual supervisor module). All the compute nodes communicate with the VSM to create networks. \n\nDevstack is to facilitate the deployment of openstack in a development environment or to let people try openstack with ease. VSM is an integral part of it with cisco plugin.","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4031ab3c80e67fc4279b74b3600a5c0514e14213","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        # Note, mac addresses for NICs are hard-coded. VSM seems to take MAC"},{"line_number":502,"context_line":"        # addresses in certain ranges. Therefore, random-generated MAC addresses"},{"line_number":503,"context_line":"        # may not work."},{"line_number":504,"context_line":"\tcat \u003e $vsm_xml_file \u003c\u003c-EOF"},{"line_number":505,"context_line":"\t    \u003cdomain type\u003d\u0027$libvirt_type\u0027\u003e"},{"line_number":506,"context_line":"\t        \u003cname\u003eDEVSTACK_VSM\u003c/name\u003e"},{"line_number":507,"context_line":"\t        \u003cuuid\u003e$vsm_uuid\u003c/uuid\u003e"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2FusY%3D","line":504,"updated":"2013-05-24 09:52:39.000000000","message":"same issue, hard tabs","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8929ecb12131619671c0bc3626379787fe32ccf4","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        # Note, mac addresses for NICs are hard-coded. VSM seems to take MAC"},{"line_number":502,"context_line":"        # addresses in certain ranges. Therefore, random-generated MAC addresses"},{"line_number":503,"context_line":"        # may not work."},{"line_number":504,"context_line":"\tcat \u003e $vsm_xml_file \u003c\u003c-EOF"},{"line_number":505,"context_line":"\t    \u003cdomain type\u003d\u0027$libvirt_type\u0027\u003e"},{"line_number":506,"context_line":"\t        \u003cname\u003eDEVSTACK_VSM\u003c/name\u003e"},{"line_number":507,"context_line":"\t        \u003cuuid\u003e$vsm_uuid\u003c/uuid\u003e"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2FueA%3D","line":504,"in_reply_to":"AAAAPH%2F%2FusY%3D","updated":"2013-05-24 12:05:23.000000000","message":"I can remove the tab in above. The ones in below are needed to maintain indentation for bash here doc","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4031ab3c80e67fc4279b74b3600a5c0514e14213","unresolved":false,"context_lines":[{"line_number":642,"context_line":"function write_n1kv_conf() {"},{"line_number":643,"context_line":"    local n1kv_cfg_file\u003d$1"},{"line_number":644,"context_line":"    sudo cat \u003e $n1kv_cfg_file \u003c\u003c-EOF"},{"line_number":645,"context_line":"\t# This is a sample N1KV configurtion file."},{"line_number":646,"context_line":"\t# \u003cn1kv.conf\u003e file contains all the configuration parameters for UVEM operation."},{"line_number":647,"context_line":"\t# Please find below a brief explanation of these parameters and their meaning."},{"line_number":648,"context_line":"\t# Optional Parameters and Default Values of parameters are explicitly stated."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2Fusc%3D","line":645,"updated":"2013-05-24 09:52:39.000000000","message":"you actually need these hard tabs?","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8929ecb12131619671c0bc3626379787fe32ccf4","unresolved":false,"context_lines":[{"line_number":642,"context_line":"function write_n1kv_conf() {"},{"line_number":643,"context_line":"    local n1kv_cfg_file\u003d$1"},{"line_number":644,"context_line":"    sudo cat \u003e $n1kv_cfg_file \u003c\u003c-EOF"},{"line_number":645,"context_line":"\t# This is a sample N1KV configurtion file."},{"line_number":646,"context_line":"\t# \u003cn1kv.conf\u003e file contains all the configuration parameters for UVEM operation."},{"line_number":647,"context_line":"\t# Please find below a brief explanation of these parameters and their meaning."},{"line_number":648,"context_line":"\t# Optional Parameters and Default Values of parameters are explicitly stated."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2Fud4%3D","line":645,"in_reply_to":"AAAAPH%2F%2Fusc%3D","updated":"2013-05-24 12:05:23.000000000","message":"yes.","commit_id":"a34f2ccabdb3c901838c01dba0914c7f18592a8c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f11da4f2114a1c195cb9d55cb9a62b97b5b61ac1","unresolved":false,"context_lines":[{"line_number":146,"context_line":"# the nexus plugin. The ports will be configured as switchport, and all the"},{"line_number":147,"context_line":"# vlans to be used will be reset."},{"line_number":148,"context_line":"function reset_nexus_switch() {"},{"line_number":149,"context_line":"    python \u003c\u003c-EOF"},{"line_number":150,"context_line":"\tnexus_host \u003d \u0027$1\u0027"},{"line_number":151,"context_line":"\tnexus_info \u003d \u0027$2\u0027"},{"line_number":152,"context_line":"\tvlan_ranges \u003d \u0027$3\u0027"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAPH%2F%2FevI%3D","line":149,"updated":"2013-06-04 19:38:17.000000000","message":"The hard tabs are not needed in this text block. (I tried it.)","commit_id":"fa45427070729f8241dcf65ad46aa70c243b801a"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"dde2236fb28a2b1a45cf088e7bafa2680c55c24b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"# the nexus plugin. The ports will be configured as switchport, and all the"},{"line_number":147,"context_line":"# vlans to be used will be reset."},{"line_number":148,"context_line":"function reset_nexus_switch() {"},{"line_number":149,"context_line":"    python \u003c\u003c-EOF"},{"line_number":150,"context_line":"\tnexus_host \u003d \u0027$1\u0027"},{"line_number":151,"context_line":"\tnexus_info \u003d \u0027$2\u0027"},{"line_number":152,"context_line":"\tvlan_ranges \u003d \u0027$3\u0027"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAPX%2F%2F7VA%3D","line":149,"in_reply_to":"AAAAPH%2F%2FevI%3D","updated":"2013-06-05 21:06:10.000000000","message":"I\u0027m going to take this function out as well. So the hard tabs will no longer be an issue","commit_id":"fa45427070729f8241dcf65ad46aa70c243b801a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ddf79b66daed8e82cf25b7b8d69a37e658bcee38","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Specify the VXLAN range"},{"line_number":19,"context_line":"Q_CISCO_PLUGIN_VXLAN_ID_RANGES\u003d${Q_CISCO_PLUGIN_VXLAN_ID_RANGES:-5000:10000}"},{"line_number":20,"context_line":"# Specify the VLAN range"},{"line_number":21,"context_line":"Q_CISCO_PLUGIN_VLAN_RANGES\u003d${Q_CISCO_PLUGIN_VLAN_RANGES:-vlan:1:4095}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Specify ncclient package information"},{"line_number":24,"context_line":"NCCLIENT_DIR\u003d$DEST/ncclient"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAPX%2F%2Fo6Q%3D","line":21,"updated":"2013-06-13 18:29:35.000000000","message":"Quantum doesn\u0027t support vlan id 4095. Make this range 1:4094.","commit_id":"3adda78021eab53ccb792f207abb9c1fb86b5408"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ddf79b66daed8e82cf25b7b8d69a37e658bcee38","unresolved":false,"context_lines":[{"line_number":26,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":27,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# This routine put a prefix in an existing fucntion name"},{"line_number":30,"context_line":"function _prefix_function() {"},{"line_number":31,"context_line":"    declare -F $1 \u003e /dev/null || die \"$1 doesn\u0027t exist\""},{"line_number":32,"context_line":"    eval \"$(echo \"${2}_${1}()\"; declare -f ${1} | tail -n +2)\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAPX%2F%2Fo5Q%3D","line":29,"updated":"2013-06-13 18:29:35.000000000","message":"\"This routine puts a prefix on an existing function name\"","commit_id":"3adda78021eab53ccb792f207abb9c1fb86b5408"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ddf79b66daed8e82cf25b7b8d69a37e658bcee38","unresolved":false,"context_lines":[{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# This routine populate the cisco config file with the information with regard"},{"line_number":66,"context_line":"# to a particular nexus switch"},{"line_number":67,"context_line":"function _config_switch() {"},{"line_number":68,"context_line":"    local cisco_cfg_file\u003d$1"},{"line_number":69,"context_line":"    local switch_ip\u003d$2"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAPX%2F%2Fo4c%3D","line":66,"updated":"2013-06-13 18:29:35.000000000","message":"\"This routine populates the cisco plugin config file with the information for a particular nexus switch\"","commit_id":"3adda78021eab53ccb792f207abb9c1fb86b5408"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ddf79b66daed8e82cf25b7b8d69a37e658bcee38","unresolved":false,"context_lines":[{"line_number":98,"context_line":"_prefix_function quantum_plugin_setup_interface_driver ovs"},{"line_number":99,"context_line":"_prefix_function has_quantum_plugin_security_group ovs"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Check the version of an installed ncclient package"},{"line_number":102,"context_line":"function check_ncclient_version() {"},{"line_number":103,"context_line":"python \u003c\u003c EOF"},{"line_number":104,"context_line":"version \u003d \u0027$NCCLIENT_VERSION\u0027"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAPX%2F%2Fo4E%3D","line":101,"updated":"2013-06-13 18:29:35.000000000","message":"s/an/the/g","commit_id":"3adda78021eab53ccb792f207abb9c1fb86b5408"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ddf79b66daed8e82cf25b7b8d69a37e658bcee38","unresolved":false,"context_lines":[{"line_number":210,"context_line":"function _configure_nexus_subplugin() {"},{"line_number":211,"context_line":"    local cisco_cfg_file\u003d$1"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    # Install Cisco ncclient if necessary"},{"line_number":214,"context_line":"    if ! is_ncclient_installed; then"},{"line_number":215,"context_line":"        # Preserve the two global variables"},{"line_number":216,"context_line":"        local offline\u003d$OFFLINE"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAPX%2F%2Fo2s%3D","line":213,"updated":"2013-06-13 18:29:35.000000000","message":"\"Install a known compatible ncclient from the Cisco repository if necessary\"","commit_id":"3adda78021eab53ccb792f207abb9c1fb86b5408"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0780ded5900a75c4877570c9ef936569f29b4a4c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# Specify the VSM username"},{"line_number":11,"context_line":"Q_CISCO_PLUGIN_VSM_USERNAME\u003d${Q_CISCO_PLUGIN_VSM_USERNAME:-admin}"},{"line_number":12,"context_line":"# Specify the VSM passward for above username"},{"line_number":13,"context_line":"Q_CISCO_PLUGIN_VSM_PASSWORD\u003d${Q_CISCO_PLUGIN_VSM_PASSWORD:-Sfish123}"},{"line_number":14,"context_line":"# Specify the uVEM integration bridge name"},{"line_number":15,"context_line":"Q_CISCO_PLUGIN_INTEGRATION_BRIDGE\u003d${Q_CISCO_PLUGIN_INTEGRATION_BRIDGE:-br-int}"},{"line_number":16,"context_line":"# Specify if tunneling is enabled"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"AAAAPn%2F%2F%2BlI%3D","line":13,"updated":"2013-06-16 08:21:57.000000000","message":"Other example in the code have secrete or password.\nNot sure if this is an issue though","commit_id":"c209e207da33d380b837243fb114d6a46fed7e22"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0780ded5900a75c4877570c9ef936569f29b4a4c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    if _has_ovs_subplugin; then"},{"line_number":164,"context_line":"        ovs_quantum_plugin_create_nova_conf"},{"line_number":165,"context_line":"    else"},{"line_number":166,"context_line":"        NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"nova.virt.libvirt.vif.LibvirtHybridOVSBridgeDriver\"}"},{"line_number":167,"context_line":"    fi"},{"line_number":168,"context_line":"}"},{"line_number":169,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"AAAAPn%2F%2F%2Bk4%3D","line":166,"updated":"2013-06-16 08:21:57.000000000","message":"why not _quantum_ovs_base_configure_nova_vif_driver?","commit_id":"c209e207da33d380b837243fb114d6a46fed7e22"}],"stackrc":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dd7fb88f5efe26b749443091e18fcbf65eb94e71","unresolved":false,"context_lines":[{"line_number":165,"context_line":"# ncclient"},{"line_number":166,"context_line":"# used by Cisco quantum plugin"},{"line_number":167,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":168,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Nova hypervisor configuration.  We default to libvirt with **kvm** but will"},{"line_number":171,"context_line":"# drop back to **qemu** if we are unable to load the kvm module.  ``stack.sh`` can"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAPX%2F%2F2uI%3D","line":168,"updated":"2013-06-07 13:48:10.000000000","message":"How about defining these in lib/quantum_plugins/cisso? Other repos defined here except ryu are OpenStack general.","commit_id":"3dda1772945d1fede497df41e8362c7a6a393222"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"eb09495b3f3877a47e2ed9443c838ae6845e824c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"# ncclient"},{"line_number":166,"context_line":"# used by Cisco quantum plugin"},{"line_number":167,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":168,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Nova hypervisor configuration.  We default to libvirt with **kvm** but will"},{"line_number":171,"context_line":"# drop back to **qemu** if we are unable to load the kvm module.  ``stack.sh`` can"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAPX%2F%2Fysg%3D","line":168,"in_reply_to":"AAAAPX%2F%2F2to%3D","updated":"2013-06-10 15:42:41.000000000","message":"Let me move it back to lib/quantum_plugins/cisco.","commit_id":"3dda1772945d1fede497df41e8362c7a6a393222"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c07008e9fecfdd0263cccac920d6f180171ff238","unresolved":false,"context_lines":[{"line_number":165,"context_line":"# ncclient"},{"line_number":166,"context_line":"# used by Cisco quantum plugin"},{"line_number":167,"context_line":"NCCLIENT_REPO\u003d${NCCLIENT_REPO:-${GIT_BASE}/CiscoSystems/ncclient.git}"},{"line_number":168,"context_line":"NCCLIENT_BRANCH\u003d${NCCLIENT_BRANCH:-master}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Nova hypervisor configuration.  We default to libvirt with **kvm** but will"},{"line_number":171,"context_line":"# drop back to **qemu** if we are unable to load the kvm module.  ``stack.sh`` can"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAPX%2F%2F2to%3D","line":168,"in_reply_to":"AAAAPX%2F%2F2uI%3D","updated":"2013-06-07 13:52:39.000000000","message":"I think it\u0027s fine to leave these here, as ncclient is not proprietary and the Ryu precedent has been set. Enforcing a new precedent like this when the patch is following an existing precedent seems unclear at best.","commit_id":"3dda1772945d1fede497df41e8362c7a6a393222"}]}