)]}'
{"id":"openstack%2Fdevstack~280028","triplet_id":"openstack%2Fdevstack~master~I710cf142b834381c00e651cfc062299ae755c33f","project":"openstack/devstack","branch":"master","topic":"exec_dirs","hashtags":[],"change_id":"I710cf142b834381c00e651cfc062299ae755c33f","subject":"Add /usr/local/bin to rootwrap exec_dirs","status":"ABANDONED","created":"2016-02-14 23:25:40.000000000","updated":"2016-02-22 03:24:04.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b34a9cbfbc5a7363a4adc6f80fa59e38a95cb86d","_number":280028,"virtual_id_number":280028,"owner":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-02-15 01:15:51.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2016-02-15 01:21:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-02-15 00:51:44.000000000","_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"date":"2016-02-15 01:21:57.000000000","_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"date":"2016-02-15 00:27:03.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"date":"2016-02-15 03:02:06.000000000","_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-15 00:27:03.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-02-15 00:51:44.000000000","updated_by":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"reviewer":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"state":"REVIEWER"},{"updated":"2016-02-15 01:15:51.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-02-15 01:21:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-02-15 01:21:57.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"}],"messages":[{"id":"497a54583b739c7f1f370d39284a9821136ba7e2","author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"date":"2016-02-14 23:25:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0c7d5c6b73ec5c8916437f99b14268b79c7257b3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-02-14 23:43:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1732a9c757f566f975b0ebec28a2b8a4e7daf189","author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"date":"2016-02-14 23:58:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"93d36415bd3126285c8d051a62daa446bd052931","author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"date":"2016-02-14 23:59:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"80641ee12b13f9b64a897e41cc29cb66a7c62c51","author":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"date":"2016-02-15 00:08:31.000000000","message":"Patch Set 1:\n\nBuild Successful.\n* networking-odl-vhostuser-ci http://intel-openstack-ci-logs.ovh/networking-odl-vhostuser-ci/refs/changes/28/280028/1 : SUCCESS\n\nTo re-run the job please post a comment with `recheck networking-odl-vhostuser-ci`","accounts_in_message":[],"_revision_number":1},{"id":"ed99662a2e997fde3d494c83e5799195cd9bcbf7","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-02-15 00:27:03.000000000","message":"Patch Set 2:\n\nI have such a sense of déjà vu about this ...\n\nThere was quite a discussion about this for neutron in Iade8b5b09bb53018485c85f8372fb94dbc2ad2da\n\ntrying to see if i can remember any other discussions on it...","accounts_in_message":[],"_revision_number":2},{"id":"71e6b50c37ba3aed5f1600e0179e93056edf9571","author":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"date":"2016-02-15 00:51:44.000000000","message":"Patch Set 2:\n\nBuild Successful.\n* networking-odl-vhostuser-ci http://intel-openstack-ci-logs.ovh/networking-odl-vhostuser-ci/refs/changes/28/280028/2 : SUCCESS\n\nTo re-run the job please post a comment with `recheck networking-odl-vhostuser-ci`","accounts_in_message":[],"_revision_number":2},{"id":"7871eabf4446eb5af2054b43fa3ecfb919f7e3b3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-02-15 01:05:56.000000000","message":"Patch Set 2:\n\nfuther thoughts, we have nova that doesn\u0027t include /usr/local [1] and cinder that does [2] and neutron that does [3]!\n\nThat neutron one is interesting, because after 4 rather emphatic -1\u0027s in I3abd1c173121dc8abb5738d1879db8ac9a98b690 (Apr 2015) ; exactly the same thing went through in Ib3646933744ca6b20ecd5ad0cedcedb4f1fa5f12 (Jun 2, 2015) unopposed ... after we have merged devstack changes to fix it up (so i guess we can revert them...)!  \n\nSo, do we care about the default values provided by projects when clearly they can\u0027t decide themselves?\n\nIf you consider devstack a deployment tool like any other, i guess it makes sense for us to modify the different incoming rootwrap.conf files and just fix them up to have /usr/local in them ... because they all have different opinions on that.\n\nOTOH, devstack has sometimes tried to push back stuff like this to get consistency in the underlying projects where they are clearly out of sync.\n\nI don\u0027t know what\u0027s appropriate here ... thoughts?\n\n[1] https://git.openstack.org/cgit/openstack/nova/tree/etc/nova/rootwrap.conf\n[2] https://git.openstack.org/cgit/openstack/cinder/tree/etc/cinder/rootwrap.conf\n[3] https://git.openstack.org/cgit/openstack/neutron/tree/etc/rootwrap.conf","accounts_in_message":[],"_revision_number":2},{"id":"301fb2371420ff174684405df585597c56015fa5","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-02-15 01:15:51.000000000","message":"Patch Set 2:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/28/280028/2/6254/index.html : SUCCESS in 01 h 13 m 43 s","accounts_in_message":[],"_revision_number":2},{"id":"bdcd450a0753fe07856c9753d8ee1b06c4f942ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-15 01:21:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-tempest-dsvm-full http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-full/a037484/ : SUCCESS in 36m 17s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-postgres-full/f761ff9/ : SUCCESS in 36m 13s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-neutron-full/75cbf02/ : SUCCESS in 45m 29s\n- gate-grenade-dsvm http://logs.openstack.org/28/280028/2/check/gate-grenade-dsvm/e7014c7/ : FAILURE in 28m 36s\n- gate-devstack-bashate http://logs.openstack.org/28/280028/2/check/gate-devstack-bashate/eea5276/ : SUCCESS in 20s\n- gate-devstack-unit-tests http://logs.openstack.org/28/280028/2/check/gate-devstack-unit-tests/75181f5/ : SUCCESS in 18s\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-ironic-agent_ssh-nv/2133315/ : SUCCESS in 26m 03s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/28/280028/2/check/gate-devstack-dsvm-updown/f096831/ : SUCCESS in 15m 02s\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-centos7/e4484c2/ : SUCCESS in 39m 39s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-neutron-identity-v3-only-full/293fa46/ : SUCCESS in 48m 55s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/28/280028/2/check/gate-devstack-publish-docs/a530041//doc/build/html/ : SUCCESS in 1m 25s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/28/280028/2/check/gate-swift-dsvm-functional-nv/3a558e2/ : SUCCESS in 18m 51s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/28/280028/2/check/gate-grenade-dsvm-neutron/fdfc3f4/ : SUCCESS in 41m 50s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-multinode-full/57246ba/ : SUCCESS in 55m 28s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/28/280028/2/check/gate-tempest-dsvm-neutron-multinode-full/9e50b9d/ : SUCCESS in 1h 20m 32s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/28/280028/2/check/gate-grenade-dsvm-multinode/fe9b024/ : SUCCESS in 33m 05s","accounts_in_message":[],"_revision_number":2},{"id":"360635bda327bfd8b5dda639bcbb7a8cdccc853c","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2016-02-15 01:21:57.000000000","message":"Patch Set 2:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-grenade-dsvm: https://bugs.launchpad.net/bugs/1545002\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":2},{"id":"f1239c70bd018266139f193ae9cdd6944ba6abfa","author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"date":"2016-02-15 03:02:06.000000000","message":"Patch Set 2:\n\n\u003e I don\u0027t know what\u0027s appropriate here ... thoughts?\n\nI went back and forth on exactly the same question before posting this change.  If we were installing into somewhere non-standard like (for example) /opt/stack/bin, then it would clearly be up to devstack to make sure that /opt/stack/bin was in exec_dirs.  /usr/local/bin however is a \"standard\" location and quite a reasonable thing to expect to already find in exec_dirs (imo) - it is typically already included in sudoers/secure_path, for a precedent from something very similar.\n\nI\u0027m kind of inclined to ensure /usr/local/bin is in every project\u0027s rootwrap.conf, since this will be most likely to \"just work\" for other non-devstack deployment methods - and I\u0027m happy to do the legwork if that\u0027s the direction we\u0027re agreeing to follow.\n\nI am presuming here that we agree that adding rules for both \"$foo\" and \"/usr/local/bin/$foo\" in rootwrap filters is definitely *not* the correct solution here (see [1] for such an example), and that the only open question is exactly _how_ /usr/local/bin gets added to exec_dirs.\n\n[1] https://github.com/openstack/cinder/blob/master/etc/cinder/rootwrap.d/volume.filters#L112","accounts_in_message":[],"_revision_number":2},{"id":"18998e021f86221092a09d5e4d59c03f66c0e5d3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-02-15 03:50:37.000000000","message":"Patch Set 2:\n\njust for reference on what\u0027s using what\n\n ./sahara_c17cc3d2b6fb8b583bbaf86283d12b955553c3ea/etc/sahara/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./cinder_05ce6110a61ecd6eb0eb4d92762328dba6090530/etc/cinder/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin\n ./manila_1ff7e3f56b02366f1dbfcdf242951825028de70f/etc/manila/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin,/usr/lpp/mmfs/bin\n  ./tacker_b81f8e9eb12398de20469ed21c69acf488ec8b82/etc/tacker/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./neutron_fd589cb3dfcf8e416a6dbacdd35b50e76d81bd43/etc/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin\n ./ironic_15e0f2b01c325d8af469bffa4f9554507bd63b35/etc/ironic/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./ceilometer_26e38b6132885ab96bdd0fa14b42fff7355a0524/etc/ceilometer/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./oslo_rootwrap_cd2e0949322c697796043d99eea86f07144f756c/benchmark/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./nova_8befe75c700f6b94150a85a84de50b052e5c8a19/etc/nova/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./ironic_inspector_bf46a1063dd2562d43fd9ac47fdd1dc151c2537e/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin\n ./astara_8092b1e000976b39304c98cae0e9b197ff3cf153/etc/rootwrap.conf\n exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin","accounts_in_message":[],"_revision_number":2},{"id":"2f50ad976c330040ebd6f7485fe0fbb95fe17c47","author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"date":"2016-02-15 04:17:00.000000000","message":"Patch Set 2:\n\nUntil some nova reviewer points the finger of responsibility back in the other direction, this change is most likely superseded by I6a0a4b7f952193ce0f4ed2594613188854d36bf1 (and similar changes to other projects)","accounts_in_message":[],"_revision_number":2},{"id":"969483f419463d410ca920ed39115051b2f7e1af","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-02-15 20:38:17.000000000","message":"Patch Set 2:\n\nOK, sounds good, thanks.  The less magic hidden in devstack the better ... it avoids [1]\n\n[1] https://twitter.com/EmilienMacchi/status/699267755002953728","accounts_in_message":[],"_revision_number":2},{"id":"35f956103ca2ea0c639b2225a5a5e5dc98ef4b51","author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"date":"2016-02-22 03:24:04.000000000","message":"Abandoned\n\nAbandoned in favour of per-project changes.  Specifically nova: I6a0a4b7f952193ce0f4ed2594613188854d36bf1","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8f416bda61971e54806efb06387fc23d236026b3","revisions":{"44d4b9183eede4a61c21665907b1d6b99885723a":{"kind":"REWORK","_number":1,"created":"2016-02-14 23:25:40.000000000","uploader":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"ref":"refs/changes/28/280028/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/28/280028/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/28/280028/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/28/280028/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/28/280028/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/28/280028/1"}}},"commit":{"parents":[{"commit":"4723e618ccf5e3dda01776221f95f289ae97540d","subject":"Merge \"Don\u0027t die when yum fails.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4723e618ccf5e3dda01776221f95f289ae97540d"}]}],"author":{"name":"Angus Lees","email":"gus@inodes.org","date":"2016-02-14 23:22:01.000000000","tz":660},"committer":{"name":"Angus Lees","email":"gus@inodes.org","date":"2016-02-14 23:22:01.000000000","tz":660},"subject":"Add /usr/local/bin to rootwrap exec_dirs","message":"Add /usr/local/bin to rootwrap exec_dirs\n\nDevstack installs several commands via non-distro means (eg: pip), and\nthese typically get installed into /usr/local/bin.  These are as equally\n\"trusted\" as /usr/bin and friends, and should be included in\nrootwrap.conf\u0027s exec_dirs path.\n\nIn particular, this allows oslo.privsep\u0027s \"privsep-helper\" executable to\nbe found+executed via rootwrap.\n\nChange-Id: I710cf142b834381c00e651cfc062299ae755c33f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/44d4b9183eede4a61c21665907b1d6b99885723a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/44d4b9183eede4a61c21665907b1d6b99885723a"}]},"branch":"refs/heads/master"},"8f416bda61971e54806efb06387fc23d236026b3":{"kind":"REWORK","_number":2,"created":"2016-02-14 23:58:42.000000000","uploader":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"ref":"refs/changes/28/280028/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/28/280028/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/28/280028/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/28/280028/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/28/280028/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/28/280028/2"}}},"commit":{"parents":[{"commit":"4723e618ccf5e3dda01776221f95f289ae97540d","subject":"Merge \"Don\u0027t die when yum fails.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4723e618ccf5e3dda01776221f95f289ae97540d"}]}],"author":{"name":"Angus Lees","email":"gus@inodes.org","date":"2016-02-14 23:22:01.000000000","tz":660},"committer":{"name":"Angus Lees","email":"gus@inodes.org","date":"2016-02-14 23:58:30.000000000","tz":660},"subject":"Add /usr/local/bin to rootwrap exec_dirs","message":"Add /usr/local/bin to rootwrap exec_dirs\n\nDevstack installs several commands via non-distro means (eg: pip), and\nthese typically get installed into /usr/local/bin.  These are as equally\n\"trusted\" as /usr/bin and friends, and should be included in\nrootwrap.conf\u0027s exec_dirs path.\n\nIn particular, this allows oslo.privsep\u0027s \"privsep-helper\" executable to\nbe found+executed via rootwrap.\n\nChange-Id: I710cf142b834381c00e651cfc062299ae755c33f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8f416bda61971e54806efb06387fc23d236026b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8f416bda61971e54806efb06387fc23d236026b3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}