)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"efb94588c0fd209f2e7592751b70278223f68376","unresolved":false,"context_lines":[{"line_number":12,"context_line":"LinuxMint or allow the catchall and let the deployers deal with it. If complaints"},{"line_number":13,"context_line":"arise regarding \u0027Why doesnt it work for my distro\u0027 they should be"},{"line_number":14,"context_line":"pointed to documentation regarding the supported distro list."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I42599c1bd851d2b61a56a3960f42ad051aab1727"},{"line_number":17,"context_line":"Closes-Bug: #1545864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_03b09342","line":15,"updated":"2016-02-15 22:29:39.000000000","message":"I\u0027d say devstack is going to *not* work in more places than it will work, so a white-list is good.  That said, Mint is clearly ubuntu/debian-ish enough to work.\n\nSo I\u0027d prefer to just see a line for LinuxMint added lumping it with these distros, similar to the way oraclelinux is grouped with rhel.  we already match on LinuxMint in os_PACKAGE anyway","commit_id":"dac3c4d4bf61eeb0e7105abe8bfa78b0206f1015"}],"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"efb94588c0fd209f2e7592751b70278223f68376","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) || \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":369,"context_line":"        # \u0027Everyone\u0027 refers to Ubuntu / Debian releases by"},{"line_number":370,"context_line":"        # the code name adjective"},{"line_number":371,"context_line":"        DISTRO\u003d$os_CODENAME"},{"line_number":372,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Fedora) ]]; then"},{"line_number":373,"context_line":"        # For Fedora, just use \u0027f\u0027 and the release"},{"line_number":374,"context_line":"        DISTRO\u003d\"f$os_RELEASE\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dae33548_a381e74c","line":371,"updated":"2016-02-15 22:29:39.000000000","message":"we\u0027ve already got LinuxMint above in the os_PACKAGE check.  seems like we just need to add something sensible here ...","commit_id":"dac3c4d4bf61eeb0e7105abe8bfa78b0206f1015"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1097bb8252f519a1df738a10a4fde7eee00036f2","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) || \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":369,"context_line":"        # \u0027Everyone\u0027 refers to Ubuntu / Debian releases by"},{"line_number":370,"context_line":"        # the code name adjective"},{"line_number":371,"context_line":"        DISTRO\u003d$os_CODENAME"},{"line_number":372,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Fedora) ]]; then"},{"line_number":373,"context_line":"        # For Fedora, just use \u0027f\u0027 and the release"},{"line_number":374,"context_line":"        DISTRO\u003d\"f$os_RELEASE\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dae33548_be261e66","line":371,"in_reply_to":"dae33548_83882324","updated":"2016-02-15 23:11:47.000000000","message":"So, I think we might have two different thigns\n\n1) there is a bit of a regression in FORCE\u003dyes ... maybe.  previously, we would pick up some default value for DISTRO and you could continue on with FORCE\u003dyes.  Now we just bail\n\n2) In this LinuxMint case, it seems that FORCE\u003dyes was not previously required because I think we fell back to debian matching.  \n\nSo\n\n1) We should probably add a catch-all DISTRO setting, but only if FORCE is set.  That can be a separate change\n\n2) We should formalise how we\u0027re matching LinuxMint so this isn\u0027t just working by happy accident.  I\u0027m fine if that\u0027s just matching os_VENDOR of Mint and say \"this is enough like debian we just use that\"","commit_id":"dac3c4d4bf61eeb0e7105abe8bfa78b0206f1015"},{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"6daf09971c681a5185dd83faa244dcb4d6f2fa2d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) || \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":369,"context_line":"        # \u0027Everyone\u0027 refers to Ubuntu / Debian releases by"},{"line_number":370,"context_line":"        # the code name adjective"},{"line_number":371,"context_line":"        DISTRO\u003d$os_CODENAME"},{"line_number":372,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Fedora) ]]; then"},{"line_number":373,"context_line":"        # For Fedora, just use \u0027f\u0027 and the release"},{"line_number":374,"context_line":"        DISTRO\u003d\"f$os_RELEASE\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dae33548_83882324","line":371,"in_reply_to":"dae33548_a381e74c","updated":"2016-02-15 22:37:26.000000000","message":"I\u0027m absolutely ok doing this, is Devstack willing to accept LinuxMint as \u0027supported\u0027? I still dont believe the proper behavior is to die considering the amount of redhat and debian derivatives out there. I am willing to support the version we work off of to get us going on, but would like this to work for others that may not be in the supported list still.","commit_id":"dac3c4d4bf61eeb0e7105abe8bfa78b0206f1015"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8b3018e174594236a0e7e81c84ce536b59c72f02","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) || \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":369,"context_line":"        # \u0027Everyone\u0027 refers to Ubuntu / Debian releases by"},{"line_number":370,"context_line":"        # the code name adjective"},{"line_number":371,"context_line":"        DISTRO\u003d$os_CODENAME"},{"line_number":372,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Fedora) ]]; then"},{"line_number":373,"context_line":"        # For Fedora, just use \u0027f\u0027 and the release"},{"line_number":374,"context_line":"        DISTRO\u003d\"f$os_RELEASE\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dae33548_59bbacc4","line":371,"in_reply_to":"dae33548_be261e66","updated":"2016-02-16 00:10:03.000000000","message":"On point 1) ; see I4b07259be1427d86a7154906646073d08dd07294.  I don\u0027t think we can actually make a good choice.\n\nFORCE\u003dyes should remain as overriding the DISTRO check (i.e. when someone wants to test on the next fedora, or the next ubuntu, that we don\u0027t support yet).  But on an unknown *platform* we\u0027re just don\u0027t know what to do","commit_id":"dac3c4d4bf61eeb0e7105abe8bfa78b0206f1015"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"efb94588c0fd209f2e7592751b70278223f68376","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        DISTRO\u003d\"${os_VENDOR}${os_RELEASE::1}\""},{"line_number":390,"context_line":"    else"},{"line_number":391,"context_line":"        # Catch-all for now is Vendor + Release + Update"},{"line_number":392,"context_line":"        DISTRO\u003d\"$os_VENDOR-$os_RELEASE.$os_UPDATE\""},{"line_number":393,"context_line":"        echo \"Distro: $DISTRO is not supported, continuing could result in unwanted behavior.\""},{"line_number":394,"context_line":"    fi"},{"line_number":395,"context_line":"    typeset -xr DISTRO"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dae33548_e33e4fb7","line":392,"updated":"2016-02-15 22:29:39.000000000","message":"there is no os_UPDATE at this point (see comments on I46a2c36d95327087085df07cb797eb91249a893c)","commit_id":"dac3c4d4bf61eeb0e7105abe8bfa78b0206f1015"},{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"e52cf71a9c41ea9d0e396d8865e007ac23f7112d","unresolved":false,"context_lines":[{"line_number":366,"context_line":"function GetDistro {"},{"line_number":367,"context_line":"    GetOSVersion"},{"line_number":368,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) || \"$os_VENDOR\" \u003d~ (Debian) || \\"},{"line_number":369,"context_line":"            \"$os_VENDOR\" \u003d~ (LinuxMint) ]]; then"},{"line_number":370,"context_line":"        # \u0027Everyone\u0027 refers to Ubuntu / Debian / Mint releases by"},{"line_number":371,"context_line":"        # the code name adjective"},{"line_number":372,"context_line":"        DISTRO\u003d$os_CODENAME"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dae33548_5c7399e7","line":369,"updated":"2016-02-16 02:12:02.000000000","message":"correct alignment.\n\nlook at lines 380-383","commit_id":"96006658bedbdfa98e4d0685852f057aeb2ae1a6"}]}