)]}'
{"files/apts/general":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ad4afae1ebb74f64e4513b45152032b366bad70f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"tar"},{"line_number":23,"context_line":"python-cmd2 # dist:precise"},{"line_number":24,"context_line":"python-netaddr"},{"line_number":25,"context_line":"python-netaddr # dist:wheezy"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2Fja0%3D","line":25,"updated":"2013-05-04 12:23:54.000000000","message":"not needed","commit_id":"db896d9b5e92bcc268a3c6bedb1f1056228b5f60"}],"functions":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ad4afae1ebb74f64e4513b45152032b366bad70f","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    if [[ \"$os_VENDOR\" \u003d~ (Ubuntu) ]]; then"},{"line_number":435,"context_line":"        # \u0027Everyone\u0027 refers to Ubuntu releases by the code name adjective"},{"line_number":436,"context_line":"        DISTRO\u003d$os_CODENAME"},{"line_number":437,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":438,"context_line":"        DISTRO\u003d$os_CODENAME"},{"line_number":439,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Fedora) ]]; then"},{"line_number":440,"context_line":"        # For Fedora, just use \u0027f\u0027 and the release"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2Fja4%3D","line":437,"updated":"2013-05-04 12:23:54.000000000","message":"given that the DISTRO\u003d logic is the same for both blocks, can we just put both into the match.","commit_id":"db896d9b5e92bcc268a3c6bedb1f1056228b5f60"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ad4afae1ebb74f64e4513b45152032b366bad70f","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        GetOSVersion"},{"line_number":477,"context_line":"    fi"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    [ \"$os_PACKAGE\" \u003d \"deb\" ] || [ \"$os_VENDOR\" \u003d \"Debian\" ]"},{"line_number":480,"context_line":"}"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"# Determine if current distribution is a Fedora-based distribution"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2Fja8%3D","line":479,"updated":"2013-05-04 12:23:54.000000000","message":"this returns true under Ubuntu","commit_id":"db896d9b5e92bcc268a3c6bedb1f1056228b5f60"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"172bba5f6c791dddb089871fca61d7e184ea8bef","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        os_PACKAGE\u003d\"rpm\""},{"line_number":339,"context_line":"        if [[ \"Debian,Ubuntu,LinuxMint\" \u003d~ $os_VENDOR ]]; then"},{"line_number":340,"context_line":"            os_PACKAGE\u003d\"deb\""},{"line_number":341,"context_line":"            if [[ $(lsb_release -d -s | grep -q Ubuntu) -eq 0 ]]; then"},{"line_number":342,"context_line":"                os_VENDOR\u003d\"Ubuntu\""},{"line_number":343,"context_line":"            fi"},{"line_number":344,"context_line":"            if [[ $(lsb_release -d -s | grep -q Debian) -eq 0 ]]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAOn%2F%2FjK8%3D","line":341,"updated":"2013-05-05 07:45:56.000000000","message":"This block is not needed os_VENDOR is already correct","commit_id":"a7ec9d8c22b4f198c7fa40967f812e9bbc32f693"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"efa81354848eadc8925d3ca3b84db86539958668","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        GetOSVersion"},{"line_number":466,"context_line":"    fi"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    [ \"$os_PACKAGE\" \u003d \"deb\" ] \u0026\u0026 [ \"os_VENDOR\" \u003d \"Ubuntu\" ]"},{"line_number":469,"context_line":"}"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"function is_debian {"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAOn%2F%2Fir0%3D","line":468,"updated":"2013-05-06 08:16:26.000000000","message":"missing $os_VENDOR","commit_id":"db1cc1f4bb8396fc82ec7f5f3782862a94edb1e4"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c9ee4539dcb68bfb1f3202d74f830abef94fe69d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"GetOSVersion() {"},{"line_number":308,"context_line":"    # In Debian, it may happen that lsb_release is not installed."},{"line_number":309,"context_line":"    if [ -f /etc/debian_version ] \u0026\u0026 [ ! -x $(which lsb_release 2\u003e/dev/null) ]; then"},{"line_number":310,"context_line":"        apt-get -y install lsb-release"},{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"    # Figure out which vendor we are"},{"line_number":313,"context_line":"    if [[ -n \"`which sw_vers 2\u003e/dev/null`\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"AAAAOn%2F%2FeNc%3D","line":310,"updated":"2013-05-08 17:59:18.000000000","message":"This function is called in a lot of different contexts, installing a package here is not acceptable.  if lsb-release is not present do a best-effort to determine what the OS is.","commit_id":"62f2c67e3faf09626f2f12552b9b01b8ee8a0e88"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c9ee4539dcb68bfb1f3202d74f830abef94fe69d","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    [ \"$os_PACKAGE\" \u003d \"deb\" ]"},{"line_number":467,"context_line":"}"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"function is_debian {"},{"line_number":470,"context_line":"    if [[ -z \"$os_PACKAGE\" ]]; then"},{"line_number":471,"context_line":"        GetOSVersion"},{"line_number":472,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"AAAAOn%2F%2FeNs%3D","line":469,"updated":"2013-05-08 17:59:18.000000000","message":"This function is unnecessary.  is_ubuntu() and is_fedora() are tests for distro families.  Where you need to be able to distinguish between ubuntu and debian use os_VENDOR.\n\nThis eliminates all of your changes that add \"|| is_debian\" to conditionals.","commit_id":"62f2c67e3faf09626f2f12552b9b01b8ee8a0e88"}],"stack.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3199512ef09ecda96754a65e8d98f87d0150282d","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"# Warn users who aren\u0027t on an explicitly supported distro, but allow them to"},{"line_number":107,"context_line":"# override check and attempt installation with ``FORCE\u003dyes ./stack``"},{"line_number":108,"context_line":"if [[ ! ${DISTRO} \u003d~ (oneiric|precise|quantal|raring|saucy|debian|f16|f17|f18|opensuse-12.2|rhel6) ]]; then"},{"line_number":109,"context_line":"    echo \"WARNING: this script has not been tested on $DISTRO\""},{"line_number":110,"context_line":"    if [[ \"$FORCE\" !\u003d \"yes\" ]]; then"},{"line_number":111,"context_line":"        die $LINENO \"If you wish to run this script anyway run with FORCE\u003dyes\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAOn%2F%2FjhU%3D","line":108,"updated":"2013-05-04 03:50:22.000000000","message":"typo?  maybe diff viewer is just confused","commit_id":"1a662b4fd430e62760ba2130972aa3ff14ce8a42"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3199512ef09ecda96754a65e8d98f87d0150282d","unresolved":false,"context_lines":[{"line_number":582,"context_line":"fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"if [[ is_debian ]]; then"},{"line_number":585,"context_line":"    install_package python-netaddr"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    # The Grizzly version is not yet available in Debian Wheezy official"},{"line_number":588,"context_line":"    # repositories since some packages are still under review by its"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAOn%2F%2FjhM%3D","line":585,"updated":"2013-05-04 03:50:22.000000000","message":"probably want to add this to apts/general with a # distro: comment","commit_id":"1a662b4fd430e62760ba2130972aa3ff14ce8a42"}],"stackrc":[{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"948fa4fd5d22109fd955fec6f3d13727e751a61b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"# also install an **LXC** or **OpenVZ** based system."},{"line_number":163,"context_line":"VIRT_DRIVER\u003d${VIRT_DRIVER:-libvirt}"},{"line_number":164,"context_line":"LIBVIRT_TYPE\u003d${LIBVIRT_TYPE:-kvm}"},{"line_number":165,"context_line":"if [[ \"$os_VENDOR\" \u003d~ (Debian) ]]; then"},{"line_number":166,"context_line":"  LIBVIRT_GROUP\u003dlibvirt"},{"line_number":167,"context_line":"else"},{"line_number":168,"context_line":"  LIBVIRT_GROUP\u003dlibvirtd"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"AAAAOn%2F%2FcAc%3D","line":165,"updated":"2013-05-09 17:38:40.000000000","message":"os_VENDOR is not defined","commit_id":"b2ef890db3d78b24f9da2f4dd80502165c669ad0"}]}