)]}'
{"tools/xen/README.md":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a698331d6f41bbc5284ea72a8677897bc8a35bc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # UBUNTU_INST_RELEASE\u003dprecise"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # First time Ubuntu network install params"},{"line_number":72,"context_line":"    # UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":73,"context_line":"    # UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":74,"context_line":"    EOF"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"AAAAOn%2F%2Fcv8%3D","line":72,"updated":"2013-05-09 08:35:04.000000000","message":"I missed this one, its an odd default to have HOST_IP_IFACE different to UBUNTU_INST_IFACE.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"195bb09ba733046bf870d6c27660bb425d5a84ae","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # UBUNTU_INST_RELEASE\u003dprecise"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # First time Ubuntu network install params"},{"line_number":72,"context_line":"    # UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":73,"context_line":"    # UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":74,"context_line":"    EOF"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"AAAAOn%2F%2FctY%3D","line":72,"in_reply_to":"AAAAOn%2F%2Fcv8%3D","updated":"2013-05-09 09:20:06.000000000","message":"Let\u0027s set it to eth3, so the default remains the same, and let\u0027s address networking issues in the next change.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"124e6cd7ba284d9f953afd83c518a374adb3812b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # UBUNTU_INST_RELEASE\u003dprecise"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # First time Ubuntu network install params"},{"line_number":72,"context_line":"    # UBUNTU_INST_IFACE\u003d\"eth3\""},{"line_number":73,"context_line":"    # UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":74,"context_line":"    EOF"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":9,"id":"AAAAOn%2F%2FXvQ%3D","line":72,"updated":"2013-05-13 11:22:29.000000000","message":"I would probably just remove these myself, but lets look at that in the network refactor change.","commit_id":"0b3804bff7899211d3a80de5f7f22d3bc616f3bc"}],"tools/xen/install_os_domU.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03541cf2bec3bfc9bcc02f463b09698654a74d23","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# For more details see: README.md"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"set -exu"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Abort if localrc is not set"},{"line_number":12,"context_line":"if [ ! -e ../../localrc ]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcRk%3D","line":9,"updated":"2013-05-09 15:31:15.000000000","message":"It\u0027s a style preference but I do prefer the more verbose form of set commands.","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"aadb3b3561a656da368ff8dde2b612367d66b3b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# For more details see: README.md"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"set -exu"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Abort if localrc is not set"},{"line_number":12,"context_line":"if [ ! -e ../../localrc ]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcNc%3D","line":9,"in_reply_to":"AAAAOn%2F%2FcRk%3D","updated":"2013-05-09 15:51:53.000000000","message":"Done","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"}],"tools/xen/prepare_guest.sh":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e76383e8d374b03b76871977cc9f7fa4ebd0a800","unresolved":false,"context_lines":[{"line_number":22,"context_line":"STACK_USER\u003d${STACK_USER:-stack}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Install basics"},{"line_number":25,"context_line":"chroot $STAGING_DIR apt-get update"},{"line_number":26,"context_line":"chroot $STAGING_DIR apt-get install -y cracklib-runtime curl wget ssh openssh-server tcpdump ethtool"},{"line_number":27,"context_line":"chroot $STAGING_DIR apt-get install -y curl wget ssh openssh-server python-pip git vim-nox sudo"},{"line_number":28,"context_line":"chroot $STAGING_DIR pip install xenapi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"AAAAOn%2F%2Fcwg%3D","side":"PARENT","line":25,"updated":"2013-05-09 08:24:20.000000000","message":"I don\u0027t think this gets used in its chroot from any more. Probably a hangover from when it got extracted from the XenServer build system. So +1 to this.","commit_id":"b240ad472be39786c587acc75ef40de6e61a4b2d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03541cf2bec3bfc9bcc02f463b09698654a74d23","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# creating the user called \"stack\","},{"line_number":11,"context_line":"# and shuts down the VM to signal the script has completed"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"set -exu"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Configurable nuggets"},{"line_number":16,"context_line":"GUEST_PASSWORD\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcRU%3D","line":13,"updated":"2013-05-09 15:31:15.000000000","message":"Again, I prefer the verbose form","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"aadb3b3561a656da368ff8dde2b612367d66b3b7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# creating the user called \"stack\","},{"line_number":11,"context_line":"# and shuts down the VM to signal the script has completed"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"set -exu"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Configurable nuggets"},{"line_number":16,"context_line":"GUEST_PASSWORD\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcNY%3D","line":13,"in_reply_to":"AAAAOn%2F%2FcRU%3D","updated":"2013-05-09 15:51:53.000000000","message":"Done","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03541cf2bec3bfc9bcc02f463b09698654a74d23","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# Configurable nuggets"},{"line_number":16,"context_line":"GUEST_PASSWORD\u003d\"$1\""},{"line_number":17,"context_line":"XS_TOOLS_PATH\u003d\"$2\""},{"line_number":18,"context_line":"STACK_USER\u003d\"$3\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Install basics"},{"line_number":21,"context_line":"apt-get update"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcRY%3D","line":18,"updated":"2013-05-09 15:31:15.000000000","message":"If you are going to remove the defaults shouldn\u0027t you be checking for the presence of all required args?","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"aadb3b3561a656da368ff8dde2b612367d66b3b7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# Configurable nuggets"},{"line_number":16,"context_line":"GUEST_PASSWORD\u003d\"$1\""},{"line_number":17,"context_line":"XS_TOOLS_PATH\u003d\"$2\""},{"line_number":18,"context_line":"STACK_USER\u003d\"$3\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Install basics"},{"line_number":21,"context_line":"apt-get update"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcOI%3D","line":18,"in_reply_to":"AAAAOn%2F%2FcRY%3D","updated":"2013-05-09 15:51:53.000000000","message":"set -o nounset will cause the script to die, if the arg is not there.","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"}],"tools/xen/prepare_guest_template.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03541cf2bec3bfc9bcc02f463b09698654a74d23","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# The resultant image is started by install_os_domU.sh,"},{"line_number":16,"context_line":"# and once the VM has shutdown, build_xva.sh is run"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set -exu"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# This directory"},{"line_number":21,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcRM%3D","line":18,"updated":"2013-05-09 15:31:15.000000000","message":"Again, verbose form","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"aadb3b3561a656da368ff8dde2b612367d66b3b7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# The resultant image is started by install_os_domU.sh,"},{"line_number":16,"context_line":"# and once the VM has shutdown, build_xva.sh is run"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set -exu"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# This directory"},{"line_number":21,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcNQ%3D","line":18,"in_reply_to":"AAAAOn%2F%2FcRM%3D","updated":"2013-05-09 15:51:53.000000000","message":"Done","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"}],"tools/xen/scripts/install_ubuntu_template.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"03541cf2bec3bfc9bcc02f463b09698654a74d23","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Based on a script by: David Markey \u003cdavid.markey@citrix.com\u003e"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"set -exu"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# This directory"},{"line_number":13,"context_line":"BASE_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcRA%3D","line":10,"updated":"2013-05-09 15:31:15.000000000","message":"Again, verbose form","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"aadb3b3561a656da368ff8dde2b612367d66b3b7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Based on a script by: David Markey \u003cdavid.markey@citrix.com\u003e"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"set -exu"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# This directory"},{"line_number":13,"context_line":"BASE_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAOn%2F%2FcNM%3D","line":10,"in_reply_to":"AAAAOn%2F%2FcRA%3D","updated":"2013-05-09 15:51:53.000000000","message":"Done","commit_id":"7d374c6198a9e273caa72cf836200dbaf1732665"}],"tools/xen/xenrc":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"b951a6ee366b649efb7df0110fd2f0231f1cbc4d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Host Interface, i.e. the interface on the nova vm you want to expose the"},{"line_number":23,"context_line":"# services on. Usually eth2 (management network) or eth3 (public network) and"},{"line_number":24,"context_line":"# not eth0 (private network with XenServer host) or eth1 (VM traffic network)"},{"line_number":25,"context_line":"# This is also used as the interface for the Ubuntu install"},{"line_number":26,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-eth3}"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAOn%2F%2Fecs%3D","line":24,"updated":"2013-05-08 15:21:14.000000000","message":"This isn\u0027t true any more with the new UBUNTU_INST_IFACE","commit_id":"6417064ea9da588f3288f3ac177e559dd04cee9e"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"b93f888a6b9ab03fdb98e008a85d35284bdf3df5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Host Interface, i.e. the interface on the nova vm you want to expose the"},{"line_number":23,"context_line":"# services on. Usually eth2 (management network) or eth3 (public network) and"},{"line_number":24,"context_line":"# not eth0 (private network with XenServer host) or eth1 (VM traffic network)"},{"line_number":25,"context_line":"# This is also used as the interface for the Ubuntu install"},{"line_number":26,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-eth3}"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAOn%2F%2FeRE%3D","line":24,"in_reply_to":"AAAAOn%2F%2Fecs%3D","updated":"2013-05-08 16:42:07.000000000","message":"Sure, that needs to be updated.","commit_id":"6417064ea9da588f3288f3ac177e559dd04cee9e"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"b951a6ee366b649efb7df0110fd2f0231f1cbc4d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"UBUNTU_INST_LOCALE\u003d\"en_US\""},{"line_number":70,"context_line":"UBUNTU_INST_KEYBOARD\u003d\"us\""},{"line_number":71,"context_line":"# network configuration for ubuntu netinstall"},{"line_number":72,"context_line":"UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":73,"context_line":"UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":74,"context_line":"UBUNTU_INST_NAMESERVERS\u003d\"\""},{"line_number":75,"context_line":"UBUNTU_INST_NETMASK\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAOn%2F%2Fecc%3D","line":72,"updated":"2013-05-08 15:21:14.000000000","message":"Worried about backward compatibility with existing localrc - this should probably default to HOST_IP_IFACE?","commit_id":"6417064ea9da588f3288f3ac177e559dd04cee9e"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"b93f888a6b9ab03fdb98e008a85d35284bdf3df5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"UBUNTU_INST_LOCALE\u003d\"en_US\""},{"line_number":70,"context_line":"UBUNTU_INST_KEYBOARD\u003d\"us\""},{"line_number":71,"context_line":"# network configuration for ubuntu netinstall"},{"line_number":72,"context_line":"UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":73,"context_line":"UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":74,"context_line":"UBUNTU_INST_NAMESERVERS\u003d\"\""},{"line_number":75,"context_line":"UBUNTU_INST_NETMASK\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAOn%2F%2FeRA%3D","line":72,"in_reply_to":"AAAAOn%2F%2Fecc%3D","updated":"2013-05-08 16:42:07.000000000","message":"I am not sure how backwards compatibility plays in devstack. If we care about that, we\u0027ll never get to the point. I think using HOST_IP_IFACE for two different thing is at least a bug.","commit_id":"6417064ea9da588f3288f3ac177e559dd04cee9e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a698331d6f41bbc5284ea72a8677897bc8a35bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# A host-only ip that let\u0027s the interface come up, otherwise unused"},{"line_number":32,"context_line":"VM_IP\u003d${VM_IP:-10.255.255.255}"},{"line_number":33,"context_line":"MGT_IP\u003d${MGT_IP:-172.16.100.55}"},{"line_number":34,"context_line":"PUB_IP\u003d${PUB_IP:-192.168.1.55}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Public network"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2Fcv0%3D","line":33,"updated":"2013-05-09 08:35:04.000000000","message":"Better default is probably DHCP, think PC connected to home router, as the default.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"195bb09ba733046bf870d6c27660bb425d5a84ae","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# A host-only ip that let\u0027s the interface come up, otherwise unused"},{"line_number":32,"context_line":"VM_IP\u003d${VM_IP:-10.255.255.255}"},{"line_number":33,"context_line":"MGT_IP\u003d${MGT_IP:-172.16.100.55}"},{"line_number":34,"context_line":"PUB_IP\u003d${PUB_IP:-192.168.1.55}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Public network"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2FctU%3D","line":33,"in_reply_to":"AAAAOn%2F%2Fcv0%3D","updated":"2013-05-09 09:20:06.000000000","message":"Networking will be touched in another change.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a698331d6f41bbc5284ea72a8677897bc8a35bc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# A host-only ip that let\u0027s the interface come up, otherwise unused"},{"line_number":32,"context_line":"VM_IP\u003d${VM_IP:-10.255.255.255}"},{"line_number":33,"context_line":"MGT_IP\u003d${MGT_IP:-172.16.100.55}"},{"line_number":34,"context_line":"PUB_IP\u003d${PUB_IP:-192.168.1.55}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Public network"},{"line_number":37,"context_line":"PUB_NETMASK\u003d${PUB_NETMASK:-255.255.255.0}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2Fcvs%3D","line":34,"updated":"2013-05-09 08:35:04.000000000","message":"This could default to something in the default floating IP subnet","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a698331d6f41bbc5284ea72a8677897bc8a35bc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# Public network"},{"line_number":37,"context_line":"PUB_NETMASK\u003d${PUB_NETMASK:-255.255.255.0}"},{"line_number":38,"context_line":"PUB_BR\u003d${PUB_BR:-\"xenbr0\"}"},{"line_number":39,"context_line":"PUB_VLAN\u003d${PUB_VLAN:--1}"},{"line_number":40,"context_line":"PUB_DEV\u003d${PUB_DEV:-eth0}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# VM network params"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2Fcvo%3D","line":39,"updated":"2013-05-09 08:35:04.000000000","message":"I would put this on the VLAN 101, for floating ip traffic.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"195bb09ba733046bf870d6c27660bb425d5a84ae","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# Public network"},{"line_number":37,"context_line":"PUB_NETMASK\u003d${PUB_NETMASK:-255.255.255.0}"},{"line_number":38,"context_line":"PUB_BR\u003d${PUB_BR:-\"xenbr0\"}"},{"line_number":39,"context_line":"PUB_VLAN\u003d${PUB_VLAN:--1}"},{"line_number":40,"context_line":"PUB_DEV\u003d${PUB_DEV:-eth0}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# VM network params"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2FctM%3D","line":39,"in_reply_to":"AAAAOn%2F%2Fcvo%3D","updated":"2013-05-09 09:20:06.000000000","message":"Touch networking in the next change.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a698331d6f41bbc5284ea72a8677897bc8a35bc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# MGMT network params"},{"line_number":49,"context_line":"MGT_NETMASK\u003d${MGT_NETMASK:-255.255.255.0}"},{"line_number":50,"context_line":"MGT_BR\u003d${MGT_BR:-\"\"}"},{"line_number":51,"context_line":"MGT_VLAN\u003d${MGT_VLAN:-101}"},{"line_number":52,"context_line":"MGT_DEV\u003d${MGT_DEV:-eth0}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Decide if you should enable eth0,"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2FcvU%3D","line":51,"updated":"2013-05-09 08:35:04.000000000","message":"This would be better not on a vlan, but on the xenbr0 network","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"195bb09ba733046bf870d6c27660bb425d5a84ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# MGMT network params"},{"line_number":49,"context_line":"MGT_NETMASK\u003d${MGT_NETMASK:-255.255.255.0}"},{"line_number":50,"context_line":"MGT_BR\u003d${MGT_BR:-\"\"}"},{"line_number":51,"context_line":"MGT_VLAN\u003d${MGT_VLAN:-101}"},{"line_number":52,"context_line":"MGT_DEV\u003d${MGT_DEV:-eth0}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Decide if you should enable eth0,"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2FctI%3D","line":51,"in_reply_to":"AAAAOn%2F%2FcvU%3D","updated":"2013-05-09 09:20:06.000000000","message":"as above.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e76383e8d374b03b76871977cc9f7fa4ebd0a800","unresolved":false,"context_lines":[{"line_number":68,"context_line":"UBUNTU_INST_LOCALE\u003d\"en_US\""},{"line_number":69,"context_line":"UBUNTU_INST_KEYBOARD\u003d\"us\""},{"line_number":70,"context_line":"# network configuration for ubuntu netinstall"},{"line_number":71,"context_line":"UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":72,"context_line":"UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":73,"context_line":"UBUNTU_INST_NAMESERVERS\u003d\"\""},{"line_number":74,"context_line":"UBUNTU_INST_NETMASK\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2Fcwc%3D","line":71,"updated":"2013-05-09 08:24:20.000000000","message":"Should this not default to the same as the HOST_IP_IFACE? I would change them both to eth2, it makes more sense.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"195bb09ba733046bf870d6c27660bb425d5a84ae","unresolved":false,"context_lines":[{"line_number":68,"context_line":"UBUNTU_INST_LOCALE\u003d\"en_US\""},{"line_number":69,"context_line":"UBUNTU_INST_KEYBOARD\u003d\"us\""},{"line_number":70,"context_line":"# network configuration for ubuntu netinstall"},{"line_number":71,"context_line":"UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":72,"context_line":"UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":73,"context_line":"UBUNTU_INST_NAMESERVERS\u003d\"\""},{"line_number":74,"context_line":"UBUNTU_INST_NETMASK\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2Fcsc%3D","line":71,"in_reply_to":"AAAAOn%2F%2Fcv4%3D","updated":"2013-05-09 09:20:06.000000000","message":"I will change it back to eth3, so that it is \"compatible\" with the existing networking, and address these networking issues in the next change.","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0a698331d6f41bbc5284ea72a8677897bc8a35bc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"UBUNTU_INST_LOCALE\u003d\"en_US\""},{"line_number":69,"context_line":"UBUNTU_INST_KEYBOARD\u003d\"us\""},{"line_number":70,"context_line":"# network configuration for ubuntu netinstall"},{"line_number":71,"context_line":"UBUNTU_INST_IFACE\u003d\"eth2\""},{"line_number":72,"context_line":"UBUNTU_INST_IP\u003d\"dhcp\""},{"line_number":73,"context_line":"UBUNTU_INST_NAMESERVERS\u003d\"\""},{"line_number":74,"context_line":"UBUNTU_INST_NETMASK\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"AAAAOn%2F%2Fcv4%3D","line":71,"in_reply_to":"AAAAOn%2F%2Fcwc%3D","updated":"2013-05-09 08:35:04.000000000","message":"I take that back, the default puts eth2 on a private VLAN, I would default this to eth3.\n\nOR change the default networking, as suggested above, and default HOST_IP_FACE to eth2, and leave UBUNTU_INST_IFACE as eth2","commit_id":"a2c4c893adb569d7e1d145624e6031013ad465cf"}]}