)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2aa6d3230d1811e10d59bcd1bc5f8c0931624e4b","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This only checks that $VOLUME is set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Added a check that verifies euca-create-volume exited succesfully."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib095992384edf895aaf78cb4115702d6a0675a3f"},{"line_number":17,"context_line":"Closes-Bug: #1206180"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7af24918_d8db4eec","line":14,"updated":"2016-03-01 21:29:00.000000000","message":"this doesn\u0027t really reflect what\u0027s happening any more","commit_id":"01f1bae1c7b82958b280e3c2335b0444ff95294f"}],"exercises/euca.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"839571c944ba2dc310fcc87c57384582c1afc6d2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    VOLUME_ZONE\u003d`euca-describe-availability-zones | head -n1 | cut -f2`"},{"line_number":90,"context_line":"    die_if_not_set $LINENO VOLUME_ZONE \"Failure to find zone for volume\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    VOLUME\u003d`euca-create-volume -s 1 -z $VOLUME_ZONE | cut -f2`"},{"line_number":93,"context_line":"    die_if_not_set $LINENO VOLUME \"Failure to create volume\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    # Test that volume is a volume identifier"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9aed3d3a_f3a09da1","line":92,"updated":"2016-02-28 22:41:35.000000000","message":"This does not really seem to address the bug that you\u0027ve linked to, which is that if this euca-create-volume command fails then VOLUME becomes error output, not a volume\n\nsomething like setting pipefail on this file, or checking the pipe exit status seems like the way to go","commit_id":"755c4b32866f46d251019e0ea9f4f3ebbefd7f4c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2aa6d3230d1811e10d59bcd1bc5f8c0931624e4b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    VOLUME\u003d`euca-create-volume -s 1 -z $VOLUME_ZONE | cut -f2`"},{"line_number":94,"context_line":"    die_if_not_set $LINENO VOLUME \"Failure to create volume\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # Test that euca-create-volume exited succesfully"},{"line_number":97,"context_line":"    if [ ! $? -eq 0 ]; then"},{"line_number":98,"context_line":"        die $LINENO \"Failure to create volume\""},{"line_number":99,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7af24918_f8744afe","line":96,"updated":"2016-03-01 21:29:00.000000000","message":"with pipefail set, you won\u0027t ever hit this, because it will have bailed out in the previous command","commit_id":"01f1bae1c7b82958b280e3c2335b0444ff95294f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fc5eecbc9a2597dda2542dedf59a2349b71effc5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# This script exits on an error so that errors don\u0027t compound and you see"},{"line_number":13,"context_line":"# only the first error that occurred."},{"line_number":14,"context_line":"set -o errexit"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Print the commands being run so that we can see the command that triggers"},{"line_number":17,"context_line":"# an error.  It is also useful for following allowing as the install occurs."}],"source_content_type":"text/x-sh","patch_set":5,"id":"7af24918_8ea3e0ff","line":14,"updated":"2016-03-03 01:17:34.000000000","message":"since it sets errexit here, the pipefail will make the command fail before you check $?","commit_id":"8c373aafe7f675da5367aaecf64ad0dbb342a9ca"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cd78b90d0e38caa71b1d9b89e3f26899b66c2bc4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# This script exits on an error so that errors don\u0027t compound and you see"},{"line_number":13,"context_line":"# only the first error that occurred."},{"line_number":14,"context_line":"set -o errexit"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Print the commands being run so that we can see the command that triggers"},{"line_number":17,"context_line":"# an error.  It is also useful for following allowing as the install occurs."}],"source_content_type":"text/x-sh","patch_set":5,"id":"7af24918_153fca87","line":14,"in_reply_to":"7af24918_8ea3e0ff","updated":"2016-03-03 10:20:13.000000000","message":"+1 I don\"t see how this is going to work.","commit_id":"8c373aafe7f675da5367aaecf64ad0dbb342a9ca"}]}