)]}'
{"functions-common":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"13c75cac31dd21be598a61a2069cdb0c0ebc039c","unresolved":false,"context_lines":[{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    if [[ ! -d \"$SERVICE_DIR\" ]]; then"},{"line_number":1407,"context_line":"        sudo mkdir -p \"$SERVICE_DIR\""},{"line_number":1408,"context_line":"        safe_chown -R \"$STACK_USER\" \"$SERVICE_DIR\""},{"line_number":1409,"context_line":"    fi"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"    if [[ ! -d \"$SERVICE_DIR/$SCREEN_NAME\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9aed3d3a_60e499ab","line":1408,"updated":"2016-02-29 13:35:03.000000000","message":"You should do it in one line.\n\nsudo install -d -o \"$STACK_USER\" \"$SERVICE_DIR\"\n\n(git grep \"sudo install \" tends to show that this pattern is widely used).","commit_id":"0346ae99fa7703727f59b780df9c51939ec23832"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5c9182a43558120c4fa55b29e065c9c1a7403b5f","unresolved":false,"context_lines":[{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    if [[ ! -d \"$SERVICE_DIR\" ]]; then"},{"line_number":1407,"context_line":"        sudo mkdir -p \"$SERVICE_DIR\""},{"line_number":1408,"context_line":"        safe_chown -R \"$STACK_USER\" \"$SERVICE_DIR\""},{"line_number":1409,"context_line":"    fi"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"    if [[ ! -d \"$SERVICE_DIR/$SCREEN_NAME\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a122d0e_9e2c0b4c","line":1408,"in_reply_to":"9aed3d3a_60e499ab","updated":"2016-04-18 01:46:59.000000000","message":"the trickery with safe_chown is only required for top-level directories.  it came about because people (3rd party CI i think) were running on NFS mounted /opt/stack where they couldn\u0027t change permissions.  but under $DEST it should be fine to just use \"install\"","commit_id":"0346ae99fa7703727f59b780df9c51939ec23832"}],"stack.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5c9182a43558120c4fa55b29e065c9c1a7403b5f","unresolved":false,"context_lines":[{"line_number":468,"context_line":"SUBUNIT_DIR\u003d\"$(dirname \"$SUBUNIT_OUTPUT\")\""},{"line_number":469,"context_line":"if [[ ! -d \"$SUBUNIT_DIR\" ]]; then"},{"line_number":470,"context_line":"    sudo mkdir -p \"$SUBUNIT_DIR\""},{"line_number":471,"context_line":"    safe_chown -R \"$STACK_USER\" \"$SUBUNIT_DIR\""},{"line_number":472,"context_line":"fi"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_fe6fff8f","line":471,"updated":"2016-04-18 01:46:59.000000000","message":"this is under $DEST so shouldn\u0027t need this trickery","commit_id":"0346ae99fa7703727f59b780df9c51939ec23832"}]}