)]}'
{"lib/ceilometer":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8610f9050de87dd62046de24271db4c2d10601c5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Ceilometer** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable, add the following to localrc"},{"line_number":5,"context_line":"# ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral,ceilometer-collector,ceilometer-api"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOn%2F%2FXCk%3D","line":5,"updated":"2013-05-13 17:11:57.000000000","message":"How about switching this to the enable_services function instead of modifying the string directly?","commit_id":"dedd88c2b8bcbd873505afc3f9457fb30fd096cb"},{"author":{"_account_id":882,"name":"shengjie min","email":"minshengjie@chinacloud.com.cn","username":"shengjie-min"},"change_message_id":"8300cf22cbb68f5554452d9b59f9f42971cc88bd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Ceilometer** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable, add the following to localrc"},{"line_number":5,"context_line":"# ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral,ceilometer-collector,ceilometer-api"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOn%2F%2FVL8%3D","line":5,"in_reply_to":"AAAAOn%2F%2FVMo%3D","updated":"2013-05-14 13:19:07.000000000","message":"What I normally do is to add ENABLE_SERVICES in my localrc. But yeah, u r right, using enable_service might make more sense, let me update this. In general, I think Ceilometer should have a \"get started\" page like http://docs.openstack.org/developer/heat/getting_started/on_devstack.html. How about a bp for adding a \"Ceilometer get started\" doc? :)","commit_id":"dedd88c2b8bcbd873505afc3f9457fb30fd096cb"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e7a1c1b8f6d113c8267433bae292fc6669e59abf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Ceilometer** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable, add the following to localrc"},{"line_number":5,"context_line":"# ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral,ceilometer-collector,ceilometer-api"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOn%2F%2FVMo%3D","line":5,"in_reply_to":"AAAAOn%2F%2FVYA%3D","updated":"2013-05-14 13:11:50.000000000","message":"What I mean is that rather than suggesting people modify ENABLED_SERVICES directly we should suggest that they call enable_services and pass the names of the ceilometer services to it.","commit_id":"dedd88c2b8bcbd873505afc3f9457fb30fd096cb"},{"author":{"_account_id":882,"name":"shengjie min","email":"minshengjie@chinacloud.com.cn","username":"shengjie-min"},"change_message_id":"c62d12bff2649644bba78e61b6cac0ae00a49ccc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Install and start **Ceilometer** service"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To enable, add the following to localrc"},{"line_number":5,"context_line":"# ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral,ceilometer-collector,ceilometer-api"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Dependencies:"},{"line_number":8,"context_line":"# - functions"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOn%2F%2FVYA%3D","line":5,"in_reply_to":"AAAAOn%2F%2FXCk%3D","updated":"2013-05-14 10:54:18.000000000","message":"Doug, sorry, I am not quite getting what you meant here. if you look at lib/heat, they had # ENABLED_SERVICES+\u003d,heat,h-api-cfn,h-api-cw,h-eng. while in lib/ceilometer, it doesn\u0027t have comma at the beginning. In enable_service(), ${ENABLED_SERVICES} is passed in already as a broken string if there is no first comma  :) At the end of the day, it\u0027s just a comment, people probably can easily fix their localrc when they see the error message pops up when ./stack.sh fail","commit_id":"dedd88c2b8bcbd873505afc3f9457fb30fd096cb"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"179c6da96658c8f8d8c52e6e094008752bf02d9d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#   ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral,ceilometer-collector,ceilometer-api"},{"line_number":7,"context_line":"# OR"},{"line_number":8,"context_line":"# - call enable_service()"},{"line_number":9,"context_line":"#   source $TOP_DIR/functions"},{"line_number":10,"context_line":"#   enable_service ceilometer-acompute ceilometer-acentral ceilometer-collector ceilometer-api"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2FVFI%3D","line":9,"updated":"2013-05-14 14:25:58.000000000","message":"By the time localrc is run this file has already been sourced. It shouldn\u0027t be sourced again.","commit_id":"bb21e4d523c083152201041c1ce06082fff865db"},{"author":{"_account_id":882,"name":"shengjie min","email":"minshengjie@chinacloud.com.cn","username":"shengjie-min"},"change_message_id":"758570e22d748c662182325090af2667aa3a1bf0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#   ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral,ceilometer-collector,ceilometer-api"},{"line_number":7,"context_line":"# OR"},{"line_number":8,"context_line":"# - call enable_service()"},{"line_number":9,"context_line":"#   source $TOP_DIR/functions"},{"line_number":10,"context_line":"#   enable_service ceilometer-acompute ceilometer-acentral ceilometer-collector ceilometer-api"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2FVDE%3D","line":9,"in_reply_to":"AAAAOn%2F%2FVFI%3D","updated":"2013-05-14 14:45:49.000000000","message":"first time seeing it, it\u0027s hard to find things nowadays. I aligned it with the configuration doc.","commit_id":"bb21e4d523c083152201041c1ce06082fff865db"}]}