)]}'
{"clean.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be1ce8d13a331a962eb3192b1b26cc82a7db8969","unresolved":false,"context_lines":[{"line_number":130,"context_line":"fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Clean up other non-DevStack files/directories that require root privileges"},{"line_number":133,"context_line":"ROOT_TO_CLEAN\u003d\"/etc/apache2/sites-enabled/horizon.conf \""},{"line_number":134,"context_line":"# Clean up the cache dirs for projects that use it"},{"line_number":135,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/ceilometer \""},{"line_number":136,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/cinder \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_427434fc","line":133,"updated":"2016-03-08 19:26:45.000000000","message":"why would cleanup_horizon not do this?","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9e0d9ad3ec9bb24332b72c5c2c8cb14c004fee80","unresolved":false,"context_lines":[{"line_number":130,"context_line":"fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Clean up other non-DevStack files/directories that require root privileges"},{"line_number":133,"context_line":"ROOT_TO_CLEAN\u003d\"/etc/apache2/sites-enabled/horizon.conf \""},{"line_number":134,"context_line":"# Clean up the cache dirs for projects that use it"},{"line_number":135,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/ceilometer \""},{"line_number":136,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/cinder \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_1660a900","line":133,"in_reply_to":"5aef4532_427434fc","updated":"2016-03-08 23:06:12.000000000","message":"My question also. Seems like cleanup_horizon or rather lib/apache is missing the sites-enabled side of it. Since this depends on the distro, cleanup_horizon just be the thing that somehow triggers the deletion of sites-enabled/horizon.conf, so I will remove this line. There should be a follow-up patch to take care of sites-enabled.","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be1ce8d13a331a962eb3192b1b26cc82a7db8969","unresolved":false,"context_lines":[{"line_number":143,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/cinder \""},{"line_number":144,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/glance \""},{"line_number":145,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/heat \""},{"line_number":146,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/heat-cfntools \""},{"line_number":147,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/nova \""},{"line_number":148,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/neutron \""},{"line_number":149,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/swift \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_a2641822","line":146,"updated":"2016-03-08 19:26:45.000000000","message":"these are all duplicates?","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9e0d9ad3ec9bb24332b72c5c2c8cb14c004fee80","unresolved":false,"context_lines":[{"line_number":143,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/cinder \""},{"line_number":144,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/glance \""},{"line_number":145,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/heat \""},{"line_number":146,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/heat-cfntools \""},{"line_number":147,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/nova \""},{"line_number":148,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/neutron \""},{"line_number":149,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/swift \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_761c8d77","line":146,"in_reply_to":"5aef4532_a2641822","updated":"2016-03-08 23:06:12.000000000","message":"Oh, will fix this, thanks for spotting.","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be1ce8d13a331a962eb3192b1b26cc82a7db8969","unresolved":false,"context_lines":[{"line_number":150,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/keystone \""},{"line_number":151,"context_line":"# Clean up sudoers files"},{"line_number":152,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":153,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""},{"line_number":154,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/neutron-rootwrap \""},{"line_number":155,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/nova-rootwrap \""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_025b4c55","line":153,"updated":"2016-03-08 19:26:45.000000000","message":"we have a common function to install rootwraps IIRC.  we should probably have a common function to remove them, called from cleanup_* scripts","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9e0d9ad3ec9bb24332b72c5c2c8cb14c004fee80","unresolved":false,"context_lines":[{"line_number":150,"context_line":"ROOT_TO_CLEAN+\u003d\"/var/cache/keystone \""},{"line_number":151,"context_line":"# Clean up sudoers files"},{"line_number":152,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":153,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""},{"line_number":154,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/neutron-rootwrap \""},{"line_number":155,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/nova-rootwrap \""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_5608712c","line":153,"in_reply_to":"5aef4532_025b4c55","updated":"2016-03-08 23:06:12.000000000","message":"That\u0027s good, will investigate.","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"be1ce8d13a331a962eb3192b1b26cc82a7db8969","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# Clean up other non-DevStack files/directories"},{"line_number":160,"context_line":"GENERAL_TO_CLEAN\u003d\"$WHEELHOUSE ${PROJECT_VENV[@]} \""},{"line_number":161,"context_line":"GENERAL_TO_CLEAN+\u003d\"/etc/apache2/sites-enabled/horizon.conf \""},{"line_number":162,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.config/openstack \""},{"line_number":163,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.novaclient \""},{"line_number":164,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.cinderclient \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_c23fa4d4","line":161,"updated":"2016-03-08 19:26:45.000000000","message":"duplicated again?","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"9e0d9ad3ec9bb24332b72c5c2c8cb14c004fee80","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# Clean up other non-DevStack files/directories"},{"line_number":160,"context_line":"GENERAL_TO_CLEAN\u003d\"$WHEELHOUSE ${PROJECT_VENV[@]} \""},{"line_number":161,"context_line":"GENERAL_TO_CLEAN+\u003d\"/etc/apache2/sites-enabled/horizon.conf \""},{"line_number":162,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.config/openstack \""},{"line_number":163,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.novaclient \""},{"line_number":164,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.cinderclient \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5aef4532_7103f70d","line":161,"in_reply_to":"5aef4532_c23fa4d4","updated":"2016-03-08 23:06:12.000000000","message":"Old way of deleting, thanks for spotting.","commit_id":"d18c2c3a5c1a8c054a014b16403f116379e42d4c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f3f46566d937b7ce2b2f306a71018f8bd7a2331a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"ROOT_TO_CLEAN+\u003d\"$HEAT_AUTH_CACHE_DIR \""},{"line_number":137,"context_line":"ROOT_TO_CLEAN+\u003d\"$NEUTRON_AUTH_CACHE_DIR \""},{"line_number":138,"context_line":"ROOT_TO_CLEAN+\u003d\"$NOVA_AUTH_CACHE_DIR \""},{"line_number":139,"context_line":"ROOT_TO_CLEAN+\u003d\"$SWIFT_AUTH_CACHE_DIR \""},{"line_number":140,"context_line":"# Clean up sudoers files"},{"line_number":141,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":142,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_d1d5221c","line":139,"updated":"2016-03-10 22:16:01.000000000","message":"Glance, Heat and Nova already clean these up in their cleanup_* functions.  I\u0027d rather do this bit there for project-specific files like this.","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ebfbe64f68dc6c92699a65312e59baaf6c9646cc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"ROOT_TO_CLEAN+\u003d\"$HEAT_AUTH_CACHE_DIR \""},{"line_number":137,"context_line":"ROOT_TO_CLEAN+\u003d\"$NEUTRON_AUTH_CACHE_DIR \""},{"line_number":138,"context_line":"ROOT_TO_CLEAN+\u003d\"$NOVA_AUTH_CACHE_DIR \""},{"line_number":139,"context_line":"ROOT_TO_CLEAN+\u003d\"$SWIFT_AUTH_CACHE_DIR \""},{"line_number":140,"context_line":"# Clean up sudoers files"},{"line_number":141,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":142,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_26407707","line":139,"in_reply_to":"5aef4532_d1d5221c","updated":"2016-03-11 10:30:35.000000000","message":"Alright, will do.","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e060c7adeb3a5ea2bad1ff212ae2e892b961d031","unresolved":false,"context_lines":[{"line_number":140,"context_line":"# Clean up sudoers files"},{"line_number":141,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":142,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""},{"line_number":143,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/neutron-rootwrap \""},{"line_number":144,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/nova-rootwrap \""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"sudo rm -rf $ROOT_TO_CLEAN"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_3e6baef2","line":143,"updated":"2016-03-10 00:42:41.000000000","message":"so these are installed by inc/rootwrap:configure_rootwrap IIRC, and i know that\u0027s used by plugins.  i bet they don\u0027t clean any of it up either","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ebfbe64f68dc6c92699a65312e59baaf6c9646cc","unresolved":false,"context_lines":[{"line_number":140,"context_line":"# Clean up sudoers files"},{"line_number":141,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":142,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""},{"line_number":143,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/neutron-rootwrap \""},{"line_number":144,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/nova-rootwrap \""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"sudo rm -rf $ROOT_TO_CLEAN"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_bcd65825","line":143,"in_reply_to":"5aef4532_3e6baef2","updated":"2016-03-11 10:30:35.000000000","message":"Only Nova and Cinder seem to be have rootwrap configured through inc/rootwrap:configure_rootwrap.\n\nYou\u0027re right about the plugins, for the ones I\u0027ve checked. Probably the only way would be to set a formal requirement in the DevStack Plugin Interface documentation, to clean rootwrap and other leftovers during move\u003dclean, and hope for compliance.\n\nI\u0027m thinking for now we could add a cleanup method to inc/rootwrap:configure_rootwrap, and make the projects that use it (Cinder, Nova) call into the new method. As a first step in this direction.","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"fd9cd8b1bca3efea129a2f704bfc01c51b8fb14d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"# Clean up sudoers files"},{"line_number":141,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":142,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/cinder-rootwrap \""},{"line_number":143,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/neutron-rootwrap \""},{"line_number":144,"context_line":"ROOT_TO_CLEAN+\u003d\"/etc/sudoers.d/nova-rootwrap \""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"sudo rm -rf $ROOT_TO_CLEAN"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3afc51ec_a22a532a","line":143,"in_reply_to":"5aef4532_bcd65825","updated":"2016-03-14 17:19:02.000000000","message":"s/add a cleanup method to inc/rootwrap:configure_rootwrap/add a cleanup method to inc/rootwrap","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e060c7adeb3a5ea2bad1ff212ae2e892b961d031","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Clean up other non-DevStack files/directories"},{"line_number":149,"context_line":"GENERAL_TO_CLEAN\u003d\"$WHEELHOUSE ${PROJECT_VENV[@]} \""},{"line_number":150,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.config/openstack \""},{"line_number":151,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.novaclient \""},{"line_number":152,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.cinderclient \""},{"line_number":153,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.my.cnf \""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_7e0ed63b","line":150,"updated":"2016-03-10 00:42:41.000000000","message":"i feel like it might be slightly safer to to ~$STACK_USER","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ebfbe64f68dc6c92699a65312e59baaf6c9646cc","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Clean up other non-DevStack files/directories"},{"line_number":149,"context_line":"GENERAL_TO_CLEAN\u003d\"$WHEELHOUSE ${PROJECT_VENV[@]} \""},{"line_number":150,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.config/openstack \""},{"line_number":151,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.novaclient \""},{"line_number":152,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.cinderclient \""},{"line_number":153,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.my.cnf \""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_3ce36807","line":150,"in_reply_to":"5aef4532_671f505b","updated":"2016-03-11 10:30:35.000000000","message":"Of course! Will do.","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7146a21a4937420b93c98ace94b24253bc19961c","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Clean up other non-DevStack files/directories"},{"line_number":149,"context_line":"GENERAL_TO_CLEAN\u003d\"$WHEELHOUSE ${PROJECT_VENV[@]} \""},{"line_number":150,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.config/openstack \""},{"line_number":151,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.novaclient \""},{"line_number":152,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.cinderclient \""},{"line_number":153,"context_line":"GENERAL_TO_CLEAN+\u003d\"$HOME/.my.cnf \""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_671f505b","line":150,"in_reply_to":"5aef4532_7e0ed63b","updated":"2016-03-10 12:12:12.000000000","message":"+1","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e060c7adeb3a5ea2bad1ff212ae2e892b961d031","unresolved":false,"context_lines":[{"line_number":161,"context_line":"DEVSTACK_TO_CLEAN+\u003d\".stackenv .prereqs \""},{"line_number":162,"context_line":"DEVSTACK_TO_CLEAN+\u003d\"accrc/ \""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"for file in $DEVSTACK_TO_CLEAN; do"},{"line_number":165,"context_line":"    rm -rf $TOP_DIR/$file"},{"line_number":166,"context_line":"done"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_6112b758","line":164,"updated":"2016-03-10 00:42:41.000000000","message":"why bother with the loop here?","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ce8f2663230d8e47cc27ed6fb62aa3707fa515f9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"DEVSTACK_TO_CLEAN+\u003d\".stackenv .prereqs \""},{"line_number":162,"context_line":"DEVSTACK_TO_CLEAN+\u003d\"accrc/ \""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"for file in $DEVSTACK_TO_CLEAN; do"},{"line_number":165,"context_line":"    rm -rf $TOP_DIR/$file"},{"line_number":166,"context_line":"done"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_71f6ce5d","line":164,"in_reply_to":"5aef4532_117b0a7c","updated":"2016-03-10 22:27:52.000000000","message":"ahh; that doesn\u0027t seem like good defensive programming; we\u0027re going to add something to DEVSTACK_TO_CLEAN one day not thinking that it gets a prefix in the rm.  A comment a least would help.\n\n\u003c/splitting hairs\u003e","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f3f46566d937b7ce2b2f306a71018f8bd7a2331a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"DEVSTACK_TO_CLEAN+\u003d\".stackenv .prereqs \""},{"line_number":162,"context_line":"DEVSTACK_TO_CLEAN+\u003d\"accrc/ \""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"for file in $DEVSTACK_TO_CLEAN; do"},{"line_number":165,"context_line":"    rm -rf $TOP_DIR/$file"},{"line_number":166,"context_line":"done"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_117b0a7c","line":164,"in_reply_to":"5aef4532_6112b758","updated":"2016-03-10 22:16:01.000000000","message":"$TOP_DIR/ below...otherwise it needs to be prepended everywhere...","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ebfbe64f68dc6c92699a65312e59baaf6c9646cc","unresolved":false,"context_lines":[{"line_number":161,"context_line":"DEVSTACK_TO_CLEAN+\u003d\".stackenv .prereqs \""},{"line_number":162,"context_line":"DEVSTACK_TO_CLEAN+\u003d\"accrc/ \""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"for file in $DEVSTACK_TO_CLEAN; do"},{"line_number":165,"context_line":"    rm -rf $TOP_DIR/$file"},{"line_number":166,"context_line":"done"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5aef4532_bcb938ce","line":164,"in_reply_to":"5aef4532_71f6ce5d","updated":"2016-03-11 10:30:35.000000000","message":"I simply tried to keep it the way it is today (FILES_TO_CLEAN) to prevent any collateral damage, but will look better into this since the only reason seems to be the $TOP_DIR.","commit_id":"d2940f34bc6359578b8c917e038ce9d055e80765"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"80f1fd5aabf5b86b122d2274cd3eed7955449a03","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Clean up other non-DevStack files/directories that require root privileges"},{"line_number":136,"context_line":"# Clean up sudoers files"},{"line_number":137,"context_line":"ROOT_TO_CLEAN\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"sudo rm -rf $ROOT_TO_CLEAN"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"1af94dfe_6f6d67cb","line":137,"updated":"2016-03-18 17:56:26.000000000","message":"what can be wrong with that file still being there?","commit_id":"655b09c9dee5b76fe2738bd86d916f1247a8cbcc"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ded8f9820f729fef3f495f6ab45b641fef2c3832","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# Clean up other non-DevStack files/directories that require root privileges"},{"line_number":136,"context_line":"# Clean up sudoers files"},{"line_number":137,"context_line":"ROOT_TO_CLEAN\u003d\"/etc/sudoers.d/50_stack_sh \""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"sudo rm -rf $ROOT_TO_CLEAN"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"fa0719c6_9c90b7ee","line":137,"in_reply_to":"1af94dfe_6f6d67cb","updated":"2016-03-21 10:10:30.000000000","message":"My expectaction (of the user\u0027s expectaction) is that when the user runs ./clean.sh, they want the system to be as clean as possible (the way it looked before DevStack entered the picture).\n\nThey might be using their own user to deploy DevStack, and they\u0027ve just noticed that sudo no longer asks them for a password. So they run clean.sh in an attempt to get the sudoers back to the original state and request passwords again, but no luck.\n\nAlso see https://bugs.launchpad.net/devstack/+bug/1307564","commit_id":"655b09c9dee5b76fe2738bd86d916f1247a8cbcc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"80f1fd5aabf5b86b122d2274cd3eed7955449a03","unresolved":false,"context_lines":[{"line_number":143,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.config/openstack \""},{"line_number":144,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.novaclient \""},{"line_number":145,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.cinderclient \""},{"line_number":146,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.my.cnf \""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"rm -rf $GENERAL_TO_CLEAN"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"1af94dfe_6fa44707","line":146,"updated":"2016-03-18 17:56:26.000000000","message":"I\u0027m a little concerned about going rampantly through user environments here. What\u0027s the issues you are trying to avoid?","commit_id":"655b09c9dee5b76fe2738bd86d916f1247a8cbcc"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"ded8f9820f729fef3f495f6ab45b641fef2c3832","unresolved":false,"context_lines":[{"line_number":143,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.config/openstack \""},{"line_number":144,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.novaclient \""},{"line_number":145,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.cinderclient \""},{"line_number":146,"context_line":"GENERAL_TO_CLEAN+\u003d\"$STACK_USER_HOME/.my.cnf \""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"rm -rf $GENERAL_TO_CLEAN"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"fa0719c6_3c3b6bed","line":146,"in_reply_to":"1af94dfe_6fa44707","updated":"2016-03-21 10:10:30.000000000","message":"I am trying to clean as much leftovers as possible, at least the ones not managed by any system package at all. I may remove the STACK_USER_HOME variable if it\u0027s overkill, and just locally define it here.","commit_id":"655b09c9dee5b76fe2738bd86d916f1247a8cbcc"}]}