)]}'
{"id":"openstack%2Fdevstack~29089","triplet_id":"openstack%2Fdevstack~master~Ie2e6fb1e770403c4ef3463a850e8151bd312614c","project":"openstack/devstack","branch":"master","topic":"openrc-cleanup","hashtags":[],"change_id":"Ie2e6fb1e770403c4ef3463a850e8151bd312614c","subject":"Cleanup openrc.","status":"MERGED","created":"2013-05-14 15:02:54.000000000","updated":"2013-05-31 14:10:04.000000000","submitted":"2013-05-28 09:07:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fe6873fdd13471812486ee9ed8cbeb03198d9705","_number":29089,"virtual_id_number":29089,"owner":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-05-28 09:07:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"date":"2013-05-15 10:48:24.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-28 08:17:24.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2013-05-15 15:57:30.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-05-15 10:54:21.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-05-28 08:17:24.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2013-05-15 15:57:30.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-05-15 10:54:21.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-15 10:54:21.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-05-15 15:57:30.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-05-28 08:17:24.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-05-28 09:07:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ffcf13f96b4bd3bc76f16b2d1b17d05406e31c72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-14 15:53:52.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29089/1/check/gate-tempest-devstack-vm-full/15908 : SUCCESS in 00:50:45\n- http://logs.openstack.org/29089/1/check/gate-tempest-devstack-vm-postgres-full/15624 : FAILURE in 00:47:14 (non-voting)\n- http://logs.openstack.org/29089/1/check/gate-tempest-devstack-vm-quantum/22354 : SUCCESS in 00:21:09\n- http://logs.openstack.org/29089/1/check/gate-grenade-devstack-vm/3553 : FAILURE in 00:10:08 (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"28aac4ef33b7cd48be4fa172f6a5d9642931cc63","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-05-14 16:26:06.000000000","message":"Patch Set 1:\n\nChmouel, I don\u0027t mind the patch specifically, but I want to be sure we set appropriate expectations about support for shells other than bash.  The docs and HACKING.rst are clear that bash v3+ is what is supported so this is likely  to come up again.","accounts_in_message":[],"_revision_number":1},{"id":"a3d5e61beebf967a52a8218172f0fe8d17f043e0","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-05-15 07:47:43.000000000","message":"Patch Set 1:\n\nTotally cool with the expectation I would not try to make it compliant if we had to do some major changes or drop some features but in this case this is just a simple fix so the user can still do source ~/devstack/openrc without having to use another shell :(","accounts_in_message":[],"_revision_number":1},{"id":"4584d6a57c31464ff19fb74ceec8f67e04b51d30","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-15 10:14:48.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI think I\u0027d rather have openrc get generated without using functions. It\u0027s not really clear to me why we still include it.","accounts_in_message":[],"_revision_number":1},{"id":"b50a86d13b6f7519eb620187ab0bfcb2bc95b8cc","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-05-15 10:45:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a6d53de0ce3c9ad4b673451a3cbb4f72f669c7b2","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-05-15 10:47:25.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f3efe77de2cc2a4e940a528ad1c9a38fb5e35e3a","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-05-15 10:48:24.000000000","message":"Patch Set 3:\n\n@sean: this is the kind of thing are to detect with shell :( but you are right this does not seem to be used in there. Removing it is good for me.","accounts_in_message":[],"_revision_number":3},{"id":"0ef2d399c5dbc74afdde4545c8e613a7b5ce701d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-15 10:54:21.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nyeh, but it changes the surface to support. As we\u0027ve seen with distros, if today is zsh, someone will show up wanting ksh tomorrow, and... it grows.\n\nWith openrc just being simple variable assignments it makes it better.","accounts_in_message":[],"_revision_number":3},{"id":"75ebebb94e8fd31869e17bcd6fe8e6a68044e22c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 11:40:41.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29089/3/check/gate-tempest-devstack-vm-full/16056 : SUCCESS in 50m 23s\n- http://logs.openstack.org/29089/3/check/gate-tempest-devstack-vm-postgres-full/15772 : FAILURE in 53m 01s (non-voting)\n- http://logs.openstack.org/29089/3/check/gate-tempest-devstack-vm-quantum/22537 : SUCCESS in 22m 50s\n- http://logs.openstack.org/29089/3/check/gate-grenade-devstack-vm/3689 : FAILURE in 10m 41s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"0b84ea42cd1e3a36bcd25409e64a010b12fc66de","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-05-15 15:57:30.000000000","message":"Patch Set 3:\n\nfunctions is sourced in openrc because stackrc and localrc allow/encourage the use of things like enable_service() and disable_service(); although ATM stackrc doesn\u0027t use any functions. In the openrc case it will work because the lack of those functions doesn\u0027t impact what is being set.  I do see \"XXX: command not found\" errors though.\n\nI don\u0027t mind the original fix, I just don\u0027t want to say \u0027to support zsh\u0027 and have people think that is generally true.\n\nIt should be a separate conversation to break up functions, it\u0027s getting rather large...","accounts_in_message":[],"_revision_number":3},{"id":"c2e4fa703541b725ed57cb0d22cf3d1f6668923f","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-28 08:17:24.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8c89932e1748bf08cba1f0681b5c78244bce6922","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-28 08:17:29.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"b0d504da60cb85469f369f6a0c58ff4997dec218","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-28 09:07:53.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/29089/3/gate/gate-tempest-devstack-vm-full/18728 : SUCCESS in 46m 17s\n- http://logs.openstack.org/29089/3/gate/gate-tempest-devstack-vm-postgres-full/18438 : FAILURE in 49m 53s (non-voting)\n- http://logs.openstack.org/29089/3/gate/gate-tempest-devstack-vm-quantum/25552 : SUCCESS in 18m 52s\n- http://logs.openstack.org/29089/3/gate/gate-grenade-devstack-vm/6165 : SUCCESS in 16m 32s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"29f81a15b85291cf274753eefa76a7045a6b1bb3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-28 09:07:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"03e31bcba6e7e57c3f0c5767ec90ff89fa19c068","author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"date":"2013-05-31 14:03:45.000000000","message":"Patch Set 3:\n\n-1.\nNow I have to source $RC_DIR/functions first to source openrc. We should not remove the sourcing of functions.","accounts_in_message":[],"_revision_number":3},{"id":"6d89ce4c8ec43f583450e5a0ae56e89da3bd8d4c","author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"date":"2013-05-31 14:10:04.000000000","message":"Patch Set 3:\n\nDean\u0027s comment reminds me my localrc has ENABLED_SERVICES in it. localrc: http://paste.openstack.org/show/37968/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"73695d0ea490c4c7a1158957dd5a85586cfa0933","revisions":{"c51a55b006fab5b4138326ea7bd58ab0a3791634":{"kind":"REWORK","_number":1,"created":"2013-05-14 15:02:54.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/89/29089/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/89/29089/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/89/29089/1"}}},"commit":{"parents":[{"commit":"ad573f8543d5c0b98177ffc141423ff937962173","subject":"Merge \"Only search the lib dir for rpc_backend\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ad573f8543d5c0b98177ffc141423ff937962173"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-05-14 15:01:01.000000000","tz":0},"committer":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-05-14 15:02:51.000000000","tz":0},"subject":"Make functions zsh compliant.","message":"Make functions zsh compliant.\n\n- Trying to source openrc with something else than bash (i.e: zsh) would\n  fail, a minor syntax adjustement that makes happy both.\n\nChange-Id: Ie2e6fb1e770403c4ef3463a850e8151bd312614c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c51a55b006fab5b4138326ea7bd58ab0a3791634"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c51a55b006fab5b4138326ea7bd58ab0a3791634"}]},"branch":"refs/heads/master"},"55291fcab20b6f909c5ff93a21530296b2a5fd0a":{"kind":"REWORK","_number":2,"created":"2013-05-15 10:45:39.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/89/29089/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/89/29089/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/89/29089/2"}}},"commit":{"parents":[{"commit":"ad573f8543d5c0b98177ffc141423ff937962173","subject":"Merge \"Only search the lib dir for rpc_backend\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ad573f8543d5c0b98177ffc141423ff937962173"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-05-14 15:01:01.000000000","tz":0},"committer":{"name":"Chmouel Boudjnah","email":"launchpad@chmouel.com","date":"2013-05-15 10:44:33.000000000","tz":120},"subject":"Cleanup openrc.","message":"Cleanup openrc.\n\n- Cleanup openrc, removing the sourcing of functions (which was failing\n  for zsh) and remove the *_DEBUG comment since they have been removed\n  from the clients.\n\nChange-Id: Ie2e6fb1e770403c4ef3463a850e8151bd312614c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/55291fcab20b6f909c5ff93a21530296b2a5fd0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/55291fcab20b6f909c5ff93a21530296b2a5fd0a"}]},"branch":"refs/heads/master"},"73695d0ea490c4c7a1158957dd5a85586cfa0933":{"kind":"REWORK","_number":3,"created":"2013-05-15 10:47:25.000000000","uploader":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"ref":"refs/changes/89/29089/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/89/29089/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/89/29089/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/89/29089/3"}}},"commit":{"parents":[{"commit":"ad573f8543d5c0b98177ffc141423ff937962173","subject":"Merge \"Only search the lib dir for rpc_backend\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ad573f8543d5c0b98177ffc141423ff937962173"}]}],"author":{"name":"Chmouel Boudjnah","email":"chmouel@enovance.com","date":"2013-05-14 15:01:01.000000000","tz":0},"committer":{"name":"Chmouel Boudjnah","email":"launchpad@chmouel.com","date":"2013-05-15 10:47:10.000000000","tz":120},"subject":"Cleanup openrc.","message":"Cleanup openrc.\n\n- Cleanup openrc, removing the sourcing of functions (which was failing\n  for zsh) and remove the *_DEBUG comment since they have been removed\n  from the clients.\n\nChange-Id: Ie2e6fb1e770403c4ef3463a850e8151bd312614c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/73695d0ea490c4c7a1158957dd5a85586cfa0933"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/73695d0ea490c4c7a1158957dd5a85586cfa0933"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}