)]}'
{"functions":[{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"7d35ea4f3c6862da391219890990dfe4226d8050","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"    fi"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":1418,"context_line":"        die $LINENO \"Unable to find pip; can not continue\""},{"line_number":1419,"context_line":"    fi"},{"line_number":1420,"context_line":"}"},{"line_number":1421,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2FTrk%3D","line":1418,"updated":"2013-05-15 05:10:04.000000000","message":"sorry to nitpick: isn\u0027t it cannot?","commit_id":"542e7a27ecdd6f6778f8635a01a12515b90c497d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"27713ad0b55901ac20970eb7370438e93e400740","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"        which pip"},{"line_number":1415,"context_line":"    fi"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":1418,"context_line":"        die $LINENO \"Unable to find pip; cannot continue\""},{"line_number":1419,"context_line":"    fi"},{"line_number":1420,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2FoQw%3D","line":1417,"updated":"2013-05-28 23:11:02.000000000","message":"If this is necessary, is there any reason to include it with a patch that enables EPEL?","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9e9b63eca73a039b3d87f96fc157ece438723c16","unresolved":false,"context_lines":[{"line_number":1414,"context_line":"        which pip"},{"line_number":1415,"context_line":"    fi"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":1418,"context_line":"        die $LINENO \"Unable to find pip; cannot continue\""},{"line_number":1419,"context_line":"    fi"},{"line_number":1420,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAPH%2F%2FoOQ%3D","line":1417,"in_reply_to":"AAAAPH%2F%2FoQw%3D","updated":"2013-05-28 23:27:28.000000000","message":"since pip comes from epel it\u0027s tangentially related.  With the change epel and pip *should* be installed, but it\u0027s worth a sanity check because the failure case is very non-intuitive; it calls \"$pip install\" with a blank $pip, which then tries to execute \"install\" and you get unrelated \"bad command or file-name\" output from that","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"}],"stack.sh":[{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"01d8a93ebe0bb65ef663aac88494641db046eaaf","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if ! yum repolist enabled $RHEL6_RDO_REPO_ID | grep -q $RHEL6_RDO_REPO_ID; then"},{"line_number":60,"context_line":"        echo \"RDO repo not detected; installing\""},{"line_number":61,"context_line":"        yum_install $RHEL6_RDO_REPO_RPM"},{"line_number":62,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":63,"context_line":"            die $LINENO \"Error installing RDO repo, can not continue\""},{"line_number":64,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fnxk%3D","line":61,"updated":"2013-05-29 04:30:41.000000000","message":"How about \n\nyum_install \u003cpackage\u003e || die $LINENO \"Reason .. \"\n\nIMHO, that idiom is a bit more clear and doesn\u0027t rely on $? explicitly.","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f7cddb4443054191f5eb34c908e061940cf0960","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if ! yum repolist enabled $RHEL6_RDO_REPO_ID | grep -q $RHEL6_RDO_REPO_ID; then"},{"line_number":60,"context_line":"        echo \"RDO repo not detected; installing\""},{"line_number":61,"context_line":"        yum_install $RHEL6_RDO_REPO_RPM"},{"line_number":62,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":63,"context_line":"            die $LINENO \"Error installing RDO repo, can not continue\""},{"line_number":64,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2FkyA%3D","line":61,"in_reply_to":"AAAAPH%2F%2Fnxk%3D","updated":"2013-05-30 06:38:49.000000000","message":"Done","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"01d8a93ebe0bb65ef663aac88494641db046eaaf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        echo \"RDO repo not detected; installing\""},{"line_number":61,"context_line":"        yum_install $RHEL6_RDO_REPO_RPM"},{"line_number":62,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":63,"context_line":"            die $LINENO \"Error installing RDO repo, can not continue\""},{"line_number":64,"context_line":"        fi"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fnx0%3D","line":63,"updated":"2013-05-29 04:30:41.000000000","message":"typo: can not -\u003e cannot","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f7cddb4443054191f5eb34c908e061940cf0960","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        echo \"RDO repo not detected; installing\""},{"line_number":61,"context_line":"        yum_install $RHEL6_RDO_REPO_RPM"},{"line_number":62,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":63,"context_line":"            die $LINENO \"Error installing RDO repo, can not continue\""},{"line_number":64,"context_line":"        fi"},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fkx4%3D","line":63,"in_reply_to":"AAAAPH%2F%2Fnx0%3D","updated":"2013-05-30 06:38:49.000000000","message":"Done","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"01d8a93ebe0bb65ef663aac88494641db046eaaf","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":68,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":69,"context_line":"        yum_install ${RHEL6_EPEL_RPM}"},{"line_number":70,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":71,"context_line":"            die $LINENO \"Error installing EPEL repo, can not continue\""},{"line_number":72,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fnxg%3D","line":69,"updated":"2013-05-29 04:30:41.000000000","message":"same as above.","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f7cddb4443054191f5eb34c908e061940cf0960","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":68,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":69,"context_line":"        yum_install ${RHEL6_EPEL_RPM}"},{"line_number":70,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":71,"context_line":"            die $LINENO \"Error installing EPEL repo, can not continue\""},{"line_number":72,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fkx0%3D","line":69,"in_reply_to":"AAAAPH%2F%2Fnxg%3D","updated":"2013-05-30 06:38:49.000000000","message":"Done","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"01d8a93ebe0bb65ef663aac88494641db046eaaf","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":69,"context_line":"        yum_install ${RHEL6_EPEL_RPM}"},{"line_number":70,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":71,"context_line":"            die $LINENO \"Error installing EPEL repo, can not continue\""},{"line_number":72,"context_line":"        fi"},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fnxc%3D","line":71,"updated":"2013-05-29 04:30:41.000000000","message":"cannot","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f7cddb4443054191f5eb34c908e061940cf0960","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":69,"context_line":"        yum_install ${RHEL6_EPEL_RPM}"},{"line_number":70,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":71,"context_line":"            die $LINENO \"Error installing EPEL repo, can not continue\""},{"line_number":72,"context_line":"        fi"},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAPH%2F%2Fkxw%3D","line":71,"in_reply_to":"AAAAPH%2F%2Fnxc%3D","updated":"2013-05-30 06:38:49.000000000","message":"Done","commit_id":"b4908b6abd5d8495ed95b42ec28253a34d84b7ba"}],"tools/install_prereqs.sh":[{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"5426f463b84c64eeb295de2e9843c01a6dc8fc0c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Ensure EPEL is installed for RHEL6 hosts"},{"line_number":38,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":39,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":40,"context_line":"        epel_rpm\u003d\"/tmp/epel-release-6.8.noarch.rpm\""},{"line_number":41,"context_line":"        curl -Ss -o $epel_rpm \\"},{"line_number":42,"context_line":"            \"http://dl.fedoraproject.org/pub/epel/6/x86_64/epel-release-6-8.noarch.rpm\""},{"line_number":43,"context_line":"        if [ $? -ne 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAOn%2F%2FTsE%3D","line":40,"updated":"2013-05-15 05:07:15.000000000","message":"is directly installing less reliable? \nlike:  yum_install http://dl.fedoraproject.org/pub/epel/6/x86_64/epel-release-6-8.noarch.rpm\" ?","commit_id":"542e7a27ecdd6f6778f8635a01a12515b90c497d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5f1db231de64dd06ad17e80cbdca0102f674dadd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":39,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":40,"context_line":"        yum_install \\"},{"line_number":41,"context_line":"            \"http://dl.fedoraproject.org/pub/epel/6/x86_64/epel-release-6-8.noarch.rpm\""},{"line_number":42,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":43,"context_line":"            die $LINENO \"Error downloading EPEL, can not continue\""},{"line_number":44,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAO3%2F%2F%2B3c%3D","line":41,"updated":"2013-05-15 16:04:21.000000000","message":"This should at least be set at the top of this script so it can be overridden in localrc and/or easily found then epel-release-6-9 is released.","commit_id":"0ec17302e40f8b1015fc37a353e048efdc4eec4b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9d8b879a439e21e1589c25ec5718a77e7876e10f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":39,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":40,"context_line":"        yum_install \\"},{"line_number":41,"context_line":"            \"http://dl.fedoraproject.org/pub/epel/6/x86_64/epel-release-6-8.noarch.rpm\""},{"line_number":42,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":43,"context_line":"            die $LINENO \"Error downloading EPEL, can not continue\""},{"line_number":44,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAPH%2F%2F7ak%3D","line":41,"in_reply_to":"AAAAO3%2F%2F%2B3c%3D","updated":"2013-05-19 23:06:07.000000000","message":"Not sure putting rhel6 specific things in the globals definitions is a good precedent, but making it variable with a default is good","commit_id":"0ec17302e40f8b1015fc37a353e048efdc4eec4b"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"47411a7dd4b2e45204a376a5952df803de7bec7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ is_fedora \u0026\u0026 $DISTRO \u003d~ (rhel6) ]]; then"},{"line_number":37,"context_line":"    # Ensure EPEL is installed for RHEL6 hosts"},{"line_number":38,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":39,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":40,"context_line":"        yum_install ${RHEL6_EPEL_RPM:-\\"},{"line_number":41,"context_line":"            \"http://dl.fedoraproject.org/pub/epel/6/x86_64/epel-release-6-8.noarch.rpm\"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"AAAAPH%2F%2FrF4%3D","line":38,"updated":"2013-05-27 22:24:09.000000000","message":"Please move this block to stack.sh as per the RDO patch: https://review.openstack.org/#/c/29302/","commit_id":"d1c735ad85c1d0f5dd8d0ed87a4bef49c5670318"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cd8c028b5869582acc92d70496f6413afbd1e7eb","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if [[ is_fedora \u0026\u0026 $DISTRO \u003d~ (rhel6) ]]; then"},{"line_number":37,"context_line":"    # Ensure EPEL is installed for RHEL6 hosts"},{"line_number":38,"context_line":"    if ! yum repolist enabled epel | grep -q \u0027epel\u0027; then"},{"line_number":39,"context_line":"        echo \"EPEL not detected; installing\""},{"line_number":40,"context_line":"        yum_install ${RHEL6_EPEL_RPM:-\\"},{"line_number":41,"context_line":"            \"http://dl.fedoraproject.org/pub/epel/6/x86_64/epel-release-6-8.noarch.rpm\"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"AAAAPH%2F%2FoSA%3D","line":38,"in_reply_to":"AAAAPH%2F%2FrF4%3D","updated":"2013-05-28 23:02:55.000000000","message":"Done","commit_id":"d1c735ad85c1d0f5dd8d0ed87a4bef49c5670318"}]}