)]}'
{"id":"openstack%2Fdevstack~293095","triplet_id":"openstack%2Fdevstack~master~I161a157895b4ed0c9ea5a7a00302e30f4ad75ed3","project":"openstack/devstack","branch":"master","topic":"bug/1555044","hashtags":[],"change_id":"I161a157895b4ed0c9ea5a7a00302e30f4ad75ed3","subject":"Automatically infer NICs to add to OVS bridges","status":"ABANDONED","created":"2016-03-15 19:01:41.000000000","updated":"2016-03-16 17:02:02.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c1bb664a25c5b4225a48de05080cb698cd227305","_number":293095,"virtual_id_number":293095,"owner":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":-1,"date":"2016-03-16 16:14:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-03-15 20:51:16.000000000","_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"date":"2016-03-15 19:06:28.000000000","_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"date":"2016-03-15 20:05:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":-2,"date":"2016-03-15 19:06:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},{"value":0,"date":"2016-03-15 19:02:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-15 19:02:06.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2016-03-15 19:06:52.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-03-15 20:05:39.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-03-15 20:51:16.000000000","updated_by":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"reviewer":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"state":"REVIEWER"},{"updated":"2016-03-16 16:14:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ed6a0ab9044cc52ebfc5a4a77efda4b5068cdddf","author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"date":"2016-03-15 19:01:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0657c8f8f1649ac8dca52fa98f18819dc0a97a3","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-03-15 19:04:38.000000000","message":"Patch Set 1: Code-Review-1\n\nI think this is a bit too much \"magic\" configuration.\n\nTo take a step back - where is all of this work going? I\u0027m counting a huge amount of OVS knobs that we are now creating, and frankly I am starting to get less interested in this, as more patches come in. I will comment on the other patch to the same effect.","accounts_in_message":[],"_revision_number":1},{"id":"4aa548203ebd4a7de3bd1482f5c14eae91091528","author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"date":"2016-03-15 19:06:28.000000000","message":"Patch Set 1:\n\n@Sean This is the last patch of a series to automate physical networking \u003c\u003d\u003e OVS networking through DevStack. No more knobs!","accounts_in_message":[],"_revision_number":1},{"id":"b00f4c071e80062b385abdd297281d8dfa8fd86e","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-03-15 19:06:52.000000000","message":"Patch Set 1: Code-Review-2\n\nI\u0027m -2\u0027ing this - I\u0027m starting to get very confused about all these options and how they work together. Let\u0027s take a step back.","accounts_in_message":[],"_revision_number":1},{"id":"b159e484a2d249fee45c0ac78b1140fa6efcd404","author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"date":"2016-03-15 19:14:19.000000000","message":"Patch Set 1:\n\n@Sean The whole story is documented, in order, at this patch\u0027s  doc/source/guides/neutron.rst from line 541 to 614. This is all, there\u0027s nothing else to it.","accounts_in_message":[],"_revision_number":1},{"id":"9d115950c33e0e4e2106732ac48290d5ce62c3ef","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2016-03-15 20:04:18.000000000","message":"Patch Set 1:\n\nto add some clarity\n\nthe logic in these patches is logic that we have developed and supproted as part of networking-ovs-dpdk and via pataches for devstack previously hosted on 01.org for about 2 years.\n\nin our plugin we use OVS_BRIDGE_MAPPINGS to define the list of bridge to create. we use OVS_DPDK_PORT_MAPPING(OVS_NIC_MAPPING in these patches) to define what interface should be added to each bridge and OVS_PCI_MAPPINGS to map interface to there pci address. the OVS_PCI_MAPPINGS is not need for kernel ovs.\n\nwhen you use our plugin by default only setting OVS_BRIDGE_MAPPINGS is require as we infer the other vaule automatically. optionally you can set each value directly more advanced configuration.\n\nfor example setting\nOVS_BRIDGE_MAPPINGS\u003dphysnet1:br-eth3,physnet2:br-eth4\nin your local.conf and stacking with our plugin set to deploy ovs-dpdk this will result in the creation of 2 phyical bridges br-eth3 and br-eth4. eth3 will be added to br-eth3 and eth4 will be added to br-eth4. \n\nThere are technical reasons that required us to handle creating bridges and adding interface in a very particular way when using ovs with dpdk enabled. we would like to make the behavior as similar as possible between using ovs with dpdk and using kernel ovs via devstack without requiring the dpdk specific code.","accounts_in_message":[],"_revision_number":1},{"id":"8bb73b35105e8ccdd4d426dddc61192caca45dea","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-03-15 20:05:39.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm-recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/95/293095/1/check/check-ibm-tempest-dsvm-full/2cd360d/ : SUCCESS in 1h 03m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7d9cc739533f592db23b764ced9a423f514ca0a5","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2016-03-15 20:47:34.000000000","message":"Patch Set 1:\n\none thing that i have been thinking about for the last 6 months is that there is a need\nto have a single libary in devstack that can install and configure ovs which can be used\nwhen deploying ovs with the neuton agent, odl or ovn. \ncurrently both networking-ovn and networking-ovs-dpdk have different code to compile and install ovs from source. \n\nnetworking-ovs-dpdk can be used to deploy ovs with dpdk with the neutron agent.\nthe networking-ovs-dpdk plugin can be combined with the networking-odl plugin also to have odl mangage ovs. \nnetworking-ovn is currently not compatible with networking-ovs-dpdk but we hope to fix that in the N cycle.\nit would be a lot simpler if we could add a lib to devstack to handle ovs installation(source and package) and bridge creation/port addtion.\nwould that be a perferable option to these minor changes? \n\nit would appear that neutron has recently added support for compiling ovs from source to test connection tracking.\nhttps://github.com/openstack/neutron/blob/master/devstack/lib/ovs\n\nperhaps we can contribute our changes as part of that effort instead if you do not want to have them in devstack directly.","accounts_in_message":[],"_revision_number":1},{"id":"e58318c75629cd8876555d5d4ee497b6b912bc46","author":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"date":"2016-03-15 20:51:16.000000000","message":"Patch Set 1:\n\nBuild Successful.\n* networking-odl-vhostuser-ci http://intel-openstack-ci-logs.ovh/networking-odl-vhostuser-ci/refs/changes/95/293095/1 : SUCCESS\n\nTo re-run the job please post a comment with `recheck networking-odl-vhostuser-ci`","accounts_in_message":[],"_revision_number":1},{"id":"6a918b11aa46eae418ce5c86b7f15c4e9ea20693","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-15 22:03:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-full/1c343cc/ : SUCCESS in 48m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-postgres-full/b32cf0d/ : SUCCESS in 42m 01s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-neutron-full/d3859b8/ : SUCCESS in 55m 16s\n- gate-grenade-dsvm http://logs.openstack.org/95/293095/1/check/gate-grenade-dsvm/2d7c584/ : SUCCESS in 48m 21s\n- gate-devstack-bashate http://logs.openstack.org/95/293095/1/check/gate-devstack-bashate/5cbb653/ : SUCCESS in 3m 15s\n- gate-devstack-unit-tests http://logs.openstack.org/95/293095/1/check/gate-devstack-unit-tests/320a246/ : SUCCESS in 2m 24s\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-ironic-agent_ssh-nv/aeeb7d3/ : SUCCESS in 48m 58s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/95/293095/1/check/gate-devstack-dsvm-updown/8763f6d/ : SUCCESS in 12m 42s\n- gate-tempest-dsvm-neutron-identity-v3-only-full http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full/e5bffc1/ : SUCCESS in 1h 07m 22s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/95/293095/1/check/gate-devstack-publish-docs/fc3698f//doc/build/html/ : SUCCESS in 3m 43s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/95/293095/1/check/gate-swift-dsvm-functional-nv/4ebd6cb/ : SUCCESS in 14m 08s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/95/293095/1/check/gate-grenade-dsvm-neutron/c3943a4/ : SUCCESS in 46m 24s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-multinode-full/536d99a/ : FAILURE in 58m 36s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-neutron-multinode-full/cabcfd3/ : SUCCESS in 1h 33m 59s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/95/293095/1/check/gate-grenade-dsvm-multinode/1b681a7/ : SUCCESS in 44m 59s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-platform-centos7-nv/fce8e3b/ : SUCCESS in 50m 58s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/95/293095/1/check/gate-tempest-dsvm-platform-fedora23-nv/e34f5db/ : FAILURE in 24m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2584db9051b021c0ae23a9473c4ba480ffa4802c","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-03-16 15:18:19.000000000","message":"Patch Set 1:\n\n@Sean Mooney\n\nI don\u0027t believe the solution is to put it in the Neutron devstack plugin. That plugin has a lot of stuff in it, and it has seen organic growth. I would *prefer* that if there really are a lot of OVS specific things (such as compiling OVS from source, doing bridge plugging, and so forth), that it be an *OVS* specific devstack plugin, rather than being placed into other existing devstack plugins that just bloat things up more.","accounts_in_message":[],"_revision_number":1},{"id":"9e86e25eae186ebb1b892b33ab9c8996e97ea997","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-16 16:14:52.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"f7679a67c85b8d9f8fbfb452e2bbb072002b5638","author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"date":"2016-03-16 17:02:02.000000000","message":"Abandoned\n\nAbandoning per community decision about the trimming and refactoring of upstream DevStack, and the revert of required patch at https://review.openstack.org/#/c/293100/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9c5b620cc8029375269104f7fd637afede73702e","revisions":{"9c5b620cc8029375269104f7fd637afede73702e":{"kind":"REWORK","_number":1,"created":"2016-03-15 19:01:41.000000000","uploader":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"ref":"refs/changes/95/293095/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/95/293095/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/95/293095/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/95/293095/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/95/293095/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/95/293095/1"}}},"commit":{"parents":[{"commit":"657cd481376bfb3d2bd98caae38e6130e610c529","subject":"Add support for auto adding NICs to OVS bridges","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/657cd481376bfb3d2bd98caae38e6130e610c529"}]}],"author":{"name":"Igor Duarte Cardoso","email":"igor.duarte.cardoso@intel.com","date":"2016-03-15 18:59:54.000000000","tz":0},"committer":{"name":"Igor Duarte Cardoso","email":"igor.duarte.cardoso@intel.com","date":"2016-03-15 18:59:54.000000000","tz":0},"subject":"Automatically infer NICs to add to OVS bridges","message":"Automatically infer NICs to add to OVS bridges\n\nBy setting the new OVS_NICS_FROM_BRIDGES variable to True, DevStack will be\nable to automatically create mappings between host network interfaces and OVS\nbridges (set in the OVS_NIC_MAPPINGS variable) by detecting the network\ninterface names from the OVS bridge names as set in OVS_BRIDGE_MAPPINGS.\n\nThe text after \"br-\" in each of the bridges\u0027 names will be assumed to be the\nname of an existing network interface, and will be mapped to the respective\nOVS bridge through OVS_NIC_MAPPINGS.\n\nFor example:\n\n    OVS_NICS_FROM_BRIDGES\u003dTrue\n    OVS_BRIDGE_MAPPINGS\u003dphysnet1:br-eth3,physnet2:br-eth4\n\nWill result in OVS_NIC_MAPPINGS being set to \"eth3:br-eth3,eth4:br-eth4\"\nthus automating the creation of OVS ports attached to these host interfaces.\n\nChange-Id: I161a157895b4ed0c9ea5a7a00302e30f4ad75ed3\nCloses-Bug: #1555044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9c5b620cc8029375269104f7fd637afede73702e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9c5b620cc8029375269104f7fd637afede73702e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}