)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"414c42d9e1cd045194a1820a6aaae41384963242","unresolved":false,"context_lines":[{"line_number":12,"context_line":"problems with the Ironic devstack plugin and tempest, because the flavor"},{"line_number":13,"context_line":"we need for the DEFAULT_INSTANCE_TYPE is created by the Ironic devstack"},{"line_number":14,"context_line":"plugin, and the tempest extra.d configuration is run before that code"},{"line_number":15,"context_line":"could excute this meant that the flavor_ref in tempest would not match"},{"line_number":16,"context_line":"the DEFAULT_INSTANCE_TYPE, because it didn\u0027t exist when that code was"},{"line_number":17,"context_line":"run."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1af94dfe_77e8f5b4","line":15,"updated":"2016-03-17 11:20:36.000000000","message":"Typos:\n\"excute\" -\u003e \"execute\"\n\"execute this meant\" -\u003e \"execute. This meant\"\n\nThough overall I think the chain of causality would be clearer if written as a bulleted list, something like the following:\n\n\"\"\"\nCurrently this causes problems with the Ironic devstack plugin and Tempest:\n - the tempest extra.d configuration is run, creating the flavor_ref\n - the Ironic devstack plugin is run, creating the flavor needed for DEFAULT_INSTANCE_TYPE\n - hence flavor_ref does not match DEFAULT_INSTANCE_TYPE, because when the former was set the latter didn\u0027t exist\n - builds fail incorrectly.\n\"\"\"\n\nThat\u0027s just personal preference, though.","commit_id":"de55f2cf2571cfcfb860c1995080c9e8385c1995"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2f07070ce23136984d3407e11347b849230bf2e2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This leads to build failures as tempest can not find the required"},{"line_number":22,"context_line":"flavor, so it writes which ever flavor it can find at the time into"},{"line_number":23,"context_line":"flavor_ref. Ironic now has code it its devstack plugin duplicated from"},{"line_number":24,"context_line":"the tempest plugin work around this problem until this is merged."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This patch fixes this by making the post-config phase a useable phase by"},{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_495e3713","line":24,"updated":"2016-05-19 10:32:10.000000000","message":"Nit: \"to work around\"","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9224bd173551341469479c4b69fd894fde20316c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This leads to build failures as tempest can not find the required"},{"line_number":22,"context_line":"flavor, so it writes which ever flavor it can find at the time into"},{"line_number":23,"context_line":"flavor_ref. Ironic now has code it its devstack plugin duplicated from"},{"line_number":24,"context_line":"the tempest plugin work around this problem until this is merged."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This patch fixes this by making the post-config phase a useable phase by"},{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_ee739c7e","line":24,"in_reply_to":"bab6814e_495e3713","updated":"2016-05-19 15:26:15.000000000","message":"Done","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2f07070ce23136984d3407e11347b849230bf2e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"flavor_ref. Ironic now has code it its devstack plugin duplicated from"},{"line_number":24,"context_line":"the tempest plugin work around this problem until this is merged."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This patch fixes this by making the post-config phase a useable phase by"},{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"},{"line_number":28,"context_line":"other plugin that needs really late configuration can use this stage to"},{"line_number":29,"context_line":"wait until all other processes are done configuring to do their"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_a9824350","line":26,"updated":"2016-05-19 10:32:10.000000000","message":"\"a useable phase by\" -\u003e \"usable by\"","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9224bd173551341469479c4b69fd894fde20316c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"flavor_ref. Ironic now has code it its devstack plugin duplicated from"},{"line_number":24,"context_line":"the tempest plugin work around this problem until this is merged."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This patch fixes this by making the post-config phase a useable phase by"},{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"},{"line_number":28,"context_line":"other plugin that needs really late configuration can use this stage to"},{"line_number":29,"context_line":"wait until all other processes are done configuring to do their"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_2e6e4495","line":26,"in_reply_to":"bab6814e_a9824350","updated":"2016-05-19 15:26:15.000000000","message":"Done","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2f07070ce23136984d3407e11347b849230bf2e2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"the tempest plugin work around this problem until this is merged."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This patch fixes this by making the post-config phase a useable phase by"},{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"},{"line_number":28,"context_line":"other plugin that needs really late configuration can use this stage to"},{"line_number":29,"context_line":"wait until all other processes are done configuring to do their"},{"line_number":30,"context_line":"configuration, however it still runs before the local.conf configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_69917b99","line":27,"updated":"2016-05-19 10:32:10.000000000","message":"\"plugins, this\" -\u003e \"plugins. This\"","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9224bd173551341469479c4b69fd894fde20316c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"the tempest plugin work around this problem until this is merged."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This patch fixes this by making the post-config phase a useable phase by"},{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"},{"line_number":28,"context_line":"other plugin that needs really late configuration can use this stage to"},{"line_number":29,"context_line":"wait until all other processes are done configuring to do their"},{"line_number":30,"context_line":"configuration, however it still runs before the local.conf configuration"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_8e13f00c","line":27,"in_reply_to":"bab6814e_69917b99","updated":"2016-05-19 15:26:15.000000000","message":"Done","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2f07070ce23136984d3407e11347b849230bf2e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"},{"line_number":28,"context_line":"other plugin that needs really late configuration can use this stage to"},{"line_number":29,"context_line":"wait until all other processes are done configuring to do their"},{"line_number":30,"context_line":"configuration, however it still runs before the local.conf configuration"},{"line_number":31,"context_line":"overrides."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I3d98692e69d94756e0034c83a247e05d85177f02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_69e85b11","line":30,"updated":"2016-05-19 10:32:10.000000000","message":"\"configuration, however\" -\u003e \"configuration. However, \"","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9224bd173551341469479c4b69fd894fde20316c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"the extra.d and out of tree plugins, this means that tempest and any"},{"line_number":28,"context_line":"other plugin that needs really late configuration can use this stage to"},{"line_number":29,"context_line":"wait until all other processes are done configuring to do their"},{"line_number":30,"context_line":"configuration, however it still runs before the local.conf configuration"},{"line_number":31,"context_line":"overrides."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I3d98692e69d94756e0034c83a247e05d85177f02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_eefa7cbc","line":30,"in_reply_to":"bab6814e_69e85b11","updated":"2016-05-19 15:26:15.000000000","message":"Done","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"}],"extras.d/80-tempest.sh":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"d8a17c058aa7a050e0c4f79c201be60ec561a3dd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        echo_summary \"Initializing Tempest\""},{"line_number":15,"context_line":"        configure_tempest"},{"line_number":16,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-extra\" ]]; then"},{"line_number":17,"context_line":"        # local.conf Tempest option overrides"},{"line_number":18,"context_line":"        :"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_2efe4437","side":"PARENT","line":17,"updated":"2016-05-19 15:26:35.000000000","message":"IMHO we prefer the #no-op sytle instead of removal.","commit_id":"ab539b441da09240cca487527802b4552d4667ad"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"459369508303b5ffca774d446823e0351edbf0e5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        echo_summary \"Initializing Tempest\""},{"line_number":15,"context_line":"        configure_tempest"},{"line_number":16,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-extra\" ]]; then"},{"line_number":17,"context_line":"        # local.conf Tempest option overrides"},{"line_number":18,"context_line":"        :"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_61005d02","side":"PARENT","line":17,"in_reply_to":"bab6814e_2efe4437","updated":"2016-05-19 15:28:55.000000000","message":"Done","commit_id":"ab539b441da09240cca487527802b4552d4667ad"}],"stack.sh":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2f07070ce23136984d3407e11347b849230bf2e2","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"run_phase stack extra"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"# Phase:"},{"line_number":1333,"context_line":"run_phase stack post-extra"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"# local.conf post-extra"},{"line_number":1336,"context_line":"# ---------------------"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bab6814e_095a6f50","line":1333,"updated":"2016-05-19 10:32:10.000000000","message":"The `run_phase stack extra` line comes after the corresponding `merge_config_group` call, but this one comes before - is that correct?","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"9224bd173551341469479c4b69fd894fde20316c","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"run_phase stack extra"},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"# Phase:"},{"line_number":1333,"context_line":"run_phase stack post-extra"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"# local.conf post-extra"},{"line_number":1336,"context_line":"# ---------------------"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bab6814e_ce78582e","line":1333,"in_reply_to":"bab6814e_095a6f50","updated":"2016-05-19 15:26:15.000000000","message":"Yes, because we need to ensure that people configuring ini overrides in local.conf in the post-config phase can override anything configured by the extra.d files or plugins run at this phase.","commit_id":"0728fa8b54ce5db31356223d0b774ea57ded1fc4"}]}