)]}'
{"id":"openstack%2Fdevstack~29778","triplet_id":"openstack%2Fdevstack~master~Id9b072a6dceeb4e179d2b6a25bbdfb559c299e95","project":"openstack/devstack","branch":"master","topic":"master","hashtags":[],"change_id":"Id9b072a6dceeb4e179d2b6a25bbdfb559c299e95","subject":"Use --managed-save flag to virsh undefine","status":"MERGED","created":"2013-05-20 14:13:14.000000000","updated":"2013-05-20 16:24:47.000000000","submitted":"2013-05-20 16:24:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c38107134b07a9c571dd3024bf576e8dbc312b6","_number":29778,"virtual_id_number":29778,"owner":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-05-20 16:24:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-20 14:38:32.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":2,"date":"2013-05-20 14:58:10.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-20 14:38:32.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-05-20 14:58:25.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-20 14:38:32.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-05-20 14:58:25.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-05-20 16:24:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a411a79151f4ba7200876fdb6a9177d89aa1cfd2","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-20 14:38:32.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nThis addresses issues that I had encountered","accounts_in_message":[],"_revision_number":1},{"id":"fd8d468f50c3fd6aba96f0f8c9f061f47ae68596","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 14:58:09.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/29778/1/check/gate-tempest-devstack-vm-full/16903 : SUCCESS in 43m 56s\n- http://logs.openstack.org/29778/1/check/gate-tempest-devstack-vm-postgres-full/16618 : FAILURE in 44m 43s (non-voting)\n- http://logs.openstack.org/29778/1/check/gate-tempest-devstack-vm-quantum/23512 : SUCCESS in 21m 40s\n- http://logs.openstack.org/29778/1/check/gate-grenade-devstack-vm/4460 : FAILURE in 10m 08s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"b2837ba82d671077654abfabc2ba5ca02a4a6908","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-20 14:58:10.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nwill wait for check to return before sending to gate.","accounts_in_message":[],"_revision_number":1},{"id":"b8685b56ce0ace88dbf9e9d43234a257af36c3f7","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-05-20 14:58:25.000000000","message":"Patch Set 1: Approved\n\ncheck returned, +A. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"edaaab61fd1179df38db47a77ba856b766e9b27c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 14:58:27.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"8f71773198a0bc68a893dbcc649c92d571cf6f50","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 16:24:46.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/29778/1/gate/gate-tempest-devstack-vm-full/16926 : SUCCESS in 44m 29s\n- http://logs.openstack.org/29778/1/gate/gate-tempest-devstack-vm-postgres-full/16641 : FAILURE in 42m 15s (non-voting)\n- http://logs.openstack.org/29778/1/gate/gate-tempest-devstack-vm-quantum/23536 : SUCCESS in 20m 11s\n- http://logs.openstack.org/29778/1/gate/gate-grenade-devstack-vm/4482 : FAILURE in 11m 40s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"87759d2d809935e0d51625ee64ad0b1e5af4aac7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-20 16:24:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d52008acd48dbff6fcee01a159e9f65bf142b714","revisions":{"d52008acd48dbff6fcee01a159e9f65bf142b714":{"kind":"REWORK","_number":1,"created":"2013-05-20 14:13:14.000000000","uploader":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"ref":"refs/changes/78/29778/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/78/29778/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/29778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/29778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/29778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/78/29778/1"}}},"commit":{"parents":[{"commit":"683ef75510389d124421f0019df11f73b6959cd9","subject":"Merge \"Do not run selinux commands if it is disabled.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/683ef75510389d124421f0019df11f73b6959cd9"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-05-20 14:03:43.000000000","tz":60},"committer":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2013-05-20 14:07:27.000000000","tz":60},"subject":"Use --managed-save flag to virsh undefine","message":"Use --managed-save flag to virsh undefine\n\nIf a virtual machine has got a managed save image, it is not\npossible to delete it using a plain \u0027virsh undefine\u0027 command.\nWhile Nova doesn\u0027t use \u0027managed save\u0027, the libvirt-guests\ninit script or systemd service may have created one if the\nuser rebooted their host. Thus we devstack should pass the\n--managed-save flag to virsh to ensure the VM\u0027s removal.\n\nChange-Id: Id9b072a6dceeb4e179d2b6a25bbdfb559c299e95\nSigned-off-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d52008acd48dbff6fcee01a159e9f65bf142b714"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d52008acd48dbff6fcee01a159e9f65bf142b714"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}