)]}'
{"lib/keystone":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"adc95e8c99cbc3477c63e10f0adf58900f5731ab","unresolved":false,"context_lines":[{"line_number":108,"context_line":"KEYSTONE_ADMIN_BIND_HOST\u003d${KEYSTONE_ADMIN_BIND_HOST:-$KEYSTONE_SERVICE_HOST}"},{"line_number":109,"context_line":"# Set the project for service accounts in Keystone"},{"line_number":110,"context_line":"SERVICE_PROJECT_NAME\u003d${SERVICE_PROJECT_NAME:-service}"},{"line_number":111,"context_line":"SERVICE_TENANT_NAME\u003d${SERVICE_PROJECT_NAME:-service}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# if we are running with SSL use https protocols"},{"line_number":114,"context_line":"if is_ssl_enabled_service \"key\" || is_service_enabled tls-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a061dce_750c5b3b","line":111,"updated":"2016-04-06 13:33:50.000000000","message":"SERVICE_PROJECT_NAME is always set here so no need for the default.","commit_id":"0b1465b6f699a974e3900fff2a810aec6a6bf43c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"61b8451f1d79965c40eb63617230025fd977c682","unresolved":false,"context_lines":[{"line_number":108,"context_line":"KEYSTONE_ADMIN_BIND_HOST\u003d${KEYSTONE_ADMIN_BIND_HOST:-$KEYSTONE_SERVICE_HOST}"},{"line_number":109,"context_line":"# Set the project for service accounts in Keystone"},{"line_number":110,"context_line":"SERVICE_PROJECT_NAME\u003d${SERVICE_PROJECT_NAME:-service}"},{"line_number":111,"context_line":"SERVICE_TENANT_NAME\u003d${SERVICE_PROJECT_NAME:-service}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# if we are running with SSL use https protocols"},{"line_number":114,"context_line":"if is_ssl_enabled_service \"key\" || is_service_enabled tls-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a061dce_86e6c141","line":111,"in_reply_to":"9a061dce_750c5b3b","updated":"2016-04-08 01:19:23.000000000","message":"AFAICS there is no need for SERVICE_TENANT_NAME at all in this change, as all users have been removed.\n\nMaybe it\u0027s intentional that you\u0027re keeping it here aliased to SERVICE_PROJECT_NAME for external plugins or something that might still require it?\n\nIf so, I\u0027d prefer to see it (as mentioned) just a copy of SERVICE_PROJECT_NAME, but more importantly commented that although it seems unused, it is left behind for backwards compatibility.\n\nif it\u0027s not used, then remove it","commit_id":"0b1465b6f699a974e3900fff2a810aec6a6bf43c"}]}