)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d2439325fabc7900a783726e0aa591ec9765f60","unresolved":false,"context_lines":[{"line_number":933,"context_line":"}"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"# create_instance_types(): Create default flavors"},{"line_number":936,"context_line":"function create_instance_types {"},{"line_number":937,"context_line":"    local defaults\u003d\u0027--swap 0 --ephemeral 0 --rxtx-factor 1.0 --public\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    if ! openstack flavor list | grep -q devstack; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a061dce_7917a351","line":936,"range":{"start_line":936,"start_character":9,"end_line":936,"end_character":30},"updated":"2016-04-04 17:54:36.000000000","message":"Should we just call this create_flavors?\n\nThe comment says flavors, the commands used are for flavors, and we had that old bp at one point to literally go through nova and replace instance_type with flavor everywhere.","commit_id":"f572d37f6b7df2f2e4b8f1ea55d8092d5541a2f4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"164d5269ef103727475c482e32759a02c711dfdf","unresolved":false,"context_lines":[{"line_number":933,"context_line":"}"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"# create_instance_types(): Create default flavors"},{"line_number":936,"context_line":"function create_instance_types {"},{"line_number":937,"context_line":"    local defaults\u003d\u0027--swap 0 --ephemeral 0 --rxtx-factor 1.0 --public\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    if ! openstack flavor list | grep -q devstack; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a061dce_fc9c416b","line":936,"range":{"start_line":936,"start_character":9,"end_line":936,"end_character":30},"in_reply_to":"9a061dce_7917a351","updated":"2016-04-04 18:08:42.000000000","message":"I typed what sdague told me to type.\n\nI prefer flavors to instance_types, so I\u0027m cool with changing it if that\u0027s the consensus.","commit_id":"f572d37f6b7df2f2e4b8f1ea55d8092d5541a2f4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5b13e531e71ebff7ae68be76020632317c1c26e","unresolved":false,"context_lines":[{"line_number":933,"context_line":"}"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"# create_instance_types(): Create default flavors"},{"line_number":936,"context_line":"function create_instance_types {"},{"line_number":937,"context_line":"    local defaults\u003d\u0027--swap 0 --ephemeral 0 --rxtx-factor 1.0 --public\u0027"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    if ! openstack flavor list | grep -q devstack; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a061dce_cdcb8971","line":936,"range":{"start_line":936,"start_character":9,"end_line":936,"end_character":30},"in_reply_to":"9a061dce_fc9c416b","updated":"2016-04-04 19:19:57.000000000","message":"ok, as flavors is the new name, \u0027create_flavors\u0027 it is.","commit_id":"f572d37f6b7df2f2e4b8f1ea55d8092d5541a2f4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a5b13e531e71ebff7ae68be76020632317c1c26e","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        openstack flavor create --id d1 --ram 256 --disk 1 --vcpus 1 $defaults devstack.tiny"},{"line_number":941,"context_line":"        openstack flavor create --id d2 --ram 512 --disk 2 --vcpus 1 $defaults devstack.small"},{"line_number":942,"context_line":"        openstack flavor create --id d3 --ram 1024 --disk 4 --vcpus 2 $defaults devstack.medium"},{"line_number":943,"context_line":"        openstack flavor create --id d4 --ram 2048 --disk 8 --vcpus 4 $defaults devstack.large"},{"line_number":944,"context_line":"    fi"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    if ! openstack flavor list | grep -q m1.tiny; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a061dce_ed6dad33","line":943,"updated":"2016-04-04 19:19:57.000000000","message":"I think the following are probably the best flavors to be used\n\n```\n        openstack flavor create --id c1 --ram 256 --disk 0 --vcpus 1 $defaults cirros256\n        openstack flavor create --id d1 --ram 512 --disk 5 --vcpus 1 $defaults ds0.5G\n        openstack flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 $defaults ds1G\n        openstack flavor create --id d3 --ram 2048 --disk 10 --vcpus 2 $defaults ds2G\n        openstack flavor create --id d4 --ram 4096 --disk 20 --vcpus 4 $defaults ds4G\n\n```","commit_id":"f572d37f6b7df2f2e4b8f1ea55d8092d5541a2f4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ea09ee7e7cd44ddb46834983d1d94adbd19e9aae","unresolved":false,"context_lines":[{"line_number":935,"context_line":"# create_instance_types(): Create default flavors"},{"line_number":936,"context_line":"function create_flavors {"},{"line_number":937,"context_line":"    if ! openstack flavor list | grep -q devstack; then"},{"line_number":938,"context_line":"\t# Note that danms hates these flavors and apologizes for sdague"},{"line_number":939,"context_line":"        openstack flavor create --id c1 --ram 256 --disk 0 --vcpus 1 cirros256"},{"line_number":940,"context_line":"        openstack flavor create --id d1 --ram 512 --disk 5 --vcpus 1 ds512M"},{"line_number":941,"context_line":"        openstack flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 ds1G"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a061dce_5ededc3f","line":938,"range":{"start_line":938,"start_character":0,"end_line":938,"end_character":1},"updated":"2016-04-05 12:21:02.000000000","message":"a tab at here :)","commit_id":"2179afae8a1f5d751c61ca4f4158095cd94a9519"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e0a4ba143552addc5ba1cc0e11e42c3ea2d853fc","unresolved":false,"context_lines":[{"line_number":932,"context_line":"    stop_nova_compute"},{"line_number":933,"context_line":"}"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"# create_instance_types(): Create default flavors"},{"line_number":936,"context_line":"function create_flavors {"},{"line_number":937,"context_line":"    if ! openstack flavor list | grep -q ds512M; then"},{"line_number":938,"context_line":"    # Note that danms hates these flavors and apologizes for sdague"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a061dce_109ed562","line":935,"updated":"2016-04-06 12:03:33.000000000","message":"s/create_instance_types/create_flavors/","commit_id":"4b205db45b34e698734740b50752e11b75035e72"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"20023ef7ae5b12fcc1d835665e8f138897ecc6e2","unresolved":false,"context_lines":[{"line_number":935,"context_line":"# create_instance_types(): Create default flavors"},{"line_number":936,"context_line":"function create_flavors {"},{"line_number":937,"context_line":"    if ! openstack flavor list | grep -q ds512M; then"},{"line_number":938,"context_line":"    # Note that danms hates these flavors and apologizes for sdague"},{"line_number":939,"context_line":"        openstack flavor create --id c1 --ram 256 --disk 0 --vcpus 1 cirros256"},{"line_number":940,"context_line":"        openstack flavor create --id d1 --ram 512 --disk 5 --vcpus 1 ds512M"},{"line_number":941,"context_line":"        openstack flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 ds1G"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a061dce_0d6278ad","line":938,"updated":"2016-04-05 13:34:08.000000000","message":"I\u0027m surprised bash8 doesn\u0027t fail on the intend here.","commit_id":"4b205db45b34e698734740b50752e11b75035e72"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"91b6b271a752a29f40402b6b37e4fd3627088224","unresolved":false,"context_lines":[{"line_number":948,"context_line":"        openstack flavor create --id 2 --ram 2048 --disk 20 --vcpus 1 m1.small"},{"line_number":949,"context_line":"        openstack flavor create --id 3 --ram 4096 --disk 40 --vcpus 2 m1.medium"},{"line_number":950,"context_line":"        openstack flavor create --id 4 --ram 8192 --disk 80 --vcpus 4 m1.large"},{"line_number":951,"context_line":"        openstack flavor create --id 5 --ram 16384 --disk 160 --vcpus 8 m1.xlarge"},{"line_number":952,"context_line":"    fi"},{"line_number":953,"context_line":"}"},{"line_number":954,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a061dce_935e9d10","line":951,"updated":"2016-04-05 15:53:48.000000000","message":"That looks similar with what we remove in https://review.openstack.org/#/c/300127/8/nova/db/sqlalchemy/migrate_repo/versions/216_havana.py","commit_id":"4b205db45b34e698734740b50752e11b75035e72"}]}