)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"4ef544bca2eda4aff2e3a2214b80ced7eedf8805","unresolved":false,"context_lines":[{"line_number":24,"context_line":"wide variety of \"--config-file\" arguments employed by neutron\u0027s devstack"},{"line_number":25,"context_line":"logic.  To help slightly with this, this change also changes a few"},{"line_number":26,"context_line":"instances of `--config-file\u003dfoo` to `--config-file foo` (no `\u003d`) for"},{"line_number":27,"context_line":"uniformity."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Ia9675dff9232e0e987a836ecaf9e842eb5c3cb18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9abb7d3a_965b012e","line":27,"updated":"2016-05-30 22:53:02.000000000","message":"This warrants a separate changeset.","commit_id":"403a54ca54ccebb488f7ba90860ac9d4274c684e"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"8b241e74c7f3b7b0380c7b416a9a4cb128deb3e1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"wide variety of \"--config-file\" arguments employed by neutron\u0027s devstack"},{"line_number":25,"context_line":"logic.  To help slightly with this, this change also changes a few"},{"line_number":26,"context_line":"instances of `--config-file\u003dfoo` to `--config-file foo` (no `\u003d`) for"},{"line_number":27,"context_line":"uniformity."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Ia9675dff9232e0e987a836ecaf9e842eb5c3cb18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9abb7d3a_a9cd035f","line":27,"in_reply_to":"9abb7d3a_965b012e","updated":"2016-05-31 04:20:20.000000000","message":"Ah, I was just about to refer to this paragraph in reply to your other comments ;)\n\nThe only reason to make this s/\u003d/ / change is so that it is easier to match the privsep command line with a sudoers/rootwrap filter.  I\u0027ll break these bits out into a separate change though, as you request.","commit_id":"403a54ca54ccebb488f7ba90860ac9d4274c684e"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"522219d06ebae8649b96281f538a12b70d0a4c47","unresolved":false,"context_lines":[{"line_number":24,"context_line":"wide variety of \"--config-file\" arguments employed by neutron\u0027s devstack"},{"line_number":25,"context_line":"logic.  To help slightly with this, this change also changes a few"},{"line_number":26,"context_line":"instances of `--config-file\u003dfoo` to `--config-file foo` (no `\u003d`) for"},{"line_number":27,"context_line":"uniformity."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: Ia9675dff9232e0e987a836ecaf9e842eb5c3cb18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9abb7d3a_a45a4a4e","line":27,"in_reply_to":"9abb7d3a_a9cd035f","updated":"2016-05-31 05:06:45.000000000","message":"Moved these bits into I91fe18f66f3c3bc2ccd1ca8be91be2915ed3e3ec","commit_id":"403a54ca54ccebb488f7ba90860ac9d4274c684e"}],"lib/neutron":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"eaf7c73c8847eb0cef076f38899c5d6c1baef5f4","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# configure_neutron() - Set config files, create data dirs, etc"},{"line_number":111,"context_line":"function configure_neutron_new {"},{"line_number":112,"context_line":"    _set_config_files"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9abb7d3a_fadccb74","line":112,"updated":"2016-05-31 13:49:25.000000000","message":"This is already called in start_neutron_new - was there something broken that prompted this? _set_config_files is pretty ugly and hacky so I wouldn\u0027t be surprised.","commit_id":"4a43bc4653c101c7aad4c074af783f4b568ddd9c"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"eb2eff32571cdd71cde3115de731f42c8028ea37","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# configure_neutron() - Set config files, create data dirs, etc"},{"line_number":111,"context_line":"function configure_neutron_new {"},{"line_number":112,"context_line":"    _set_config_files"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9abb7d3a_d9fa9042","line":112,"in_reply_to":"9abb7d3a_fadccb74","updated":"2016-06-01 06:41:21.000000000","message":"Oops, my intention was to *move* it from start* to configure*.  Fixed.\n\nThe issue is that I now need to use $NEUTRON_CONFIG_ARG in the helper_command value in *.conf, so I needed $NEUTRON_CONFIG_ARG to be properly initialised at configure_neutron_new-time.","commit_id":"4a43bc4653c101c7aad4c074af783f4b568ddd9c"}],"lib/neutron-legacy":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"d2058c26b0a5739be56b785ca6d65c680bf20175","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"function _determine_config_vpn {"},{"line_number":396,"context_line":"    local cfg_file"},{"line_number":397,"context_line":"    local opts\u003d\"--config-file $NEUTRON_CONF --config-file $Q_L3_CONF_FILE --config-file $Q_VPN_CONF_FILE\""},{"line_number":398,"context_line":"    if is_service_enabled q-fwaas; then"},{"line_number":399,"context_line":"        opts+\u003d\" --config-file $Q_FWAAS_CONF_FILE\""},{"line_number":400,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a122d0e_d62cec03","line":397,"updated":"2016-04-29 16:34:11.000000000","message":"I wonder if we still need the Q_VPN_CONF_FILE since it\u0027s supposed to be a plugin and the devstack support for vpn is deprecated. Or at least it\u0027s supposed to be, per \n\n47115b0314bcb9006d674fb0c7da6ac6eb94de29","commit_id":"5d0d86dc1983d8458a5f116f1230199a14965168"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"3e5af9e364ebf04701c37e85455cf9e03258b22d","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    run_process q-meta \"$AGENT_META_BINARY --config-file $NEUTRON_CONF --config-file\u003d$Q_META_CONF_FILE\""},{"line_number":536,"context_line":"    run_process q-lbaas \"$AGENT_LBAAS_BINARY --config-file $NEUTRON_CONF --config-file\u003d$LBAAS_AGENT_CONF_FILENAME\""},{"line_number":537,"context_line":"    run_process q-metering \"$AGENT_METERING_BINARY --config-file $NEUTRON_CONF --config-file $METERING_AGENT_CONF_FILENAME\""},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    if [ \"$VIRT_DRIVER\" \u003d \u0027xenserver\u0027 ]; then"},{"line_number":540,"context_line":"        # For XenServer, start an agent for the domU openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9abb7d3a_363695e6","side":"PARENT","line":537,"updated":"2016-05-30 22:52:25.000000000","message":"This appears unrelated","commit_id":"35f0f09f005e9879d73ba6242cbf8e5409ff70a6"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"3e5af9e364ebf04701c37e85455cf9e03258b22d","unresolved":false,"context_lines":[{"line_number":297,"context_line":"}"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"function _determine_config_l3 {"},{"line_number":300,"context_line":"    local opts\u003d\"--config-file $NEUTRON_CONF --config-file $Q_L3_CONF_FILE\""},{"line_number":301,"context_line":"    if is_service_enabled q-fwaas; then"},{"line_number":302,"context_line":"        opts+\u003d\" --config-file $Q_FWAAS_CONF_FILE\""},{"line_number":303,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9abb7d3a_1631d1ec","line":300,"updated":"2016-05-30 22:52:25.000000000","message":"This appears unrelated","commit_id":"403a54ca54ccebb488f7ba90860ac9d4274c684e"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"3e5af9e364ebf04701c37e85455cf9e03258b22d","unresolved":false,"context_lines":[{"line_number":524,"context_line":"}"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"function start_mutnauq_other_agents {"},{"line_number":527,"context_line":"    run_process q-dhcp \"$AGENT_DHCP_BINARY --config-file $NEUTRON_CONF --config-file $Q_DHCP_CONF_FILE\""},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    if is_service_enabled neutron-vpnaas; then"},{"line_number":530,"context_line":"        :  # Started by plugin"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9abb7d3a_764e5d70","line":527,"updated":"2016-05-30 22:52:25.000000000","message":"This appears unrelated","commit_id":"403a54ca54ccebb488f7ba90860ac9d4274c684e"}]}