)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"46926eff5a1b570d9b3c42dba3d7ceba464bec60","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        [[ ${service} \u003d\u003d n-cell-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cell\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2067,"context_line":"        [[ ${service} \u003d\u003d n-cpu-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cpu\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2068,"context_line":"        [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ,${ENABLED_SERVICES} \u003d~ ,\"n-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2069,"context_line":"        [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"g-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2070,"context_line":"        [[ ${service} \u003d\u003d \"neutron\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"q-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2071,"context_line":"        [[ ${service} \u003d\u003d \"trove\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"tr-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2072,"context_line":"        [[ ${service} \u003d\u003d \"swift\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"s-\" ]] \u0026\u0026 enabled\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a122d0e_0d7eae18","line":2069,"updated":"2016-04-26 22:03:46.000000000","message":"might as well fix these in a similar way too\n\nit\u0027s also not immediately obvious what\u0027s going on, so a comment about the matching would be good too","commit_id":"40038c7cc57d87cc9ea66053f331a95c0f07eebb"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"4fc47317c4ad55d5bcd218357e77dfbe8e9debb4","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        [[ ${service} \u003d\u003d n-cell-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cell\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2067,"context_line":"        [[ ${service} \u003d\u003d n-cpu-* \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"n-cpu\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2068,"context_line":"        [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ,${ENABLED_SERVICES} \u003d~ ,\"n-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2069,"context_line":"        [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"g-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2070,"context_line":"        [[ ${service} \u003d\u003d \"neutron\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"q-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2071,"context_line":"        [[ ${service} \u003d\u003d \"trove\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"tr-\" ]] \u0026\u0026 enabled\u003d0"},{"line_number":2072,"context_line":"        [[ ${service} \u003d\u003d \"swift\" \u0026\u0026 ${ENABLED_SERVICES} \u003d~ \"s-\" ]] \u0026\u0026 enabled\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a122d0e_b3638f19","line":2069,"in_reply_to":"1a122d0e_0d7eae18","updated":"2016-04-27 11:52:18.000000000","message":"Sure, I might as well change the others as well.\n\nI first tried to remove the line entirely since the check was also being done in lib/nova/is_nova_enabled().  It is done correctly there.   I don\u0027t understand why this check is needed or what is different about this check.","commit_id":"40038c7cc57d87cc9ea66053f331a95c0f07eebb"}]}