)]}'
{"id":"openstack%2Fdevstack~310642","triplet_id":"openstack%2Fdevstack~stable%2Fkilo~I2bb7ac01e619c8a9b22bd517a4ff60d67035dfed","project":"openstack/devstack","branch":"stable/kilo","topic":"vpnaas-devstack-plugin","hashtags":[],"change_id":"I2bb7ac01e619c8a9b22bd517a4ff60d67035dfed","subject":"Prevent spawning two VPN agents","status":"MERGED","created":"2016-04-28 02:53:09.000000000","updated":"2016-05-09 16:35:59.000000000","submitted":"2016-05-09 16:35:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b7cc411e02dfa74f27d44b53f08d84d3d02d27f2","_number":310642,"virtual_id_number":310642,"owner":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},{"value":2,"date":"2016-05-09 16:35:59.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":2,"date":"2016-05-03 08:50:20.000000000","_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":1,"date":"2016-05-06 12:50:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-09 14:54:58.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-09 14:54:58.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-03 08:50:20.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-05-06 12:50:01.000000000","updated_by":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"reviewer":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"state":"REVIEWER"},{"updated":"2016-05-09 14:54:58.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-05-09 16:35:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0e6976c59de0e47e0c6a180d31efd91d4c8592c5","author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"date":"2016-04-28 02:53:09.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"c69dc6735e8836c0a69460d076899c285db79a8b","author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"date":"2016-04-28 02:53:25.000000000","message":"Topic changed from bug/1484141 to vpnaas-devstack-plugin","accounts_in_message":[],"_revision_number":1},{"id":"7245bec114b721df71fcd83660fd01177fc0cb9e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-28 03:53:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-full/bd8819a/ : SUCCESS in 41m 57s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-postgres-full/74e5145/ : SUCCESS in 40m 37s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-neutron-full/45cb570/ : SUCCESS in 59m 50s\n- gate-devstack-bashate http://logs.openstack.org/42/310642/1/check/gate-devstack-bashate/de253e1/ : SUCCESS in 2m 26s\n- gate-devstack-unit-tests http://logs.openstack.org/42/310642/1/check/gate-devstack-unit-tests/31b8187/ : SUCCESS in 1m 41s\n- gate-grenade-dsvm-forward http://logs.openstack.org/42/310642/1/check/gate-grenade-dsvm-forward/38570e6/ : SUCCESS in 38m 31s (non-voting)\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-ironic-agent_ssh-nv/d1af459/ : FAILURE in 51m 09s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/42/310642/1/check/gate-swift-dsvm-functional-nv/37b7bfd/ : SUCCESS in 26m 56s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-multinode-full/514f80e/ : SUCCESS in 44m 29s (non-voting)\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-platform-centos7-nv/c66eae3/ : FAILURE in 8m 24s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/42/310642/1/check/gate-tempest-dsvm-platform-fedora23-nv/d6f479b/ : FAILURE in 7m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"10479bee169c1246b5c0623414fb04c521d9c79c","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-05-03 08:50:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b05a8138d811e7b04cda77755e08303765f8ff48","author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"date":"2016-05-06 12:50:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a6f463c979ac211be610966c4c60c90fece847a9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-05-09 14:54:58.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"eab32b049a1fbbf79574e2826e4e62a597ed51b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-09 14:56:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6b18cc7745c4cd23357c61c0d7fd7342730a57ae","date":"2016-05-09 16:35:59.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"b7cc411e02dfa74f27d44b53f08d84d3d02d27f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-09 16:35:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/42/310642/1/gate/gate-tempest-dsvm-full/a8dac1e/ : SUCCESS in 34m 56s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/42/310642/1/gate/gate-tempest-dsvm-postgres-full/5cbd39f/ : SUCCESS in 55m 04s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/42/310642/1/gate/gate-tempest-dsvm-neutron-full/43d83e1/ : SUCCESS in 1h 36m 51s\n- gate-devstack-bashate http://logs.openstack.org/42/310642/1/gate/gate-devstack-bashate/d12302c/ : SUCCESS in 2m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9bb7c3c4918ba1229078dc035a9311a414a72a33","revisions":{"9bb7c3c4918ba1229078dc035a9311a414a72a33":{"kind":"REWORK","_number":1,"created":"2016-04-28 02:53:09.000000000","uploader":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"ref":"refs/changes/42/310642/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/42/310642/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/42/310642/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/42/310642/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/42/310642/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/42/310642/1"}}},"commit":{"parents":[{"commit":"af5c5e656a2b0da4f23875d782ea8a91a3d5cd82","subject":"Force testresources\u003c2.0.0 outside of g-r","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/af5c5e656a2b0da4f23875d782ea8a91a3d5cd82"}]}],"author":{"name":"Paul Michali","email":"pc@michali.net","date":"2015-08-14 15:49:27.000000000","tz":-240},"committer":{"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","date":"2016-04-28 02:53:09.000000000","tz":0},"subject":"Prevent spawning two VPN agents","message":"Prevent spawning two VPN agents\n\nCurrently, if the VPN devstack plugin is enabled (which is\nthe method used for VPN in all test jobs), there will be\ntwo VPN agent processes started. This doesn\u0027t seem to\naffect the tests, but is incorrect.\n\nTo resolve this, the proposal is to do this in two steps.\nWith this commit, the script is modified to start the q-vpn\nprocess, if q-vpn is enabled (legacy), and to only start\nq-l3 process, if neither q-vpn nor neutron-vpnaas is enabled.\n\nOnce committed, the opertion will be the same - if no VPN\nservice is enabled, we get q-l3 (correct); if legacy q-vpn is\nenabled (only), we get q-vpn (correct); if the plugin is used\n(the default), we get two q-vpn processes started (wrong).\n\nWith a separate plugin commit (to be pushed next), the plugin\nwill be renamed to neutron-vpnaas, and then we\u0027ll get only\none agent process (q-vpn or neutron-vpnaas) runing. We can\u0027t\ncommit the plugin first, because both the VPN agent and the\nq-l3 agent will be started at once (just as bad, if not worse).\n\nChange-Id: I2bb7ac01e619c8a9b22bd517a4ff60d67035dfed\nPartial-Bug: 1484141\n(cherry picked from commit e4289c88c8007ae942a18a1786fc6fd36f2489c7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9bb7c3c4918ba1229078dc035a9311a414a72a33"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9bb7c3c4918ba1229078dc035a9311a414a72a33"}]},"branch":"refs/heads/stable/kilo"}},"requirements":[],"submit_records":[],"submit_requirements":[]}