)]}'
{"lib/glance":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6e9f582a6337d76da6aa79abe288e8b3acc8992b","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# CORS options support"},{"line_number":78,"context_line":"GLANCE_CORS_ALLOWED_ORIGIN\u003d${GLANCE_CORS_ALLOWED_ORIGIN:-\u003cNone\u003e}"},{"line_number":79,"context_line":"GLANCE_CORS_BASE_ALLOWED_HEADERS\u003d\"Content-MD5,X-Image-Meta-Checksum,X-Storage-Token,Accept-Encoding,X-Auth-Token,X-Identity-Status,X-Roles,X-Service-Catalog,X-User-Id,X-Tenant-Id,X-OpenStack-Request-ID\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Functions"},{"line_number":82,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bab6814e_257041dc","line":79,"updated":"2016-05-25 01:41:44.000000000","message":"This does not seem like the type of stuff that we should be setting in devstack.  Why would glance not have this as a default (or, why do we need to override the glance default)","commit_id":"14436c978eb2d29b3ef6e20ad2ae31ed25920bd1"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"de1abf61f274a2a99772468953e8b86617c099fe","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# CORS options support"},{"line_number":78,"context_line":"GLANCE_CORS_ALLOWED_ORIGIN\u003d${GLANCE_CORS_ALLOWED_ORIGIN:-\u003cNone\u003e}"},{"line_number":79,"context_line":"GLANCE_CORS_BASE_ALLOWED_HEADERS\u003d\"Content-MD5,X-Image-Meta-Checksum,X-Storage-Token,Accept-Encoding,X-Auth-Token,X-Identity-Status,X-Roles,X-Service-Catalog,X-User-Id,X-Tenant-Id,X-OpenStack-Request-ID\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Functions"},{"line_number":82,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9abb7d3a_d3e932b9","line":79,"in_reply_to":"bab6814e_257041dc","updated":"2016-06-03 12:53:19.000000000","message":"Indeed, on the second thought I realized that we don\u0027t need these headers modified, only allowed_origin","commit_id":"14436c978eb2d29b3ef6e20ad2ae31ed25920bd1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"75ad70844f79cb8c0e0c8bd0e0802a007e340a8f","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    iniset $GLANCE_API_CONF cors allowed_origin \"$GLANCE_CORS_ALLOWED_ORIGIN\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    # Store the images in swift if enabled."},{"line_number":152,"context_line":"    if is_service_enabled s-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7aa08908_71cebc84","line":149,"updated":"2016-06-06 02:10:14.000000000","message":"We should not be setting a default value that overrides the project defaults.\n\n[1] https://git.openstack.org/cgit/openstack/glance/tree/etc/glance-api.conf#n566","commit_id":"354becb842b66e3996f53c5ce8b11bcc16a19c5f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bee63e943841dbb2b3ee6c3b79a0750f43fb50a","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    iniset $GLANCE_API_CONF cors allowed_origin \"$GLANCE_CORS_ALLOWED_ORIGIN\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    # Store the images in swift if enabled."},{"line_number":152,"context_line":"    if is_service_enabled s-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7aa08908_afcfffae","line":149,"in_reply_to":"7aa08908_71cebc84","updated":"2016-06-06 13:48:26.000000000","message":"Done. Does the initialization from patchset#11 make sense?","commit_id":"354becb842b66e3996f53c5ce8b11bcc16a19c5f"}]}