)]}'
{"lib/rpc_backend":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1e16614eba1ddeba7b654170325c72a118df47b1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    local section\u003d${3:-DEFAULT}"},{"line_number":124,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":125,"context_line":"        iniset $file $section rpc_backend \"rabbit\""},{"line_number":126,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_hosts $RABBIT_HOST"},{"line_number":127,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_password $RABBIT_PASSWORD"},{"line_number":128,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_userid $RABBIT_USERID"},{"line_number":129,"context_line":"        if [ -n \"$RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bab6814e_28f658f9","line":126,"updated":"2016-05-25 01:54:18.000000000","message":"i guess the later value just overwrites this, but wouldn\u0027t it be clearer to just put one value in?","commit_id":"e6a089371dfc9e8102d20eb8f71cee6dcc52d5d9"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"0f6f90f97053e4b53f1945431a4a54b0275519dd","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    local section\u003d${3:-DEFAULT}"},{"line_number":124,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":125,"context_line":"        iniset $file $section rpc_backend \"rabbit\""},{"line_number":126,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_hosts $RABBIT_HOST"},{"line_number":127,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_password $RABBIT_PASSWORD"},{"line_number":128,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_userid $RABBIT_USERID"},{"line_number":129,"context_line":"        if [ -n \"$RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bab6814e_e31ab116","line":126,"in_reply_to":"bab6814e_28f658f9","updated":"2016-05-25 02:32:57.000000000","message":"I felt it would be clearer to stack the tls code together rather than wrapping a single line. I can experiment with that and see how it looks.","commit_id":"e6a089371dfc9e8102d20eb8f71cee6dcc52d5d9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fe8aba6847eb05984a6eb5ec42c810e1c7033c48","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    local section\u003d${3:-DEFAULT}"},{"line_number":124,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":125,"context_line":"        iniset $file $section rpc_backend \"rabbit\""},{"line_number":126,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_hosts $RABBIT_HOST"},{"line_number":127,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_password $RABBIT_PASSWORD"},{"line_number":128,"context_line":"        iniset $file oslo_messaging_rabbit rabbit_userid $RABBIT_USERID"},{"line_number":129,"context_line":"        if [ -n \"$RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bab6814e_ba872711","line":126,"in_reply_to":"bab6814e_e31ab116","updated":"2016-05-25 04:35:16.000000000","message":"I guess it\u0027s a matter of taste, but I feel like it\u0027s not uncommon to poke into config files, and they\u0027re available in the logs for inspection.  so doing the most human friendly thing (easy to miss things like later overwritten values) seems right","commit_id":"e6a089371dfc9e8102d20eb8f71cee6dcc52d5d9"}]}