)]}'
{"id":"openstack%2Fdevstack~311923","triplet_id":"openstack%2Fdevstack~master~I663078ba1d7338f31a252a30beb6ed073cad6d98","project":"openstack/devstack","branch":"master","topic":"bug/1577627","hashtags":[],"change_id":"I663078ba1d7338f31a252a30beb6ed073cad6d98","subject":"Fix function \"trueorfalse\" in functions-common and unittest.","status":"ABANDONED","created":"2016-05-03 03:16:13.000000000","updated":"2016-05-03 17:46:55.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c610d04a09ef2946628766120ab3050e7d3efde5","_number":311923,"virtual_id_number":311923,"owner":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"date":"2016-05-03 03:24:43.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2016-05-03 04:54:36.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-05-03 04:10:30.000000000","_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"date":"2016-05-03 09:18:12.000000000","_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"date":"2016-05-03 04:24:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":-1,"date":"2016-05-03 09:00:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-03 03:24:43.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-05-03 04:10:30.000000000","updated_by":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"reviewer":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"state":"REVIEWER"},{"updated":"2016-05-03 04:24:27.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-05-03 04:54:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-05-03 09:00:37.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-05-03 09:18:12.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"}],"messages":[{"id":"e23ef34f723523c1b0eb4c602c6348dd80ecd05f","author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"date":"2016-05-03 03:16:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"891f3522eef705a8c8b4194a83e4985ca5093b5d","author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"date":"2016-05-03 03:18:38.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6d07815b6a3a580a73c2e17b5275e2b15c3aef9d","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-05-03 03:24:43.000000000","message":"Patch Set 2:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/23/311923/2/13569/index.html : FAILURE in 05 m 01 s","accounts_in_message":[],"_revision_number":2},{"id":"431949411143a84abd052b703b78803ec03bb9e4","author":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"date":"2016-05-03 04:08:01.000000000","message":"Patch Set 1:\n\nBuild Successful.\n* networking-odl-vhostuser-ci http://intel-openstack-ci-logs.ovh/networking-odl-vhostuser-ci/refs/changes/23/311923/1 : SUCCESS\n\nTo re-run the job please post a comment with `recheck networking-odl-vhostuser-ci`","accounts_in_message":[],"_revision_number":1},{"id":"fdb6739fca4541580095c8a8454e2ee1858fb4b0","author":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"date":"2016-05-03 04:10:30.000000000","message":"Patch Set 2:\n\nBuild Successful.\n* networking-odl-vhostuser-ci http://intel-openstack-ci-logs.ovh/networking-odl-vhostuser-ci/refs/changes/23/311923/2 : SUCCESS\n\nTo re-run the job please post a comment with `recheck networking-odl-vhostuser-ci`","accounts_in_message":[],"_revision_number":2},{"id":"e370113038938a407e3f3c4622367d16dda0a8aa","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-05-03 04:24:27.000000000","message":"Patch Set 2:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm-recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/23/311923/2/check/check-ibm-tempest-dsvm-full/0b81bd9/ : SUCCESS in 1h 05m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c37270c991799f1672d1ab081b776eebb0d4fd28","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-03 04:54:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-full/6beb655/ : SUCCESS in 42m 29s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-postgres-full/396b7c3/ : SUCCESS in 42m 00s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-neutron-full/385d58d/ : SUCCESS in 1h 09m 02s\n- gate-grenade-dsvm http://logs.openstack.org/23/311923/2/check/gate-grenade-dsvm/9a08ef3/ : SUCCESS in 37m 36s\n- gate-devstack-docs http://docs-draft.openstack.org/23/311923/2/check/gate-devstack-docs/a952e16//doc/build/html/ : SUCCESS in 1m 57s\n- gate-devstack-bashate http://logs.openstack.org/23/311923/2/check/gate-devstack-bashate/9e643af/ : SUCCESS in 1m 40s\n- gate-devstack-unit-tests http://logs.openstack.org/23/311923/2/check/gate-devstack-unit-tests/b243185/ : SUCCESS in 2m 04s\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-ironic-agent_ssh-nv/26db47e/ : FAILURE in 14m 48s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/23/311923/2/check/gate-devstack-dsvm-updown/a9a8d82/ : SUCCESS in 21m 42s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/2adc4a2/ : SUCCESS in 57m 11s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/23/311923/2/check/gate-swift-dsvm-functional-nv/c08b2c8/ : SUCCESS in 26m 01s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/23/311923/2/check/gate-grenade-dsvm-neutron/40af8fd/ : SUCCESS in 39m 52s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-multinode-full/2850525/ : FAILURE in 1h 03m 05s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-neutron-multinode-full/0fd4cc3/ : UNSTABLE in 1h 33m 40s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/23/311923/2/check/gate-grenade-dsvm-multinode/ed9a8f1/ : SUCCESS in 45m 34s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-platform-centos7-nv/dba0ea9/ : SUCCESS in 47m 28s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/23/311923/2/check/gate-tempest-dsvm-platform-fedora23-nv/65948a3/ : SUCCESS in 58m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f5945533c342aca9b9ec577d60b471e0875e880e","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-05-03 09:00:37.000000000","message":"Patch Set 2: Code-Review-1\n\nPlease explain how you fixed this. \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":2},{"id":"f8863d47db478eecc5d08fd654ebcb277a7705d2","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-05-03 09:18:12.000000000","message":"Patch Set 2:\n\nAlso, I am pretty sure this patch is wrong.\n\nSee: http://unix.stackexchange.com/questions/41292/variable-substitution-with-an-exclamation-mark-in-bash","accounts_in_message":[],"_revision_number":2},{"id":"3cf11931f695878569a5b7fd40861c39ac334ead","author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"date":"2016-05-03 11:32:49.000000000","message":"Abandoned\n\nmy misunderstanding of trueorfalse function.","accounts_in_message":[],"_revision_number":2},{"id":"2c3f4e01fe8c236770d4c5044eb31e83b05fa92c","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-05-03 17:46:55.000000000","message":"Patch Set 2:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/23/311923/2/13673/index.html : SUCCESS in 01 h 28 m 48 s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e812db6f021db27fddb5a040e1a9309fa88b034e","revisions":{"faafc3620198fb435634f2158c0c2f3ccd0a85a2":{"kind":"REWORK","_number":1,"created":"2016-05-03 03:16:13.000000000","uploader":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"ref":"refs/changes/23/311923/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/23/311923/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/311923/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/311923/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/311923/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/23/311923/1"}}},"commit":{"parents":[{"commit":"13b3be10a754c0e0f9fb31ce824d5f2d9cc905de","subject":"Updated from generate-devstack-plugins-list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/13b3be10a754c0e0f9fb31ce824d5f2d9cc905de"}]}],"author":{"name":"yan.haifeng","email":"yanheven@qq.com","date":"2016-05-03 03:11:35.000000000","tz":480},"committer":{"name":"yan.haifeng","email":"yanheven@qq.com","date":"2016-05-03 03:13:01.000000000","tz":480},"subject":"Fix function \"trueorfalse\" in functions-common and unittese.","message":"Fix function \"trueorfalse\" in functions-common and unittese.\n\nChange-Id: I663078ba1d7338f31a252a30beb6ed073cad6d98\nCloses-Bug: #1577627\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/faafc3620198fb435634f2158c0c2f3ccd0a85a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/faafc3620198fb435634f2158c0c2f3ccd0a85a2"}]},"branch":"refs/heads/master"},"e812db6f021db27fddb5a040e1a9309fa88b034e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-05-03 03:18:38.000000000","uploader":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"ref":"refs/changes/23/311923/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/23/311923/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/311923/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/311923/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/311923/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/23/311923/2"}}},"commit":{"parents":[{"commit":"13b3be10a754c0e0f9fb31ce824d5f2d9cc905de","subject":"Updated from generate-devstack-plugins-list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/13b3be10a754c0e0f9fb31ce824d5f2d9cc905de"}]}],"author":{"name":"yan.haifeng","email":"yanheven@qq.com","date":"2016-05-03 03:11:35.000000000","tz":480},"committer":{"name":"yan.haifeng","email":"yanheven@qq.com","date":"2016-05-03 03:15:20.000000000","tz":480},"subject":"Fix function \"trueorfalse\" in functions-common and unittest.","message":"Fix function \"trueorfalse\" in functions-common and unittest.\n\nChange-Id: I663078ba1d7338f31a252a30beb6ed073cad6d98\nCloses-Bug: #1577627\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e812db6f021db27fddb5a040e1a9309fa88b034e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e812db6f021db27fddb5a040e1a9309fa88b034e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}