)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"a8b2fe5823ef15f489314675b3e64280c6f91940","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This will have devstack setup the Cinder internal tenant and generic"},{"line_number":10,"context_line":"image-volume cache by default. If left alone it will use reasonable"},{"line_number":11,"context_line":"defaults, but it would be highly recommended to set the"},{"line_number":12,"context_line":"CINDER_INTERNAL_TENANT_PASSWORD variable in localrc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More information about configuration options and the cache can be found"},{"line_number":15,"context_line":"here: http://docs.openstack.org/admin-guide/blockstorage_image_volume_cache.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7aa08908_b1cddabc","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"updated":"2016-06-15 07:22:23.000000000","message":"In my understanding, this is removed from current implementation (it just uses existing service container). Is it correct?","commit_id":"bd5663ed1973b1d5e795e21d5e66d39ae7e82e51"}],"lib/cinder":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"90ce8cf9a8f99583e5a0e2f5bc05b9a1f9675e72","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    for be in ${CINDER_CACHE_ENABLED_FOR_BACKENDS//,/ }; do"},{"line_number":619,"context_line":"        be_name\u003d${be##*:}"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        iniset $CINDER_CONF $be_name image_volume_cache_enabled $CINDER_IMG_CACHE_ENABLED"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        if [[ -n $CINDER_IMG_CACHE_SIZE_GB ]]; then"},{"line_number":624,"context_line":"            iniset $CINDER_CONF $be_name image_volume_cache_max_size_gb $CINDER_IMG_CACHE_SIZE_GB"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a122d0e_b3d57db8","line":621,"updated":"2016-05-04 17:34:52.000000000","message":"will this only work in setting up for a driver group name (re: multi-backend cinder.conf entry).\n\nWill this work in the case where there is only 1 backend setup in the [DEFAULT] group?","commit_id":"115c9931eb89db9d15519fd8285b8a9a6828fe9a"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"081dd7db29df2ee02f0d2801ccf88429e652c327","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    for be in ${CINDER_CACHE_ENABLED_FOR_BACKENDS//,/ }; do"},{"line_number":619,"context_line":"        be_name\u003d${be##*:}"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        iniset $CINDER_CONF $be_name image_volume_cache_enabled $CINDER_IMG_CACHE_ENABLED"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        if [[ -n $CINDER_IMG_CACHE_SIZE_GB ]]; then"},{"line_number":624,"context_line":"            iniset $CINDER_CONF $be_name image_volume_cache_max_size_gb $CINDER_IMG_CACHE_SIZE_GB"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a122d0e_442a61e8","line":621,"in_reply_to":"1a122d0e_b3d57db8","updated":"2016-05-04 18:33:25.000000000","message":"Nope, as far as I know if you don\u0027t use the CINDER_ENABLED_BACKENDS format it will not do it automatically. The default behavior for devstack though is to use that (see up on line 81). In theory you could just define CINDER_CACHE_ENABLED_FOR_BACKENDS\u003dDEFAULT:foo and it will stick it into the [DEFAULT] stanza of the config.\n\nRealistically though if anyone wants to use the image cache without the backend stanza they would need to add the settings manually in their local.conf\n\nNo reason we couldn\u0027t extend this to support that too, but it isn\u0027t really used in any of the jenkins stuff or what the ci systems are doing (someone correct me if I\u0027m wrong).","commit_id":"115c9931eb89db9d15519fd8285b8a9a6828fe9a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"47c4cf62ca7909237ff016972092c61d37516e65","unresolved":false,"context_lines":[{"line_number":600,"context_line":"function configure_cinder_internal_tenant {"},{"line_number":601,"context_line":"    # If either id is empty we will create a new project/username for the internal tenant"},{"line_number":602,"context_line":"    if [[ -z $CINDER_INTERNAL_TENANT_PROJECT_ID || -z $CINDER_INTERNAL_TENANT_USER_ID ]]; then"},{"line_number":603,"context_line":"        export CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        export CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"},{"line_number":606,"context_line":"        admin_role\u003d$(get_or_create_role \"admin\")"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bab6814e_45d105cd","line":603,"updated":"2016-05-25 01:37:55.000000000","message":"why are you exporting these?","commit_id":"a2e60392cf5809f939bef2774c8b6ecd6c4075a5"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"e907a461b3380f0f2b7296cd525585659b5623fc","unresolved":false,"context_lines":[{"line_number":600,"context_line":"function configure_cinder_internal_tenant {"},{"line_number":601,"context_line":"    # If either id is empty we will create a new project/username for the internal tenant"},{"line_number":602,"context_line":"    if [[ -z $CINDER_INTERNAL_TENANT_PROJECT_ID || -z $CINDER_INTERNAL_TENANT_USER_ID ]]; then"},{"line_number":603,"context_line":"        export CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        export CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"},{"line_number":606,"context_line":"        admin_role\u003d$(get_or_create_role \"admin\")"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bab6814e_b4b9fd17","line":603,"in_reply_to":"bab6814e_45d105cd","updated":"2016-05-25 03:54:23.000000000","message":"Uhh... good question. We don\u0027t need to, updated in latest patchset.","commit_id":"a2e60392cf5809f939bef2774c8b6ecd6c4075a5"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"cdc94365c89bf88ba23233a49f8c33b3a430ce7d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":71,"context_line":"# Defaults to default, which is thick, the other valid choice"},{"line_number":72,"context_line":"# is thin, which as the name implies utilizes lvm thin provisioning."},{"line_number":73,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-default}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Default backends"},{"line_number":76,"context_line":"# The backend format is type:name where type is one of the supported backend"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_736f72fc","line":73,"range":{"start_line":73,"start_character":42,"end_line":73,"end_character":43},"updated":"2016-06-13 02:46:49.000000000","message":"I think this should be \"thin\" or \"auto\" to enable lvm thin-provisioning for copy-on-write cloning so that image cache works effectively.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"139934e18a289378f1a004eb6bc78289570bdc0a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":71,"context_line":"# Defaults to default, which is thick, the other valid choice"},{"line_number":72,"context_line":"# is thin, which as the name implies utilizes lvm thin provisioning."},{"line_number":73,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-default}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Default backends"},{"line_number":76,"context_line":"# The backend format is type:name where type is one of the supported backend"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_fd130c63","line":73,"range":{"start_line":73,"start_character":42,"end_line":73,"end_character":43},"in_reply_to":"7aa08908_736f72fc","updated":"2016-06-13 19:15:21.000000000","message":"Yea I can add that in as part of this.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b1e09a89a2c1f40da31bf6ff4dfa171c3e894e23","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Variables to configure the Cinder internal tenant, if either id\u0027s are left empty"},{"line_number":139,"context_line":"# they will be automatically created."},{"line_number":140,"context_line":"CINDER_INTERNAL_TENANT_PROJECT_ID\u003d${CINDER_INTERNAL_TENANT_PROJECT_ID:-}"},{"line_number":141,"context_line":"CINDER_INTERNAL_TENANT_USER_ID\u003d${CINDER_INTERNAL_TENANT_USER_ID:-}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"CINDER_INTERNAL_TENANT_PROJECTNAME\u003d${CINDER_INTERNAL_TENANT_PROJECTNAME:-\u0027cinder-internal-tenant\u0027}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9abb7d3a_76f4415a","line":140,"updated":"2016-06-01 12:09:42.000000000","message":"Why do we need this variables? projects/tenants are created during stack.sh. We can\u0027t precreate a project before launching stack.sh and set ID to local.conf.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"139934e18a289378f1a004eb6bc78289570bdc0a","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Variables to configure the Cinder internal tenant, if either id\u0027s are left empty"},{"line_number":139,"context_line":"# they will be automatically created."},{"line_number":140,"context_line":"CINDER_INTERNAL_TENANT_PROJECT_ID\u003d${CINDER_INTERNAL_TENANT_PROJECT_ID:-}"},{"line_number":141,"context_line":"CINDER_INTERNAL_TENANT_USER_ID\u003d${CINDER_INTERNAL_TENANT_USER_ID:-}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"CINDER_INTERNAL_TENANT_PROJECTNAME\u003d${CINDER_INTERNAL_TENANT_PROJECTNAME:-\u0027cinder-internal-tenant\u0027}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_3d0ab426","line":140,"in_reply_to":"9abb7d3a_76f4415a","updated":"2016-06-13 19:15:21.000000000","message":"Good point, they are remnants of other stuff and we don\u0027t really need them. I\u0027ll take them out.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7f158502ac4b5c1ad9d6bc31fb062d7d7069f399","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"function configure_cinder_internal_tenant {"},{"line_number":601,"context_line":"    # If either id is empty we will create a new project/username for the internal tenant"},{"line_number":602,"context_line":"    if [[ -z $CINDER_INTERNAL_TENANT_PROJECT_ID || -z $CINDER_INTERNAL_TENANT_USER_ID ]]; then"},{"line_number":603,"context_line":"        CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9abb7d3a_f1ae802c","line":602,"updated":"2016-06-01 11:07:16.000000000","message":"I think it would be best to reuse Cinder service account. There\u0027s already a lot (too many ?) \"service\" users/accounts in Keystone.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"139934e18a289378f1a004eb6bc78289570bdc0a","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"function configure_cinder_internal_tenant {"},{"line_number":601,"context_line":"    # If either id is empty we will create a new project/username for the internal tenant"},{"line_number":602,"context_line":"    if [[ -z $CINDER_INTERNAL_TENANT_PROJECT_ID || -z $CINDER_INTERNAL_TENANT_USER_ID ]]; then"},{"line_number":603,"context_line":"        CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_9d03e80f","line":602,"in_reply_to":"9abb7d3a_f1ae802c","updated":"2016-06-13 19:15:21.000000000","message":"Will do.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b1e09a89a2c1f40da31bf6ff4dfa171c3e894e23","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    if [[ -z $CINDER_INTERNAL_TENANT_PROJECT_ID || -z $CINDER_INTERNAL_TENANT_USER_ID ]]; then"},{"line_number":603,"context_line":"        CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"},{"line_number":606,"context_line":"        admin_role\u003d$(get_or_create_role \"admin\")"},{"line_number":607,"context_line":"        get_or_add_user_project_role $admin_role $CINDER_INTERNAL_TENANT_USER_ID $CINDER_INTERNAL_TENANT_PROJECT_ID"},{"line_number":608,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9abb7d3a_d6340d4b","line":605,"updated":"2016-06-01 12:09:42.000000000","message":"I think we should die if any of CINDER_INTERNAL_TENANT_PROJECT_ID or  CINDER_INTERNAL_TENANT_USER_ID is not set.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"139934e18a289378f1a004eb6bc78289570bdc0a","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    if [[ -z $CINDER_INTERNAL_TENANT_PROJECT_ID || -z $CINDER_INTERNAL_TENANT_USER_ID ]]; then"},{"line_number":603,"context_line":"        CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"},{"line_number":606,"context_line":"        admin_role\u003d$(get_or_create_role \"admin\")"},{"line_number":607,"context_line":"        get_or_add_user_project_role $admin_role $CINDER_INTERNAL_TENANT_USER_ID $CINDER_INTERNAL_TENANT_PROJECT_ID"},{"line_number":608,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_b8a072f5","line":605,"in_reply_to":"9abb7d3a_d6340d4b","updated":"2016-06-13 19:15:21.000000000","message":"I\u0027ll take this part out, if we always use the cinder service account this shouldn\u0027t ever happen.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7f158502ac4b5c1ad9d6bc31fb062d7d7069f399","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"},{"line_number":606,"context_line":"        admin_role\u003d$(get_or_create_role \"admin\")"},{"line_number":607,"context_line":"        get_or_add_user_project_role $admin_role $CINDER_INTERNAL_TENANT_USER_ID $CINDER_INTERNAL_TENANT_PROJECT_ID"},{"line_number":608,"context_line":"    fi"},{"line_number":609,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9abb7d3a_cc08032b","line":606,"updated":"2016-06-01 11:07:16.000000000","message":"This it really requires the admin role ?","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"139934e18a289378f1a004eb6bc78289570bdc0a","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        CINDER_INTERNAL_TENANT_PROJECT_ID\u003d$(get_or_create_project \"$CINDER_INTERNAL_TENANT_PROJECTNAME\" default)"},{"line_number":604,"context_line":"        CINDER_INTERNAL_TENANT_USER_ID\u003d$(get_or_create_user \"$CINDER_INTERNAL_TENANT_USERNAME\" \"$CINDER_INTERNAL_TENANT_PASSWORD\" default)"},{"line_number":605,"context_line":"        local admin_role"},{"line_number":606,"context_line":"        admin_role\u003d$(get_or_create_role \"admin\")"},{"line_number":607,"context_line":"        get_or_add_user_project_role $admin_role $CINDER_INTERNAL_TENANT_USER_ID $CINDER_INTERNAL_TENANT_PROJECT_ID"},{"line_number":608,"context_line":"    fi"},{"line_number":609,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_58b06e43","line":606,"in_reply_to":"9abb7d3a_cc08032b","updated":"2016-06-13 19:15:21.000000000","message":"No, not really. This will be removed if we use the cinder service account so no worries there.","commit_id":"f5eecf8056b15c69946ebe90839410c9baadcf16"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e978ab83e8ffcaa532b74e2af0d8e14bd60eaff3","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    # similar to CINDER_ENABLED_BACKENDS with NAME:TYPE where NAME will"},{"line_number":598,"context_line":"    # be the backend specific configuration stanza in cinder.conf."},{"line_number":599,"context_line":"    for be in ${CINDER_CACHE_ENABLED_FOR_BACKENDS//,/ }; do"},{"line_number":600,"context_line":"        be_name\u003d${be##*:}"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        iniset $CINDER_CONF $be_name image_volume_cache_enabled $CINDER_IMG_CACHE_ENABLED"},{"line_number":603,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aa08908_626f2c2b","line":600,"updated":"2016-06-14 23:52:57.000000000","message":"make local","commit_id":"e2068078c689edfd2bdbdb6fcfb0f373a4aa1ae2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"79256cfdffdf57abc638813363b3f569ae7bba89","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    # similar to CINDER_ENABLED_BACKENDS with NAME:TYPE where NAME will"},{"line_number":598,"context_line":"    # be the backend specific configuration stanza in cinder.conf."},{"line_number":599,"context_line":"    for be in ${CINDER_CACHE_ENABLED_FOR_BACKENDS//,/ }; do"},{"line_number":600,"context_line":"        be_name\u003d${be##*:}"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        iniset $CINDER_CONF $be_name image_volume_cache_enabled $CINDER_IMG_CACHE_ENABLED"},{"line_number":603,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aa08908_a2a8f420","line":600,"in_reply_to":"7aa08908_626f2c2b","updated":"2016-06-14 23:59:08.000000000","message":"Done","commit_id":"e2068078c689edfd2bdbdb6fcfb0f373a4aa1ae2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e978ab83e8ffcaa532b74e2af0d8e14bd60eaff3","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            iniset $CINDER_CONF $be_name image_volume_cache_max_size_gb $CINDER_IMG_CACHE_SIZE_GB"},{"line_number":606,"context_line":"        fi"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        if [[ -n $CINDER_IMG_CACHE_SIZE_GB ]]; then"},{"line_number":609,"context_line":"            iniset $CINDER_CONF $be_name image_volume_cache_max_count $CINDER_IMG_CACHE_SIZE_COUNT"},{"line_number":610,"context_line":"        fi"},{"line_number":611,"context_line":"    done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aa08908_a27594fa","line":608,"updated":"2016-06-14 23:52:57.000000000","message":"shouldn\u0027t this be CINDER_IMG_CACHE_SIZE_COUNT?","commit_id":"e2068078c689edfd2bdbdb6fcfb0f373a4aa1ae2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"79256cfdffdf57abc638813363b3f569ae7bba89","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            iniset $CINDER_CONF $be_name image_volume_cache_max_size_gb $CINDER_IMG_CACHE_SIZE_GB"},{"line_number":606,"context_line":"        fi"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        if [[ -n $CINDER_IMG_CACHE_SIZE_GB ]]; then"},{"line_number":609,"context_line":"            iniset $CINDER_CONF $be_name image_volume_cache_max_count $CINDER_IMG_CACHE_SIZE_COUNT"},{"line_number":610,"context_line":"        fi"},{"line_number":611,"context_line":"    done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7aa08908_c2670023","line":608,"in_reply_to":"7aa08908_a27594fa","updated":"2016-06-14 23:59:08.000000000","message":"Yep.","commit_id":"e2068078c689edfd2bdbdb6fcfb0f373a4aa1ae2"}]}