)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e64d6408dfe2937be726fb02736493f468698032","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# e.g.  _configure_neutron_l3_agent or lib/neutron_plugins/*"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# The plugin supports L3."},{"line_number":30,"context_line":"Q_L3_ENABLED\u003d${Q_L3_ENABLED:-True}"},{"line_number":31,"context_line":"# L3 routers exist per tenant"},{"line_number":32,"context_line":"Q_L3_ROUTER_PER_TENANT\u003d${Q_L3_ROUTER_PER_TENANT:-True}"},{"line_number":33,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_d8846e0c","line":30,"updated":"2016-05-16 11:43:11.000000000","message":"Reverting will break networking-ovn, because this was False by default before the neutron lib refactor.  Can we change this default back to false?","commit_id":"e3684e1a3cf056fc047d07f7bedea963db27d93e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"76fae9052bdf6da96215e2e3dc804e410839d820","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# e.g.  _configure_neutron_l3_agent or lib/neutron_plugins/*"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# The plugin supports L3."},{"line_number":30,"context_line":"Q_L3_ENABLED\u003d${Q_L3_ENABLED:-True}"},{"line_number":31,"context_line":"# L3 routers exist per tenant"},{"line_number":32,"context_line":"Q_L3_ROUTER_PER_TENANT\u003d${Q_L3_ROUTER_PER_TENANT:-True}"},{"line_number":33,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_5146994f","line":30,"in_reply_to":"dab17558_38b2da94","updated":"2016-05-16 12:25:22.000000000","message":"It was false here: https://review.openstack.org/#/c/168438/57/lib/neutron-legacy","commit_id":"e3684e1a3cf056fc047d07f7bedea963db27d93e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"fec129c53ac30bfb1b76d3715abb5f9e5d19a6cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# e.g.  _configure_neutron_l3_agent or lib/neutron_plugins/*"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# The plugin supports L3."},{"line_number":30,"context_line":"Q_L3_ENABLED\u003d${Q_L3_ENABLED:-True}"},{"line_number":31,"context_line":"# L3 routers exist per tenant"},{"line_number":32,"context_line":"Q_L3_ROUTER_PER_TENANT\u003d${Q_L3_ROUTER_PER_TENANT:-True}"},{"line_number":33,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_1dd38005","line":30,"in_reply_to":"dab17558_5146994f","updated":"2016-05-16 13:38:26.000000000","message":"i agree the default should be False.\ni\u0027m not sure if it should be a part of this patch or not though.","commit_id":"e3684e1a3cf056fc047d07f7bedea963db27d93e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e533b483815fb1df3da4be01708d0b2fedc6c63f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# e.g.  _configure_neutron_l3_agent or lib/neutron_plugins/*"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# The plugin supports L3."},{"line_number":30,"context_line":"Q_L3_ENABLED\u003d${Q_L3_ENABLED:-True}"},{"line_number":31,"context_line":"# L3 routers exist per tenant"},{"line_number":32,"context_line":"Q_L3_ROUTER_PER_TENANT\u003d${Q_L3_ROUTER_PER_TENANT:-True}"},{"line_number":33,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_38b2da94","line":30,"in_reply_to":"dab17558_d8846e0c","updated":"2016-05-16 11:52:19.000000000","message":"The default was always True. This si something that each plugin can configure in their local.conf. So it is 6 of one and half a dozen of the other","commit_id":"e3684e1a3cf056fc047d07f7bedea963db27d93e"}],"lib/tempest":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"48417eee6fc44d80607c6fd1f669c4a91b2d37af","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    ssh_connect_method\u003d${TEMPEST_SSH_CONNECT_METHOD:-$ssh_connect_method}"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":242,"context_line":"        public_network_id\u003d$(neutron net-list | grep $PUBLIC_NETWORK_NAME | \\"},{"line_number":243,"context_line":"            awk \u0027{print $2}\u0027)"},{"line_number":244,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_91f62a8d","side":"PARENT","line":241,"updated":"2016-05-16 18:54:24.000000000","message":"The patch under revert assumed that Q_L3_ENABLED and L3 agent enabled were the same thing when in reality there were not. So in reality we need to assume that \u0027is_service_enabled q-l3\u0027 means something new, which is: \u0027Your Neutron solution provides L3, whichever way you see fit with or without agents\u0027. \n\nThis means that perhaps the plugin must bring its own is_service_enabled function definition [1]. That said, we\u0027d need to ensure that the in-tree devstack logic does not go and try to execute the l3 agent when it hits is_service_enabled q-l3\u003d\u003dTrue. Assumed that coupling has been solved, it might not be necessary to revert this, but if not, then it\u0027s safer to revert, break the coupling (which could take a little) and then come back here and kill the extra knob.\n\n\n[1] https://github.com/openstack-dev/devstack/blob/master/functions-common#L2057","commit_id":"d894221457efa3a2a0bf3db76a4c5e8ffba36e29"}]}