)]}'
{"id":"openstack%2Fdevstack~316660","triplet_id":"openstack%2Fdevstack~master~Ia74a4884c3b8ff54028b9b257ea4d39fc0cfac89","project":"openstack/devstack","branch":"master","topic":"315995","hashtags":[],"change_id":"Ia74a4884c3b8ff54028b9b257ea4d39fc0cfac89","subject":"Revert \"Replace Q_L3_ENABLED by is_service_enabled q-l3\"","status":"ABANDONED","created":"2016-05-16 08:45:11.000000000","updated":"2016-06-06 10:43:59.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"52de5e5b3daf2c42c7bf8d75f42ce6f6623f76df","_number":316660,"virtual_id_number":316660,"owner":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-05-18 16:23:54.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-05-16 13:33:10.000000000","_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"date":"2016-05-16 09:50:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2016-05-18 11:02:49.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"date":"2016-05-16 18:54:24.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"date":"2016-05-16 09:57:17.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2016-05-16 09:45:42.000000000","_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"date":"2016-05-16 11:43:11.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2016-05-18 01:01:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"value":-2,"date":"2016-05-16 16:35:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":2,"date":"2016-05-16 11:23:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2016-05-16 11:30:35.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2016-05-16 15:46:43.000000000","_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"date":"2016-05-16 11:30:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"date":"2016-05-16 11:31:24.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-16 09:45:42.000000000","updated_by":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"reviewer":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"state":"REVIEWER"},{"updated":"2016-05-16 09:50:16.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-05-16 09:57:17.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-05-16 11:23:43.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2016-05-16 11:30:35.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-05-16 11:30:41.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-05-16 11:31:24.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-05-16 11:43:11.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-05-16 15:46:43.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2016-05-16 16:35:07.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-05-16 18:54:24.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2016-05-18 01:01:33.000000000","updated_by":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"reviewer":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"state":"REVIEWER"},{"updated":"2016-05-18 11:02:49.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-05-18 16:23:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"40063da16009b0d2cf8302bf41cbc8ec7941d6e5","author":{"_account_id":20084,"name":"Intel networking-odl CI","email":"intel-odl-ci@intel.com","username":"intel-networking-odl-ci"},"date":"2016-05-16 09:45:42.000000000","message":"Patch Set 1:\n\nBuild Failed.\n* networking-odl-vhostuser-ci http://intel-openstack-ci-logs.ovh/networking-odl-vhostuser-ci/refs/changes/60/316660/1 : FAILURE\n\nTo re-run the job please post a comment with `recheck networking-odl-vhostuser-ci`","accounts_in_message":[],"_revision_number":1},{"id":"f3bd5e4a8e6f4b08d6becfd25147ba85021a07c6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-05-16 09:50:16.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm-recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/60/316660/1/check/check-ibm-tempest-dsvm-full/1639457/ : SUCCESS in 1h 04m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7c0fc0f899aa59a27a889864b882c0596163af47","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-05-16 09:57:17.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/60/316660/1/15214/index.html : SUCCESS in 01 h 09 m 57 s","accounts_in_message":[],"_revision_number":1},{"id":"5c9ab7b2730663e3a6e01d5ad94182dbcf0e04d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-16 10:27:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-full/5e7ef39/ : SUCCESS in 47m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-postgres-full/ed15cd1/ : SUCCESS in 36m 51s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-neutron-full/0f39ad0/ : SUCCESS in 1h 06m 52s\n- gate-grenade-dsvm http://logs.openstack.org/60/316660/1/check/gate-grenade-dsvm/506616e/ : SUCCESS in 24m 50s\n- gate-devstack-docs http://docs-draft.openstack.org/60/316660/1/check/gate-devstack-docs/ac96e44//doc/build/html/ : SUCCESS in 1m 21s\n- gate-devstack-bashate http://logs.openstack.org/60/316660/1/check/gate-devstack-bashate/468e666/ : SUCCESS in 1m 34s\n- gate-devstack-unit-tests http://logs.openstack.org/60/316660/1/check/gate-devstack-unit-tests/950306e/ : SUCCESS in 2m 24s\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-ironic-agent_ssh-nv/27b0fc5/ : SUCCESS in 30m 32s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/60/316660/1/check/gate-devstack-dsvm-updown/247f275/ : SUCCESS in 12m 29s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/3e6450a/ : SUCCESS in 50m 18s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/60/316660/1/check/gate-swift-dsvm-functional-nv/16045a8/ : SUCCESS in 27m 25s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/60/316660/1/check/gate-grenade-dsvm-neutron/4c72477/ : SUCCESS in 39m 55s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-multinode-full/affb2ce/ : SUCCESS in 56m 06s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-neutron-multinode-full/7057f97/ : FAILURE in 1h 34m 21s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/60/316660/1/check/gate-grenade-dsvm-multinode/4788758/ : SUCCESS in 47m 09s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-platform-centos7-nv/85d2a9c/ : SUCCESS in 56m 05s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/60/316660/1/check/gate-tempest-dsvm-platform-fedora23-nv/866d00d/ : FAILURE in 2m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"82339b93b908869cd3d977c080027087f691b7aa","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2016-05-16 11:23:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e64d6408dfe2937be726fb02736493f468698032","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-16 11:43:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e533b483815fb1df3da4be01708d0b2fedc6c63f","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2016-05-16 11:52:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"76fae9052bdf6da96215e2e3dc804e410839d820","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-16 12:25:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0b4c83548a3cf5419d187e789e7a09ac31021114","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-05-16 13:21:04.000000000","message":"Patch Set 1: Code-Review-1\n\nLet\u0027s find another way to express this then. We already have a couple hooks for things like security group\n\nhttps://github.com/openstack-dev/devstack/blob/master/lib/neutron_plugins/ml2#L135\n\nSo let\u0027s make a new hook for if a plugin has l3 services.\n\nThis is why Q_L3_ENABLED was unhelpful - it had tons of meaning to different people.","accounts_in_message":[],"_revision_number":1},{"id":"e4f20dbcffcf1f0816e8cb3775ec01fa7f2c21d2","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-05-16 13:33:10.000000000","message":"Patch Set 1:\n\n\u003e This is why Q_L3_ENABLED was unhelpful - it had tons of meaning to different people.\n\ncan you explain?  i\u0027m only aware of a single meaning.","accounts_in_message":[],"_revision_number":1},{"id":"fec129c53ac30bfb1b76d3715abb5f9e5d19a6cf","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-05-16 13:38:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f4ccc092a98289b1350a877df2fe0774527571b2","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-05-16 16:35:07.000000000","message":"Patch Set 1: Code-Review-2\n\nI think at this point, I\u0027d rather break third party CI systems and force them to do the L3 configuration and setup in their own plugins, rather than try and keep this whole rat\u0027s nest going.","accounts_in_message":[],"_revision_number":1},{"id":"9bd32d87d6a159ccd72a09207bc846ea37282b1e","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-05-16 16:41:11.000000000","message":"Patch Set 1:\n\nSean,\n\ncan you please explain why you think \"a new hook\" would be better than Q_L3_ENABLED?","accounts_in_message":[],"_revision_number":1},{"id":"48417eee6fc44d80607c6fd1f669c4a91b2d37af","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-05-16 18:54:24.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nnot sure that letting plugins bring their own is_service_enabled q-l3 definition (in override-defaults) suffices to make devstack stop running the agent, but if so then we should be good.","accounts_in_message":[],"_revision_number":1},{"id":"3507eb01338b8fbaedf95295a06816ef9f7cde40","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-05-17 15:52:31.000000000","message":"Patch Set 1:\n\nSean,\n\ni still believe it\u0027s best to revert the change.\n\nFYI, here\u0027s an alternative copy-and-paste solution for midonet; https://review.openstack.org/#/c/316992/\ni don\u0027t really like it though.","accounts_in_message":[],"_revision_number":1},{"id":"8224655eacd0516fcf44b4aed98bbde4e84eaf4c","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2016-05-18 01:01:33.000000000","message":"Patch Set 1: Code-Review+1\n\nOur plugin CI is also broken due to the said change.\nI agree with Armando, devstack should be ready for decoupling before introducing breaking changes to third party plugins that relies on devstack.","accounts_in_message":[],"_revision_number":1},{"id":"50d540c45fca77a79a026ca047acf6f93fabcfa1","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-05-18 11:02:49.000000000","message":"Patch Set 1:\n\nwe are moving to \u0027neutron-*\u0027 as service names.\nI don\u0027t think it is a good idea to change what neutron-legacy does.\nCan\u0027t we keep the meaning of q-l3 and Q_L3_ENALBED and defining the meanings of neutron-* more clearly?","accounts_in_message":[],"_revision_number":1},{"id":"5a1ede1d9a6e2a8fe90d75131274e839cdfbfb4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-18 16:23:54.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"d0c105cf2c5d28e551e340df5f286b6f877314b7","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-06-06 10:43:59.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e3684e1a3cf056fc047d07f7bedea963db27d93e","revisions":{"e3684e1a3cf056fc047d07f7bedea963db27d93e":{"kind":"REWORK","_number":1,"created":"2016-05-16 08:45:11.000000000","uploader":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"ref":"refs/changes/60/316660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/60/316660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/60/316660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/60/316660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/60/316660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/60/316660/1"}}},"commit":{"parents":[{"commit":"d894221457efa3a2a0bf3db76a4c5e8ffba36e29","subject":"Replace Q_L3_ENABLED by is_service_enabled q-l3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d894221457efa3a2a0bf3db76a4c5e8ffba36e29"}]}],"author":{"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","date":"2016-05-16 08:45:11.000000000","tz":0},"committer":{"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","date":"2016-05-16 08:45:11.000000000","tz":0},"subject":"Revert \"Replace Q_L3_ENABLED by is_service_enabled q-l3\"","message":"Revert \"Replace Q_L3_ENABLED by is_service_enabled q-l3\"\n\nThis reverts commit d894221457efa3a2a0bf3db76a4c5e8ffba36e29.\n\nThe change broke networking-midonet, which uses neutron-legacy.\n\nActually, Q_L3_ENABLED\u003dTrue and is_service_enabled q-l3 have\nquite different meaning.\nThe former means the plugin provides L3 functionalities.\nThe latter means Neutron L3 agent is enabled.\nMidoNet provides L3 functionalities without using Neutron L3 agent.\n\nChange-Id: Ia74a4884c3b8ff54028b9b257ea4d39fc0cfac89\nCloses-Bug: #1582119\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e3684e1a3cf056fc047d07f7bedea963db27d93e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e3684e1a3cf056fc047d07f7bedea963db27d93e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}