)]}'
{"lib/nova":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d57eefb7cbdcdef527789e021181e7370c7cbaa4","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":640,"context_line":"        cp $NOVA_CONF $NOVA_CELLS_CONF"},{"line_number":641,"context_line":"        iniset $NOVA_CELLS_CONF database connection `database_connection_url $NOVA_CELLS_DB`"},{"line_number":642,"context_line":"        iniset $NOVA_CELLS_CONF DEFAULT transport_url \"$(get_transport_url)child_cell\""},{"line_number":643,"context_line":"        iniset $NOVA_CELLS_CONF DEFAULT dhcpbridge_flagfile $NOVA_CELLS_CONF"},{"line_number":644,"context_line":"        iniset $NOVA_CELLS_CONF cells enable True"},{"line_number":645,"context_line":"        iniset $NOVA_CELLS_CONF cells cell_type compute"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9abb7d3a_edd0e955","line":642,"updated":"2016-05-30 01:21:33.000000000","message":"I think this should be using iniset_rpc_backend $NOVA_CELLS_CONF, as the idea here is to be abstracted from the rabbitmq implementation","commit_id":"63b96f5a92e4955cff1672d74a41251658b9a83f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c7ef4fbddaa9f26edc43ad7ddfd004437e5c1337","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":640,"context_line":"        cp $NOVA_CONF $NOVA_CELLS_CONF"},{"line_number":641,"context_line":"        iniset $NOVA_CELLS_CONF database connection `database_connection_url $NOVA_CELLS_DB`"},{"line_number":642,"context_line":"        iniset $NOVA_CELLS_CONF DEFAULT transport_url \"$(get_transport_url)child_cell\""},{"line_number":643,"context_line":"        iniset $NOVA_CELLS_CONF DEFAULT dhcpbridge_flagfile $NOVA_CELLS_CONF"},{"line_number":644,"context_line":"        iniset $NOVA_CELLS_CONF cells enable True"},{"line_number":645,"context_line":"        iniset $NOVA_CELLS_CONF cells cell_type compute"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9abb7d3a_915fc674","line":642,"in_reply_to":"9abb7d3a_edd0e955","updated":"2016-06-02 22:50:05.000000000","message":"I think that requires addition of a \u0027virtual_host\u0027 argument to iniset_rpc_backend and get_transport_url. Virtual host is not implementation-specific [1]. Is that what you had in mind?\n\n[1] https://github.com/openstack/oslo.messaging/blob/acb398e/oslo_messaging/transport.py#L231-L233","commit_id":"63b96f5a92e4955cff1672d74a41251658b9a83f"}],"lib/rpc_backend":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81bde89b614b30c9a4c243d4513f331a462fbbf3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"function get_transport_url {"},{"line_number":107,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":108,"context_line":"        echo \"rabbit://$RABBIT_USERID:$RABBIT_PASSWORD@$RABBIT_HOST:5672/\""},{"line_number":109,"context_line":"    fi"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# iniset configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bab6814e_43b9fd78","line":109,"updated":"2016-05-25 02:46:36.000000000","message":"I think this function can be leveraged to set the transport_url config option and reuse some code","commit_id":"c1a2af636cae4ed145b76be818561b5de1dcb893"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c7e328259a7339d6f417082d6423ad1b61b16ecd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"function get_transport_url {"},{"line_number":107,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":108,"context_line":"        echo \"rabbit://$RABBIT_USERID:$RABBIT_PASSWORD@$RABBIT_HOST:5672/\""},{"line_number":109,"context_line":"    fi"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# iniset configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bab6814e_ef236856","line":109,"in_reply_to":"bab6814e_43b9fd78","updated":"2016-05-26 09:36:54.000000000","message":"Done","commit_id":"c1a2af636cae4ed145b76be818561b5de1dcb893"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81bde89b614b30c9a4c243d4513f331a462fbbf3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    local file\u003d$2"},{"line_number":116,"context_line":"    local section\u003d${3:-DEFAULT}"},{"line_number":117,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":118,"context_line":"        iniset $file $section transport_url \"rabbit://$RABBIT_USERID:$RABBIT_PASSWORD@$RABBIT_HOST:5672/\""},{"line_number":119,"context_line":"        if [ -n \"$RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD\" ]; then"},{"line_number":120,"context_line":"            iniset $file oslo_messaging_rabbit heartbeat_timeout_threshold $RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD"},{"line_number":121,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bab6814e_838485b1","line":118,"range":{"start_line":118,"start_character":21,"end_line":118,"end_character":29},"updated":"2016-05-25 02:46:36.000000000","message":"I think this has to be DEFAULT because that\u0027s the only section \"transport_url\" can be in. Or is it configurable?","commit_id":"c1a2af636cae4ed145b76be818561b5de1dcb893"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"817a0c30d2199bf84a209e681109027464db7b84","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    local file\u003d$2"},{"line_number":116,"context_line":"    local section\u003d${3:-DEFAULT}"},{"line_number":117,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":118,"context_line":"        iniset $file $section transport_url \"rabbit://$RABBIT_USERID:$RABBIT_PASSWORD@$RABBIT_HOST:5672/\""},{"line_number":119,"context_line":"        if [ -n \"$RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD\" ]; then"},{"line_number":120,"context_line":"            iniset $file oslo_messaging_rabbit heartbeat_timeout_threshold $RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD"},{"line_number":121,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bab6814e_43ef0887","line":118,"range":{"start_line":118,"start_character":21,"end_line":118,"end_character":29},"in_reply_to":"bab6814e_838485b1","updated":"2016-05-25 20:04:35.000000000","message":"It looks like transport_url can be in DEFAULT or in oslo_messaging_notifications, though it means something different in oslo_messaging_notifications.","commit_id":"c1a2af636cae4ed145b76be818561b5de1dcb893"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d57eefb7cbdcdef527789e021181e7370c7cbaa4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    local file\u003d$2"},{"line_number":116,"context_line":"    local section\u003d${3:-DEFAULT}"},{"line_number":117,"context_line":"    if is_service_enabled rabbit || { [ -n \"$RABBIT_HOST\" ] \u0026\u0026 [ -n \"$RABBIT_PASSWORD\" ]; }; then"},{"line_number":118,"context_line":"        iniset $file $section transport_url $(get_transport_url)"},{"line_number":119,"context_line":"        if [ -n \"$RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD\" ]; then"},{"line_number":120,"context_line":"            iniset $file oslo_messaging_rabbit heartbeat_timeout_threshold $RABBIT_HEARTBEAT_TIMEOUT_THRESHOLD"},{"line_number":121,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9abb7d3a_8dbafd08","line":118,"updated":"2016-05-30 01:21:33.000000000","message":"i think this is fine, but I\u0027d like to see get_transport_url renamed to _get_transport_url I think, because it seems the intent is that you setup the rpc_backend with this so that if someone wants to use another rpc type, they can override this fn.","commit_id":"63b96f5a92e4955cff1672d74a41251658b9a83f"}]}