)]}'
{"id":"openstack%2Fdevstack~31876","triplet_id":"openstack%2Fdevstack~master~I000c3cba107cd91bef11c4d5325e1ce7308faa6c","project":"openstack/devstack","branch":"master","topic":"fakeVirt","hashtags":[],"change_id":"I000c3cba107cd91bef11c4d5325e1ce7308faa6c","subject":"Add Fake virt driver support","status":"MERGED","created":"2013-06-05 22:34:08.000000000","updated":"2013-06-06 21:40:47.000000000","submitted":"2013-06-06 21:40:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5f9b57c9487e08ede0eb08d3ab7e2b364bb8f23f","_number":31876,"virtual_id_number":31876,"owner":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2013-06-06 21:40:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":2,"date":"2013-06-06 19:32:05.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-06-06 18:16:11.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2013-06-06 20:07:12.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"date":"2013-06-06 18:01:22.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"date":"2013-06-06 17:08:41.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-06-06 20:07:12.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-06 18:01:22.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2013-06-06 18:16:11.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2013-06-06 20:07:12.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-06-06 21:40:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"26a9b9afc5dd7d9e1483ffad2a6f31a3ae29f36a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 23:24:08.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31876/1/check/gate-tempest-devstack-vm-full/20904 : SUCCESS in 44m 05s\n- http://logs.openstack.org/31876/1/check/gate-tempest-devstack-vm-postgres-full/20611 : SUCCESS in 48m 39s (non-voting)\n- http://logs.openstack.org/31876/1/check/gate-tempest-devstack-vm-quantum/27981 : SUCCESS in 18m 20s\n- http://logs.openstack.org/31876/1/check/gate-grenade-devstack-vm/8249 : SUCCESS in 14m 22s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"9b9d0e5b26e818e563bb238ac9365fc7b2b54e7e","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-06-06 17:08:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2ce5ebe80329f684c923730f2e4f3a71ebb98c7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 17:54:27.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31876/2/check/gate-tempest-devstack-vm-full/21127 : SUCCESS in 43m 38s\n- http://logs.openstack.org/31876/2/check/gate-tempest-devstack-vm-postgres-full/20834 : SUCCESS in 45m 30s (non-voting)\n- http://logs.openstack.org/31876/2/check/gate-tempest-devstack-vm-quantum/28215 : SUCCESS in 19m 12s\n- http://logs.openstack.org/31876/2/check/gate-grenade-devstack-vm/8447 : SUCCESS in 13m 42s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"b8815f7ce9d7f8c2dc73c8ac116645b1b3c024c7","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-06-06 18:01:22.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nseems like it would be good to disable rate limiting as well when using the fake driver, so you don\u0027t get locked out from using the api by the daily post limit on servers for example.","accounts_in_message":[],"_revision_number":2},{"id":"208397491d508e5600670e9299fce22be15e7b20","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2013-06-06 18:16:11.000000000","message":"Patch Set 2:\n\nI like the idea of being able to disable the limits, and I see why it makes sense to do it for the fake driver, but logically \"turn off all limits\" feels like a different configuration setting from the virt driver.\n\nWhat do you think about adding a separate option to disable the limits that\u0027s independent of the driver, and either requiring users to specify it explicitly or setting it automatically when the fake driver is used?","accounts_in_message":[],"_revision_number":2},{"id":"48b7786390405fc70e6d8753566cf43dee0b8fc4","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-06-06 18:49:57.000000000","message":"Patch Set 2:\n\nDoug, we already have that option:\n\n# if you don\u0027t set this you may hit API rate limitting during testing\nAPI_RATE_LIMIT\u003dFalse","accounts_in_message":[],"_revision_number":2},{"id":"9ddb093ba089961d8f6899c75514927a71738660","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-06-06 19:32:05.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nfair enough i guess it is fine as a separate option","accounts_in_message":[],"_revision_number":2},{"id":"8695f1e3a29d53a46c5db88e1d6bdaee0ec7e32a","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-06-06 20:07:12.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nI think there is a use case for testing API rate limiting with the fake driver, so I\u0027m happy with these 2 things as separate.","accounts_in_message":[],"_revision_number":2},{"id":"29850da5e5c650504201e8b56ef490fce9464e2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 20:07:15.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2d7b709f57633eefe420a5d7ee2cbb3a8a3ffbb4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 21:40:46.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/31876/2/gate/gate-tempest-devstack-vm-full/21242 : SUCCESS in 47m 42s\n- http://logs.openstack.org/31876/2/gate/gate-tempest-devstack-vm-postgres-full/20949 : FAILURE in 2s (non-voting)\n- http://logs.openstack.org/31876/2/gate/gate-tempest-devstack-vm-quantum/28341 : SUCCESS in 29m 00s\n- http://logs.openstack.org/31876/2/gate/gate-grenade-devstack-vm/8536 : SUCCESS in 19m 40s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"ddb90a7e8fdf201dded42e8fd86951497aa17ca3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 21:40:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"baf37ea81720982050eceea2b1b1e9bbdf6f0c94","revisions":{"232577f691462a1b989fcd71678bf8e6842562ad":{"kind":"REWORK","_number":1,"created":"2013-06-05 22:34:08.000000000","uploader":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"ref":"refs/changes/76/31876/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/76/31876/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/76/31876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/76/31876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/76/31876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/76/31876/1"}}},"commit":{"parents":[{"commit":"eff14644b0d5f06550a3cabac380beb3e71cf084","subject":"Merge \"Cleanup openrc.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/eff14644b0d5f06550a3cabac380beb3e71cf084"}]}],"author":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2013-06-05 22:18:44.000000000","tz":-420},"committer":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2013-06-05 22:23:19.000000000","tz":-420},"subject":"Add Fake virt driver support","message":"Add Fake virt driver support\n\nnova fake virt driver can be used to simulate running arbitrarily large\nnumber of VMs.  When the fake virt driver is selected, all other arbitrary\nlimits are disabled (quotas, scheduler limitations) as well. The fake\nvirt driver can be selected by adding the following line to your localrc\n\n      VIRT_DRIVER\u003dfake\n\nThis setting can be used to do simulated large scale (as defined by\nnumber of VMs) testing (such as boot 500 VMs at once) inside a single\ndevstack instance.\n\nChange-Id: I000c3cba107cd91bef11c4d5325e1ce7308faa6c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/232577f691462a1b989fcd71678bf8e6842562ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/232577f691462a1b989fcd71678bf8e6842562ad"}]},"branch":"refs/heads/master"},"baf37ea81720982050eceea2b1b1e9bbdf6f0c94":{"kind":"REWORK","_number":2,"created":"2013-06-06 17:08:41.000000000","uploader":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"ref":"refs/changes/76/31876/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/76/31876/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/76/31876/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/76/31876/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/76/31876/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/76/31876/2"}}},"commit":{"parents":[{"commit":"eff14644b0d5f06550a3cabac380beb3e71cf084","subject":"Merge \"Cleanup openrc.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/eff14644b0d5f06550a3cabac380beb3e71cf084"}]}],"author":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2013-06-05 22:18:44.000000000","tz":-420},"committer":{"name":"Joe Gordon","email":"joe.gordon0@gmail.com","date":"2013-06-06 17:08:01.000000000","tz":-420},"subject":"Add Fake virt driver support","message":"Add Fake virt driver support\n\nnova fake virt driver can be used to simulate running arbitrarily large\nnumber of VMs.  When the fake virt driver is selected, all other arbitrary\nlimits are disabled (quotas, scheduler limitations) as well. The fake\nvirt driver can be selected by adding the following line to your localrc\n\n      VIRT_DRIVER\u003dfake\n\nThis setting can be used to do simulated large scale (as defined by\nnumber of VMs) testing (such as boot 500 VMs at once) inside a single\ndevstack instance.\n\nChange-Id: I000c3cba107cd91bef11c4d5325e1ce7308faa6c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/baf37ea81720982050eceea2b1b1e9bbdf6f0c94"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/baf37ea81720982050eceea2b1b1e9bbdf6f0c94"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}