)]}'
{"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"700bc78eec2f6ecf9fd10084d114b9c991ef743d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            # source file paths, not relative paths. This screws with the matching"},{"line_number":109,"context_line":"            # of \u00271:libvirt\u0027 making everything turn on. So use libvirt.c for now."},{"line_number":110,"context_line":"            # This will have to be re-visited when Ubuntu ships libvirt \u003e\u003d 1.2.3"},{"line_number":111,"context_line":"            local log_filters\u003d\"1:libvirt.c 1:qemu 1:conf 1:security 3:object 3:event 3:json 3:file 1:util 1:cpu\""},{"line_number":112,"context_line":"        else"},{"line_number":113,"context_line":"            local log_filters\u003d\"1:libvirt 1:qemu 1:conf 1:security 3:object 3:event 3:json 3:file 1:util 1:cpu\""},{"line_number":114,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9abb7d3a_f952cb11","line":111,"updated":"2016-06-01 18:40:23.000000000","message":"Wonder if this Ubuntu-specific check can be avoided, now that Ubuntu Xenial ships libvirt 1.3.1?\n\nI just did two tests on Ubuntu Xenial machine: one with filter \"1:libvirt\", and the other with \"1:libvirt.c\" in libvirtd.conf. After each modification: (a) clear up the libvirtd.log; (b) restart \u0027libvirt-bin\u0027 service (c) make a copy of the libvirtd.log.  Then compare the two libvirtd logs to see what\u0027s the difference.  \n\nThe difference I noticed was, with the case of \"1:libvirt\", I see log messages from various functions (virSetSharedStorageDriver, virSetSharedNodeDeviceDriver, virSetSharedSecretDriver, etc; and a few other calls from from libvirt.c source file. However, in the special case (\"1:libvirt.c\"), I don\u0027t see these same log messages.\n\n[Tested on Ubuntu Xenial with libvirt-bin \u00271.3.1-1ubuntu10\u0027 version.]\n\nlibvirt debug log with \"1: libvirt\" filter:\n\n    https://kashyapc.fedorapeople.org/temp/libvirt-filter-ubuntu-libv-1.3.1.log\n\nlibvirt debug log with \"1: libvirt.c\"\n\n    https://kashyapc.fedorapeople.org/temp/libvirt.c-filter-ubuntu-libv-1.3.1.log\n\n\nFrom the above, it seems that using \"1:libvirt\" still seems to log slightly more than \"1:libvirt.c\" filter.","commit_id":"08e1cbf0b648b40c5a3910649daf7d5f3aa4c4f3"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8a2dd5a261da4dc55544ddb7381203a43ae453d6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            # source file paths, not relative paths. This screws with the matching"},{"line_number":109,"context_line":"            # of \u00271:libvirt\u0027 making everything turn on. So use libvirt.c for now."},{"line_number":110,"context_line":"            # This will have to be re-visited when Ubuntu ships libvirt \u003e\u003d 1.2.3"},{"line_number":111,"context_line":"            local log_filters\u003d\"1:libvirt.c 1:qemu 1:conf 1:security 3:object 3:event 3:json 3:file 1:util 1:cpu\""},{"line_number":112,"context_line":"        else"},{"line_number":113,"context_line":"            local log_filters\u003d\"1:libvirt 1:qemu 1:conf 1:security 3:object 3:event 3:json 3:file 1:util 1:cpu\""},{"line_number":114,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9abb7d3a_75950e87","line":111,"in_reply_to":"9abb7d3a_f952cb11","updated":"2016-06-02 13:27:45.000000000","message":"Responding to my own question above:\n\nSean Dague on IRC points out that DevStack master still supports Ubuntu Trusty, which ships with libvirt 1.2.2.  So, probably we have to retain the Ubuntu-specific check until libvirt version is \u003e\u003d1.2.3.","commit_id":"08e1cbf0b648b40c5a3910649daf7d5f3aa4c4f3"}]}