)]}'
{"stack.sh":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5ed78544a6f77b6bd3259e5bf4d8dd66cd793dc8","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    install_database"},{"line_number":582,"context_line":"fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"if is_service_enabled q-agt q-dhcp q-l3; then"},{"line_number":585,"context_line":"    install_quantum_agent_packages"},{"line_number":586,"context_line":"fi"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAPX%2F%2Fr8I%3D","line":584,"updated":"2013-06-12 19:44:37.000000000","message":"Might as well add also add q-lbaas","commit_id":"876e66b9a6b5fdb114c537c20d32a6e2bdb65156"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b1754005c69ffed1ee1baf96db12a1cddbaa359f","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    install_database"},{"line_number":582,"context_line":"fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"if is_service_enabled q-agt q-dhcp q-l3; then"},{"line_number":585,"context_line":"    install_quantum_agent_packages"},{"line_number":586,"context_line":"fi"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAPX%2F%2Fmqg%3D","line":584,"in_reply_to":"AAAAPX%2F%2FmvQ%3D","updated":"2013-06-14 15:12:20.000000000","message":"will do.","commit_id":"876e66b9a6b5fdb114c537c20d32a6e2bdb65156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"514efc55c5dab058fac1e2180db3fa2daf7f6de2","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    install_database"},{"line_number":582,"context_line":"fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"if is_service_enabled q-agt q-dhcp q-l3; then"},{"line_number":585,"context_line":"    install_quantum_agent_packages"},{"line_number":586,"context_line":"fi"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAPX%2F%2FmvQ%3D","line":584,"in_reply_to":"AAAAPX%2F%2Fp2c%3D","updated":"2013-06-14 14:55:16.000000000","message":"I agree with Akihiro, at this point it is probably cleaner to just check for quantum in stack.sh and handle the individual services inside install_quantum_agent_packages().","commit_id":"876e66b9a6b5fdb114c537c20d32a6e2bdb65156"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5831158d829bdb1cde7c8c852448da2712856c41","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    install_database"},{"line_number":582,"context_line":"fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"if is_service_enabled q-agt q-dhcp q-l3; then"},{"line_number":585,"context_line":"    install_quantum_agent_packages"},{"line_number":586,"context_line":"fi"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAPX%2F%2Fp2c%3D","line":584,"in_reply_to":"AAAAPX%2F%2Fr6k%3D","updated":"2013-06-13 12:26:16.000000000","message":"How about changing the condition above to \"if is_service_enabled quantum\" and moving the condition into install_quantum_agent_packages().\n\nWhen we refactored quantum related code, the basic policy is to avoid adding quantum specific code in stack.sh. If we add q-dhcp, q-l3, q-lbaas here, we may need to change the condition if new services is added in the future.","commit_id":"876e66b9a6b5fdb114c537c20d32a6e2bdb65156"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"78751ff725dca36ae398ae67dde456c4fe28a8c3","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    install_database"},{"line_number":582,"context_line":"fi"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"if is_service_enabled q-agt q-dhcp q-l3; then"},{"line_number":585,"context_line":"    install_quantum_agent_packages"},{"line_number":586,"context_line":"fi"},{"line_number":587,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAPX%2F%2Fr6k%3D","line":584,"in_reply_to":"AAAAPX%2F%2Fr8I%3D","updated":"2013-06-12 22:20:25.000000000","message":"don\u0027t know much about it, are you sure it relies on the same packages for the other agents?","commit_id":"876e66b9a6b5fdb114c537c20d32a6e2bdb65156"}]}