)]}'
{"lib/neutron_plugins/ml2":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cc0b825f95f8146e0e08106065509e294e16fb33","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    Q_PLUGIN_CONF_PATH\u003detc/neutron/plugins/ml2"},{"line_number":59,"context_line":"    Q_PLUGIN_CONF_FILENAME\u003dml2_conf.ini"},{"line_number":60,"context_line":"    Q_PLUGIN_CLASS\u003d\"neutron.plugins.ml2.plugin.Ml2Plugin\""},{"line_number":61,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":62,"context_line":"        # The ML2 plugin delegates L3 routing/NAT functionality to"},{"line_number":63,"context_line":"        # the L3 service plugin which must therefore be specified,"},{"line_number":64,"context_line":"        # when L3 service is enabled."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_9c4491b7","line":61,"updated":"2016-06-08 06:22:52.000000000","message":"this is wrong because q-l3 is about l3 agent and ML2_L3_PLUGIN is about plugin side.\nmany of l3 plugins don\u0027t use l3 agent.\n\nhow about allowing ML2_L3_PLUGIN being empty to indicate no l3 plugin?","commit_id":"93d7a1fc60183e128c48856d0f4ce9dda6e06336"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f1ce6e3dab382498a5ced4e3e7dcd880d244d307","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    Q_PLUGIN_CONF_PATH\u003detc/neutron/plugins/ml2"},{"line_number":59,"context_line":"    Q_PLUGIN_CONF_FILENAME\u003dml2_conf.ini"},{"line_number":60,"context_line":"    Q_PLUGIN_CLASS\u003d\"neutron.plugins.ml2.plugin.Ml2Plugin\""},{"line_number":61,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":62,"context_line":"        # The ML2 plugin delegates L3 routing/NAT functionality to"},{"line_number":63,"context_line":"        # the L3 service plugin which must therefore be specified,"},{"line_number":64,"context_line":"        # when L3 service is enabled."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_b7740636","line":61,"in_reply_to":"7aa08908_17719aa8","updated":"2016-06-08 06:49:17.000000000","message":"i suggest to change \":-\" to \":\" in L41, so that it distinguishes empty and unset.","commit_id":"93d7a1fc60183e128c48856d0f4ce9dda6e06336"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"b8cb2f940f6d83af60da508a219d5ab25fe45309","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    Q_PLUGIN_CONF_PATH\u003detc/neutron/plugins/ml2"},{"line_number":59,"context_line":"    Q_PLUGIN_CONF_FILENAME\u003dml2_conf.ini"},{"line_number":60,"context_line":"    Q_PLUGIN_CLASS\u003d\"neutron.plugins.ml2.plugin.Ml2Plugin\""},{"line_number":61,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":62,"context_line":"        # The ML2 plugin delegates L3 routing/NAT functionality to"},{"line_number":63,"context_line":"        # the L3 service plugin which must therefore be specified,"},{"line_number":64,"context_line":"        # when L3 service is enabled."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_9fd6404d","line":61,"in_reply_to":"7aa08908_2ccd6885","updated":"2016-06-08 07:43:38.000000000","message":"Done","commit_id":"93d7a1fc60183e128c48856d0f4ce9dda6e06336"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"4ca46bc8281b41e85fd222b3e97543b07d02469a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    Q_PLUGIN_CONF_PATH\u003detc/neutron/plugins/ml2"},{"line_number":59,"context_line":"    Q_PLUGIN_CONF_FILENAME\u003dml2_conf.ini"},{"line_number":60,"context_line":"    Q_PLUGIN_CLASS\u003d\"neutron.plugins.ml2.plugin.Ml2Plugin\""},{"line_number":61,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":62,"context_line":"        # The ML2 plugin delegates L3 routing/NAT functionality to"},{"line_number":63,"context_line":"        # the L3 service plugin which must therefore be specified,"},{"line_number":64,"context_line":"        # when L3 service is enabled."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_17719aa8","line":61,"in_reply_to":"7aa08908_9c4491b7","updated":"2016-06-08 06:40:42.000000000","message":"Hello, @YAMAMOTO Takashi\nThank you for the review.\nI get your point.\nSo do you mean I can remove the default value in L41, and if other l3 plugins want to set L3RouterPlugin into ML2_L3_PLUGIN, they can do it themselves, please?","commit_id":"93d7a1fc60183e128c48856d0f4ce9dda6e06336"},{"author":{"_account_id":14039,"name":"watanabe isao","email":"watanabe.isao.openstack@gmail.com","username":"watanabe.isao"},"change_message_id":"a628b80b14ca8b7bd3948325ba9e9702ddb81bda","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    Q_PLUGIN_CONF_PATH\u003detc/neutron/plugins/ml2"},{"line_number":59,"context_line":"    Q_PLUGIN_CONF_FILENAME\u003dml2_conf.ini"},{"line_number":60,"context_line":"    Q_PLUGIN_CLASS\u003d\"neutron.plugins.ml2.plugin.Ml2Plugin\""},{"line_number":61,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":62,"context_line":"        # The ML2 plugin delegates L3 routing/NAT functionality to"},{"line_number":63,"context_line":"        # the L3 service plugin which must therefore be specified,"},{"line_number":64,"context_line":"        # when L3 service is enabled."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_e95a32f1","line":61,"in_reply_to":"7aa08908_b7740636","updated":"2016-06-08 07:24:03.000000000","message":"Sir, when I simply remove the \"-\", a syntax error occurred.","commit_id":"93d7a1fc60183e128c48856d0f4ce9dda6e06336"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ef2f0d0e14869f7afda64a404146968e3a8c0a91","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    Q_PLUGIN_CONF_PATH\u003detc/neutron/plugins/ml2"},{"line_number":59,"context_line":"    Q_PLUGIN_CONF_FILENAME\u003dml2_conf.ini"},{"line_number":60,"context_line":"    Q_PLUGIN_CLASS\u003d\"neutron.plugins.ml2.plugin.Ml2Plugin\""},{"line_number":61,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":62,"context_line":"        # The ML2 plugin delegates L3 routing/NAT functionality to"},{"line_number":63,"context_line":"        # the L3 service plugin which must therefore be specified,"},{"line_number":64,"context_line":"        # when L3 service is enabled."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_2ccd6885","line":61,"in_reply_to":"7aa08908_e95a32f1","updated":"2016-06-08 07:29:09.000000000","message":"oops, i meant replace \":-\" with \"-\".","commit_id":"93d7a1fc60183e128c48856d0f4ce9dda6e06336"}]}