)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e2e4163da46ba1c3e067b147ddea8663826b7110","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bob Ball \u003cbob.ball@citrix.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-17 13:03:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create the /images directory used by the resize functionality."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I13b39dbf5537ad45160c1af4cc10bd867b7f89c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2Fz%2FQ%3D","line":7,"updated":"2013-06-20 16:32:10.000000000","message":"I think this needs a little more context, and line might be too long. I would mention xenapi too, but I don\u0027t feel that strongly about it.","commit_id":"fc00317c9dcdbd47671793937b5367f78a7ce0c2"}],"tools/xen/functions":[{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"78705033a7e2deddfae4e7f6b862b7b38acd5717","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function create_directory_for_images {"},{"line_number":28,"context_line":"    if [ -d \"/images\" ]; then"},{"line_number":29,"context_line":"        echo \"INFO: /images directory already exists, using that\" \u003e\u00262"},{"line_number":30,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"AAAAPn%2F%2F9YM%3D","line":27,"updated":"2013-06-17 12:23:43.000000000","message":"We could extract a fuction, and use that for both kernels and images.","commit_id":"fc00317c9dcdbd47671793937b5367f78a7ce0c2"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"ddcd8dfc947fdde122440da24dc8c86ea2739792","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function create_directory_for_images {"},{"line_number":28,"context_line":"    if [ -d \"/images\" ]; then"},{"line_number":29,"context_line":"        echo \"INFO: /images directory already exists, using that\" \u003e\u00262"},{"line_number":30,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"AAAAPn%2F%2F9Wc%3D","line":27,"in_reply_to":"AAAAPn%2F%2F9W8%3D","updated":"2013-06-17 12:40:33.000000000","message":"yes, that makes sense","commit_id":"fc00317c9dcdbd47671793937b5367f78a7ce0c2"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"99a10dc371564a76445cbe0f3586b284cf7adc87","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function create_directory_for_images {"},{"line_number":28,"context_line":"    if [ -d \"/images\" ]; then"},{"line_number":29,"context_line":"        echo \"INFO: /images directory already exists, using that\" \u003e\u00262"},{"line_number":30,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"AAAAPn%2F%2F9W8%3D","line":27,"in_reply_to":"AAAAPn%2F%2F9YM%3D","updated":"2013-06-17 12:34:18.000000000","message":"I thought about that, but the behavior is \"create directory and create symlink\" - while we could have a generic function for this, it still seems quite a specific set of functionality to these two cases\n\nI thought about create_sr_directory, but that doesn\u0027t deal with it creating symlinks or create_utility_directory but it\u0027s a bit weird to specify two names for the directory (maybe we could generate the SR path from the real path...)\n\nit just seemed like there wasn\u0027t an easy fit for a generic function - particularly where we want to reduce the usage of it to use directories directly on the SR.","commit_id":"fc00317c9dcdbd47671793937b5367f78a7ce0c2"}]}