)]}'
{"id":"openstack%2Fdevstack~333155","triplet_id":"openstack%2Fdevstack~master~I265538ef9e9925ee64477ae127fd050e6133d578","project":"openstack/devstack","branch":"master","topic":"bug/1595225","hashtags":[],"change_id":"I265538ef9e9925ee64477ae127fd050e6133d578","subject":"Setsid to fix \"old\" screen_it--screen_stop chain","status":"ABANDONED","created":"2016-06-23 07:53:40.000000000","updated":"2017-10-20 08:46:46.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4f62546d1ad9582fc9cc0ba0df46d8ebf2d58f53","_number":333155,"virtual_id_number":333155,"owner":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-06-23 09:04:32.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2017-09-07 13:49:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"date":"2016-06-23 08:56:28.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2016-06-23 09:02:31.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"date":"2017-10-20 08:46:42.000000000","_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"date":"2016-06-23 14:20:11.000000000","_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-23 08:30:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":2,"date":"2017-01-05 14:18:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"date":"2016-07-18 12:16:25.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2016-07-18 12:15:46.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"date":"2016-06-28 14:02:07.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-23 08:30:31.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2016-06-23 08:56:28.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-06-23 09:02:31.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-06-23 09:04:32.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-06-23 14:20:11.000000000","updated_by":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"reviewer":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"state":"REVIEWER"},{"updated":"2016-06-28 14:02:07.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-07-18 12:15:46.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2016-07-18 12:16:25.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-01-05 14:18:36.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2017-09-07 13:49:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"13a8df10b1862a1601a21347bf1a43413aabf4cd","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2016-06-23 07:53:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c84c0573585703aebc9ce94b7bdb2a9eb0a2e5a7","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2016-06-23 08:30:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ad94028c78669c4da3e128ed4c94b101efe416bf","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-06-23 08:56:28.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/55/333155/1/check/check-ibm-tempest-dsvm-full/aa44544/ : SUCCESS in 1h 02m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7849811e6c4fc232f20d11f6f75e4a0f99ac6839","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-06-23 09:02:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-odl http://intel-openstack-ci-logs.ovh/55/333155/1/check/tempest-dsvm-ovsdpdk-odl/204715a : FAILURE in 1h 08m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7f48df46d054b092ea7e00f788a5e7035baafbe6","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-06-23 09:04:32.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/55/333155/1/21008/index.html : SUCCESS in 01 h 08 m 16 s","accounts_in_message":[],"_revision_number":1},{"id":"2daea665c8c59362f4926822e9bc3f6096be1dfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-23 09:08:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-full/c3ef405/ : SUCCESS in 48m 24s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-postgres-full/79f4e90/ : SUCCESS in 45m 54s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-neutron-full/def9339/ : SUCCESS in 1h 00m 54s\n- gate-grenade-dsvm http://logs.openstack.org/55/333155/1/check/gate-grenade-dsvm/513bafa/ : SUCCESS in 41m 12s\n- gate-devstack-docs http://docs-draft.openstack.org/55/333155/1/check/gate-devstack-docs/258aabf//doc/build/html/ : SUCCESS in 3m 57s\n- gate-devstack-bashate http://logs.openstack.org/55/333155/1/check/gate-devstack-bashate/31be09e/ : SUCCESS in 2m 46s\n- gate-devstack-unit-tests http://logs.openstack.org/55/333155/1/check/gate-devstack-unit-tests/90172e4/ : SUCCESS in 3m 23s\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-ironic-agent_ssh-nv/ee65df4/ : SUCCESS in 36m 44s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/55/333155/1/check/gate-devstack-dsvm-updown/71d6546/ : SUCCESS in 25m 52s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/5d92739/ : SUCCESS in 1h 12m 37s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/55/333155/1/check/gate-swift-dsvm-functional-nv/d12f9c7/ : SUCCESS in 27m 50s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/55/333155/1/check/gate-grenade-dsvm-neutron/73bf08b/ : SUCCESS in 51m 48s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-multinode-full/54e5f5e/ : FAILURE in 1h 00m 35s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-neutron-multinode-full/ae9ad5e/ : SUCCESS in 1h 10m 50s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/55/333155/1/check/gate-grenade-dsvm-multinode/033a5ad/ : SUCCESS in 42m 47s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/55/333155/1/check/gate-grenade-dsvm-neutron-multinode/dc856a6/ : SUCCESS in 53m 43s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-platform-centos7-nv/19511cd/ : SUCCESS in 43m 42s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/55/333155/1/check/gate-tempest-dsvm-platform-fedora23-nv/d67559e/ : SUCCESS in 58m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f8e7d582063ad4e61561d5d8b2909468044680e0","author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"date":"2016-06-23 14:20:11.000000000","message":"Patch Set 1:\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"da106bb35b266bd3e73895f91dafdd573d2d4a04","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2016-06-23 15:35:43.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nHey guys!\n\nThanks for the review!\nMiles, I tried to answer your question, I\u0027m not sure I succeeded.\nLet\u0027s chat about it on IRC maybe?\n\nCheers,\nmilan","accounts_in_message":[],"_revision_number":1},{"id":"f706ba2a9d428e31d96cf300a8ce25c0cfb78bc4","author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"date":"2016-06-23 16:22:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e4ba170c15fb0422de6a932f50ca775f668421e3","author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"date":"2016-06-23 16:23:06.000000000","message":"Patch Set 1:\n\nMilan, looks like I missed you for the day - sorry! Is what I\u0027ve written correct?","accounts_in_message":[],"_revision_number":1},{"id":"996e4b7a65cfd5bc2ad30e5b47c6844eb15c9e17","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2016-06-24 07:49:00.000000000","message":"Patch Set 1:\n\nHey Miles,\n\nyeah, it\u0027s as you write. \n\n\u003e 5. So { exec setsid bash -c $command } \u0026 ensures that \"bash -c $command\" and its descendants form a process group, and that their pgid is stored in $!, achieving 1.\nI\u0027d just say pgid of $! (although it\u0027s the same integer value as $!)\n\nCheers,\nmilan","accounts_in_message":[],"_revision_number":1},{"id":"55d53ed419e1c379ec670b370c37e62f1d20ef88","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-01-05 14:18:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ba7ee6bce887bfa6e5136cb95249bfccf8d0bb18","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-07 13:49:45.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"d8c6d670ac67712d2a6a82fea831a69f46835e33","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2017-10-20 08:46:42.000000000","message":"Patch Set 1:\n\nGuys,\n\nthanks for the reviews but I guess nobody needs this anymore\n\n--\nmilan","accounts_in_message":[],"_revision_number":1},{"id":"cc62f558879365effe21b3b7b09ca557169e2b8c","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2017-10-20 08:46:46.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"33e05294258ab6e60488f31eb84967e25283585a","revisions":{"33e05294258ab6e60488f31eb84967e25283585a":{"kind":"REWORK","_number":1,"created":"2016-06-23 07:53:40.000000000","uploader":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"ref":"refs/changes/55/333155/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/55/333155/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/333155/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/333155/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/55/333155/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/55/333155/1"}}},"commit":{"parents":[{"commit":"66f4524cf491db78caaa93eca848ad897a2e6576","subject":"Updated from generate-devstack-plugins-list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/66f4524cf491db78caaa93eca848ad897a2e6576"}]}],"author":{"name":"dparalen","email":"vetrisko@gmail.com","date":"2016-06-22 22:43:22.000000000","tz":120},"committer":{"name":"dparalen","email":"vetrisko@gmail.com","date":"2016-06-23 07:53:53.000000000","tz":120},"subject":"Setsid to fix \"old\" screen_it--screen_stop chain","message":"Setsid to fix \"old\" screen_it--screen_stop chain\n\nfunctions-common:screen_it utilizes _old_run_process in case of a\nnon-screen environment such as grenade testing.  However this call-chain\nfails to store correct PID/PGID in order for a service to be stopped by\nscreen_stop later on.  The issue boils down to following (simplified) code:\n\n    function _old_run_process() {\n        local command\u003d$2\n        exec /bin/bash -c \"$command\"\n    }\n\n    _old_run_process service-name \"cd workdir \u0026\u0026 \\\n                                   ./service --config service.conf\" \u0026\n    echo $! \u003e state/service.pid\n\nThe issue is two-fold. The pid of the sub-shell is being saved instead of\nthe service \"$command\" pid.  The screen_stop chain uses pkill -g (-F)\nstate/service.pid to terminate the whole service process group.\n\nSince pid of the subshell is saved instead of the pgid of the service,\npkill -g fails with exit code 1 (target not found).  If a correct pgid was\nsaved instead (echo `ps -opgid\u003d $!` \u003e state/service.pid), due to pgid\nimplicit inheritance the pkill command would have killed the whole grenade\nprocess group.\n\nSuggested change utilizes setsid to generate new pgid (and sid) of the\nservice instead:\n\n    function _old_run_process() {\n        local command\u003d$2\n        exec setsid /bin/bash -c \"$command\"\n    }\n\n    _old_run_process service-name \"cd workdir \u0026\u0026 \\\n                                   ./service --config service.conf\" \u0026\n    echo $! \u003e state/service.pid\n\nBecause exec is used here, setsid isn\u0027t forked as a separate process but\nrather replaces subshell process instance while maintaining all\nredirection.  Setsid uses its pid to create new pgid and sid of a\n\"$command\" that ist\u0027s going to exec, again, without forking.  Since that\npid is stored in the parent shell ($!), it can be used as the pgid (and\nsid) of the service process eventually forked by bash in the \"$command\".\nThis pgid being different from parent shell\u0027s, it is safe to pkill -g that\npgid to stop the service only (the forked service has ppid\u003d\u003d1,\npgid\u003d\u003dsid\u003d\u003d$!, pid\u003d\u003d\u003cnew pid\u003e). That effectively turns the service into a\ndemon process.\n\nCorrectness of this change can be checked by executing pstree -pg instead\nof \"$command\" to show the shell relationship as well as pid and pgid of\neach process involved.\n\nChange-Id: I265538ef9e9925ee64477ae127fd050e6133d578\nCloses-Bug: 1595225\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/33e05294258ab6e60488f31eb84967e25283585a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/33e05294258ab6e60488f31eb84967e25283585a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}