)]}'
{"lib/tempest":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"abd64b5d6037d0ccd2c1e73d8df0d6179c71f331","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    iniset $TEMPEST_CONFIG scenario ami_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-blank.img\""},{"line_number":407,"context_line":"    iniset $TEMPEST_CONFIG scenario ari_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-initrd\""},{"line_number":408,"context_line":"    iniset $TEMPEST_CONFIG scenario aki_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-vmlinuz\""},{"line_number":409,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-disk.img\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # Large Ops Number"},{"line_number":412,"context_line":"    iniset $TEMPEST_CONFIG scenario large_ops_number ${TEMPEST_LARGE_OPS_NUMBER:-0}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"dada55a8_b2ec14bc","side":"PARENT","line":409,"range":{"start_line":409,"start_character":46,"end_line":409,"end_character":94},"updated":"2016-07-26 20:44:23.000000000","message":"Why isn\u0027t this $DEFAULT_IMAGE_NAME?\n\nI was looking at this same kind of thing over the weekend:\n\nhttps://review.openstack.org/#/c/346420/\n\nAnd it seems we should use DEFAULT_IMAGE_NAME since we\u0027re making assumptions in here based on what\u0027s in stackrc.","commit_id":"ab7e062f5d1d4a923645d2bb3a1477a366b02be9"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"32234c854ca0ec0764baa3eaf5814c092c56b888","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    iniset $TEMPEST_CONFIG scenario ami_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-blank.img\""},{"line_number":407,"context_line":"    iniset $TEMPEST_CONFIG scenario ari_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-initrd\""},{"line_number":408,"context_line":"    iniset $TEMPEST_CONFIG scenario aki_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-vmlinuz\""},{"line_number":409,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-disk.img\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    # Large Ops Number"},{"line_number":412,"context_line":"    iniset $TEMPEST_CONFIG scenario large_ops_number ${TEMPEST_LARGE_OPS_NUMBER:-0}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"dada55a8_8573837f","side":"PARENT","line":409,"range":{"start_line":409,"start_character":46,"end_line":409,"end_character":94},"in_reply_to":"dada55a8_b2ec14bc","updated":"2016-07-26 23:23:00.000000000","message":"That\u0027s a fair point, I\u0027ll update this to use it instead. I was just reusing what was there before. It was likely this way originally because it assumed the split files. But, I don\u0027t really know","commit_id":"ab7e062f5d1d4a923645d2bb3a1477a366b02be9"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"805faab38508ad962cc443cec5ac786919175360","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        SCENARIO_IMAGE_FILE\u003d\"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-disk.img\""},{"line_number":413,"context_line":"    fi"},{"line_number":414,"context_line":"    iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR"},{"line_number":415,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_FILE"},{"line_number":416,"context_line":"    iniset $TEMPEST_CONFIG scenario ami_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-blank.img\""},{"line_number":417,"context_line":"    iniset $TEMPEST_CONFIG scenario ari_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-initrd\""},{"line_number":418,"context_line":"    iniset $TEMPEST_CONFIG scenario aki_img_file \"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-vmlinuz\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"da4df55a_c87441ff","side":"PARENT","line":415,"updated":"2016-12-22 07:04:41.000000000","message":"we need keep these two lines for XenServer as the default image can\u0027t qcow image can\u0027t work for XS.\nMay just move line414 and line 415 to after line409.","commit_id":"72af0d1cab71a03790688a4b7d9274440fcc3275"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"96ee9304a88303d2682dd3b8fa0261b855d1a04c","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    else"},{"line_number":418,"context_line":"        SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":419,"context_line":"        iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR"},{"line_number":420,"context_line":"        iniset $TEMPEST_CONFIG scenario img_file $DEFAULT_IMAGE_NAME"},{"line_number":421,"context_line":"    fi"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    # Telemetry"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"fa31d9ce_a30ed838","line":420,"updated":"2017-02-13 21:26:03.000000000","message":"Are these Tempest config values OK to be unset in the \"xenserver\" case? It seems like they\u0027d still be needed...","commit_id":"bb3792eaf0a0adfeea9170699fcb4ee9474d0f74"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"4a02b0c1487a78e32500decdcb50aaecbc4849c2","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        iniset $TEMPEST_CONFIG scenario img_disk_format vhd"},{"line_number":416,"context_line":"        iniset $TEMPEST_CONFIG scenario img_container_format ovf"},{"line_number":417,"context_line":"    else"},{"line_number":418,"context_line":"        SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":419,"context_line":"        iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR"},{"line_number":420,"context_line":"        iniset $TEMPEST_CONFIG scenario img_file $DEFAULT_IMAGE_NAME"},{"line_number":421,"context_line":"    fi"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    # Telemetry"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"fa31d9ce_8315544a","line":420,"range":{"start_line":418,"start_character":0,"end_line":420,"end_character":68},"updated":"2017-02-13 21:28:22.000000000","message":"How about change this to:\n  SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}\n  SCENARIO_IMAGE_FILE\u003d\"cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-disk.img\"","commit_id":"bb3792eaf0a0adfeea9170699fcb4ee9474d0f74"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"62a789c044bc066362dc8471436d4815ac322740","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        iniset $TEMPEST_CONFIG scenario img_disk_format vhd"},{"line_number":416,"context_line":"        iniset $TEMPEST_CONFIG scenario img_container_format ovf"},{"line_number":417,"context_line":"    else"},{"line_number":418,"context_line":"        SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":419,"context_line":"        iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR"},{"line_number":420,"context_line":"        iniset $TEMPEST_CONFIG scenario img_file $DEFAULT_IMAGE_NAME"},{"line_number":421,"context_line":"    fi"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    # Telemetry"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"fa31d9ce_2edf2f0e","line":420,"range":{"start_line":418,"start_character":0,"end_line":420,"end_character":68},"in_reply_to":"fa31d9ce_8315544a","updated":"2017-02-13 21:42:33.000000000","message":"Done\n\nThe image file needs to still be default_image_name because it is overridable in the local.conf. But reusing SCENARIO_IMAGE_FILE is the right approach.","commit_id":"bb3792eaf0a0adfeea9170699fcb4ee9474d0f74"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"4a02b0c1487a78e32500decdcb50aaecbc4849c2","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR"},{"line_number":420,"context_line":"        iniset $TEMPEST_CONFIG scenario img_file $DEFAULT_IMAGE_NAME"},{"line_number":421,"context_line":"    fi"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    # Telemetry"},{"line_number":424,"context_line":"    iniset $TEMPEST_CONFIG telemetry-feature-enabled events \"True\""},{"line_number":425,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"fa31d9ce_8e23bba6","line":422,"updated":"2017-02-13 21:28:22.000000000","message":"and add back outside of the if/else:\n\n  iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR\n  iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_FILE\n\nOtherwise, the way it is now, if $VIRT_DRIVER \u003d\u003d xenserver, img_dir and img_file never get set in $TEMPEST_CONFIG","commit_id":"bb3792eaf0a0adfeea9170699fcb4ee9474d0f74"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"62a789c044bc066362dc8471436d4815ac322740","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        iniset $TEMPEST_CONFIG scenario img_dir $SCENARIO_IMAGE_DIR"},{"line_number":420,"context_line":"        iniset $TEMPEST_CONFIG scenario img_file $DEFAULT_IMAGE_NAME"},{"line_number":421,"context_line":"    fi"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    # Telemetry"},{"line_number":424,"context_line":"    iniset $TEMPEST_CONFIG telemetry-feature-enabled events \"True\""},{"line_number":425,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"fa31d9ce_aeccff6a","line":422,"in_reply_to":"fa31d9ce_8e23bba6","updated":"2017-02-13 21:42:33.000000000","message":"oops, that\u0027s what the reviewer said on the previous rev. Completely forgot about that during the rebase.","commit_id":"bb3792eaf0a0adfeea9170699fcb4ee9474d0f74"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"89f58125d6bf2d931674e84e560e179c5de862dc","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_FILE"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    # Telemetry"},{"line_number":425,"context_line":"    iniset $TEMPEST_CONFIG telemetry-feature-enabled events \"True\""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":428,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fa31d9ce_5ee15c99","line":425,"updated":"2017-02-14 11:29:04.000000000","message":"This line shouldn\u0027t be in that patch.","commit_id":"673d009618e6f4e7e76e3f065269f3d89232a1c7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"207eab4506a7473a4011dc6cef6c40f729d98904","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_FILE"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    # Telemetry"},{"line_number":425,"context_line":"    iniset $TEMPEST_CONFIG telemetry-feature-enabled events \"True\""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    # If using provider networking, use the physical network for validation rather than private"},{"line_number":428,"context_line":"    TEMPEST_SSH_NETWORK_NAME\u003d$PRIVATE_NETWORK_NAME"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fa31d9ce_9fd66bef","line":425,"in_reply_to":"fa31d9ce_5ee15c99","updated":"2017-02-14 13:41:53.000000000","message":"Good catch, this was a rebase mistake. This is what I get for not revisiting the patch after a few months.","commit_id":"673d009618e6f4e7e76e3f065269f3d89232a1c7"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f2c08afd23ece771d7561e8337e3ed469d272d3","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                lxc) # the cirros root disk in the uec tarball is empty, so it will not work for lxc"},{"line_number":628,"context_line":"                    DEFAULT_IMAGE_NAME\u003d${DEFAULT_IMAGE_NAME:-cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-rootfs}"},{"line_number":629,"context_line":"                    IMAGE_URLS+\u003d\"http://download.cirros-cloud.net/${CIRROS_VERSION}/cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-rootfs.img.gz\";;"},{"line_number":630,"context_line":"                *) # otherwise, use the uec style image (with kernel, ramdisk, disk)"},{"line_number":631,"context_line":"                    DEFAULT_IMAGE_NAME\u003d${DEFAULT_IMAGE_NAME:-cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-uec}"},{"line_number":632,"context_line":"                    IMAGE_URLS+\u003d\"http://download.cirros-cloud.net/${CIRROS_VERSION}/cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-uec.tar.gz\";;"},{"line_number":633,"context_line":"                esac"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1aa78d24_a03cb2c8","side":"PARENT","line":630,"updated":"2016-07-06 18:15:06.000000000","message":"Adapt this comment accordingly?","commit_id":"feb828b7aadd65b6bd584a1510a1b80dbe49a332"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0bef5673cf778fbeeabae63e516442c2a9f33e23","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                lxc) # the cirros root disk in the uec tarball is empty, so it will not work for lxc"},{"line_number":628,"context_line":"                    DEFAULT_IMAGE_NAME\u003d${DEFAULT_IMAGE_NAME:-cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-rootfs}"},{"line_number":629,"context_line":"                    IMAGE_URLS+\u003d\"http://download.cirros-cloud.net/${CIRROS_VERSION}/cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-rootfs.img.gz\";;"},{"line_number":630,"context_line":"                *) # otherwise, use the uec style image (with kernel, ramdisk, disk)"},{"line_number":631,"context_line":"                    DEFAULT_IMAGE_NAME\u003d${DEFAULT_IMAGE_NAME:-cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-uec}"},{"line_number":632,"context_line":"                    IMAGE_URLS+\u003d\"http://download.cirros-cloud.net/${CIRROS_VERSION}/cirros-${CIRROS_VERSION}-${CIRROS_ARCH}-uec.tar.gz\";;"},{"line_number":633,"context_line":"                esac"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1aa78d24_ccdf9438","side":"PARENT","line":630,"in_reply_to":"1aa78d24_a03cb2c8","updated":"2016-07-12 06:04:14.000000000","message":"yeah","commit_id":"feb828b7aadd65b6bd584a1510a1b80dbe49a332"}]}