)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6f84e219157d120163c0bfa7e0cadda89dc6485","unresolved":false,"context_lines":[{"line_number":137,"context_line":"VIF_PLUGGING_TIMEOUT\u003d${VIF_PLUGGING_TIMEOUT:-300}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# The directory which contains files for Q_PLUGIN_EXTRA_CONF_FILES."},{"line_number":140,"context_line":"# /etc/neutron is assumed by many of devstack plugins.  Do not change."},{"line_number":141,"context_line":"_Q_PLUGIN_EXTRA_CONF_PATH\u003d/etc/neutron"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# List of config file names in addition to the main plugin config file"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_c8252bc3","line":140,"updated":"2016-07-18 14:26:23.000000000","message":"What\u0027s the reason to limit the feature to a single path? Can\u0027t consumers just pass a absolute path?","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2d1a3c19c1983f1116edfbbd786387e82a690e68","unresolved":false,"context_lines":[{"line_number":137,"context_line":"VIF_PLUGGING_TIMEOUT\u003d${VIF_PLUGGING_TIMEOUT:-300}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# The directory which contains files for Q_PLUGIN_EXTRA_CONF_FILES."},{"line_number":140,"context_line":"# /etc/neutron is assumed by many of devstack plugins.  Do not change."},{"line_number":141,"context_line":"_Q_PLUGIN_EXTRA_CONF_PATH\u003d/etc/neutron"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# List of config file names in addition to the main plugin config file"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_77e840e3","line":140,"in_reply_to":"dada55a8_c8252bc3","updated":"2016-07-19 03:46:46.000000000","message":"for compatibility with the existing users of Q_PLUGIN_EXTRA_CONF_FILES.\n\n_neutron_server_config_add takes an absolute path.","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6f84e219157d120163c0bfa7e0cadda89dc6485","unresolved":false,"context_lines":[{"line_number":141,"context_line":"_Q_PLUGIN_EXTRA_CONF_PATH\u003d/etc/neutron"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# List of config file names in addition to the main plugin config file"},{"line_number":144,"context_line":"# To add additional plugin config files, use ``_neutron_server_config_add``"},{"line_number":145,"context_line":"# utility function.  For example:"},{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"#    ``_neutron_server_config_add file1``"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_c8b08b8e","line":144,"updated":"2016-07-18 14:26:23.000000000","message":"if we recommend using it, shouldn\u0027t we then name it without a leading underscore? Also, should we introduce a similar mechanism in lib/neutron?","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2d1a3c19c1983f1116edfbbd786387e82a690e68","unresolved":false,"context_lines":[{"line_number":141,"context_line":"_Q_PLUGIN_EXTRA_CONF_PATH\u003d/etc/neutron"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# List of config file names in addition to the main plugin config file"},{"line_number":144,"context_line":"# To add additional plugin config files, use ``_neutron_server_config_add``"},{"line_number":145,"context_line":"# utility function.  For example:"},{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"#    ``_neutron_server_config_add file1``"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_17b8e4e4","line":144,"in_reply_to":"dada55a8_c8b08b8e","updated":"2016-07-19 03:46:46.000000000","message":"probably.","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"aefd4e25a82ff2842f57402b46226d5348911982","unresolved":false,"context_lines":[{"line_number":908,"context_line":"}"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"# _neutron_server_config_add() - add server config file"},{"line_number":911,"context_line":"function _neutron_server_config_add {"},{"line_number":912,"context_line":"    _Q_PLUGIN_EXTRA_CONF_FILES_ABS+\u003d($1)"},{"line_number":913,"context_line":"}"},{"line_number":914,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_59cab8a2","line":911,"updated":"2016-07-18 12:02:28.000000000","message":"curious as to why a leading underscore is used on this? Private method? It\u0027s being used by scripts in other projects though. Shouldn\u0027t it be public?","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6f84e219157d120163c0bfa7e0cadda89dc6485","unresolved":false,"context_lines":[{"line_number":908,"context_line":"}"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"# _neutron_server_config_add() - add server config file"},{"line_number":911,"context_line":"function _neutron_server_config_add {"},{"line_number":912,"context_line":"    _Q_PLUGIN_EXTRA_CONF_FILES_ABS+\u003d($1)"},{"line_number":913,"context_line":"}"},{"line_number":914,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_2b87a162","line":911,"in_reply_to":"dada55a8_391424f4","updated":"2016-07-18 14:26:23.000000000","message":"I don\u0027t think it\u0027s an example to follow. All things public should have appropriate names.","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"df55b5c9aa46a7297dd01466dbce2b210e5171cc","unresolved":false,"context_lines":[{"line_number":908,"context_line":"}"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"# _neutron_server_config_add() - add server config file"},{"line_number":911,"context_line":"function _neutron_server_config_add {"},{"line_number":912,"context_line":"    _Q_PLUGIN_EXTRA_CONF_FILES_ABS+\u003d($1)"},{"line_number":913,"context_line":"}"},{"line_number":914,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dada55a8_391424f4","line":911,"in_reply_to":"dada55a8_59cab8a2","updated":"2016-07-18 12:04:54.000000000","message":"i followed _neutron_service_plugin_class_add, which is used in a similar way.","commit_id":"b54a1754ed190e31316845f10ef0f39e1b94f799"}]}