)]}'
{"lib/neutron_plugins/openvswitch_agent":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"255b65259088654d41e1b1131bea7f62ad302f7b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        sudo ovs-vsctl -- --may-exist add-port \"br-$VLAN_INTERFACE\" $VLAN_INTERFACE"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Create external bridge and add port"},{"line_number":107,"context_line":"        _neutron_ovs_base_add_bridge $PUBLIC_BRIDGE $PUBLIC_BRIDGE_MTU"},{"line_number":108,"context_line":"        sudo ovs-vsctl -- --may-exist add-port $PUBLIC_BRIDGE $PUBLIC_INTERFACE"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Set bridge mappings to \"physnet1:br-$GUEST_INTERFACE_DEFAULT\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_fba7174d","line":107,"range":{"start_line":107,"start_character":24,"end_line":107,"end_character":25},"updated":"2016-07-15 23:50:43.000000000","message":"see comment on next file.","commit_id":"f0f94857a458edbd78eff48faaaaa6442b6593db"}],"lib/neutron_plugins/ovs_base":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"255b65259088654d41e1b1131bea7f62ad302f7b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    $addbr_cmd"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    shift"},{"line_number":31,"context_line":"    if [ $# -gt 0 ]; then"},{"line_number":32,"context_line":"        local mtu\u003d$1"},{"line_number":33,"context_line":"        set_mtu $bridge $mtu"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_fb4b97ae","line":30,"updated":"2016-07-15 23:50:43.000000000","message":"why do you need this trick? It is hackish for no good reason, unless I am missing something\n\nCan\u0027t you simply do: \n\nset_mtu $PUBLIC_BRIDGE $PUBLIC_BRIDGE_MTU at line 115?","commit_id":"f0f94857a458edbd78eff48faaaaa6442b6593db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a6dde882f4658232e556b5286c0b5e45cd71a35","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    $addbr_cmd"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    shift"},{"line_number":31,"context_line":"    if [ $# -gt 0 ]; then"},{"line_number":32,"context_line":"        local mtu\u003d$1"},{"line_number":33,"context_line":"        set_mtu $bridge $mtu"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_23cbf31f","line":30,"in_reply_to":"fad55976_fb4b97ae","updated":"2016-07-16 22:09:43.000000000","message":"The problem is, then we have code setting bridge scattered in several places. I prefer to keep the code that sets up a bridge in a single function.\n\nBTW what\u0027s hackish about it? I think that\u0027s the only real way to have non-mandatory arguments in shell.","commit_id":"f0f94857a458edbd78eff48faaaaa6442b6593db"}]}