)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"36eee5c67f850b42077a3426955cc30eecc73acc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_b8536916","line":15,"updated":"2016-07-20 15:27:24.000000000","message":"I don\u0027t think it matters: br-ex gets whatever you set for it via CLI or OS configuration.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83caf5449a096b2adb7023283bb52b49170a4887","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_db2d7747","line":15,"in_reply_to":"dada55a8_78c3b157","updated":"2016-07-20 15:43:27.000000000","message":"Ah right. Then we would have br-ex with eg. 1500 while qg with 1450.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"213b8279aab7171348745e1f0372e46a89718545","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_78c3b157","line":15,"in_reply_to":"dada55a8_b8536916","updated":"2016-07-20 15:32:10.000000000","message":"It does because the MTU of the external network is what the gateway interface on the router will be set to.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8c8b4cac8c1db691e64c27281b8c2f6dfb7d218","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_fb003b68","line":15,"in_reply_to":"dada55a8_db2d7747","updated":"2016-07-20 15:46:27.000000000","message":"Yes, and we probably want to get rid of the logic setting the MTU of br-ex to 1450 and have it just set to global_physnet_mtu since that\u0027s what the router will be setting to.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3824258a213cedca36004d2f940de3eb3131146b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_ef2cf103","line":15,"in_reply_to":"dada55a8_de00c503","updated":"2016-07-20 16:40:40.000000000","message":"If router has a 1500 MTU, we would need to be worried about it sending a 1500 MTU packet to the bridge which has a lower MTU and may silently drop it. \n\nI don\u0027t think it should cause failures since the tenant networks will have smaller MTUs so there wouldn\u0027t be something to generate a 1500 MTU packet coming from the router. \n\nHowever, it kind of defeats a lot of the purpose of the auto MTU calculation work if we just force the management interface to sit at 1450 instead of the \u0027correct\u0027 1500. If we set it to 1500, we will actually exercise the MTU exceeded logic if it tries to send something larger than 1450 across the router into a tenant network.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8b2c9d004ce855d3cdc9adaffe0b744150ab6c92","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_6a43cf42","line":15,"in_reply_to":"dada55a8_ef2cf103","updated":"2016-07-20 18:32:12.000000000","message":"I believe you are right, and PUBLIC_BRIDGE_MTU is relevant only as long as we use network_device_mtu. It is still a good thing since we want to support liberty for a while.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c609c0edc7d0ae2b87fc014358489b33ae73782b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"manner (empty external_network_bridge value and"},{"line_number":13,"context_line":"correct bridge_mappings for the L2 agent)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will also help with correct MTU calculations now that"},{"line_number":16,"context_line":"the external network will have the correct segmentation"},{"line_number":17,"context_line":"type on it (\u0027flat\u0027 now instead of \u0027vxlan\u0027 by default)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_de00c503","line":15,"in_reply_to":"dada55a8_fb003b68","updated":"2016-07-20 15:53:00.000000000","message":"Does the router touch the bridge though? I thought it merely handles qg, and that\u0027s not enough for gate purposes since we want the device that issues ssh (br-ex) to cap the MTU of ssh packets to that value.","commit_id":"130a11f8aaf08ea529b6ce60dd9052451cb7bb5c"}],"lib/neutron-legacy":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"aecaaa4ee57d58f207d14e983d7740b33e585afd","unresolved":false,"context_lines":[{"line_number":213,"context_line":"# port for external connectivity."},{"line_number":214,"context_line":"#"},{"line_number":215,"context_line":"# Example: ``OVS_PHYSICAL_BRIDGE\u003dbr-eth1``"},{"line_number":216,"context_line":"OVS_PHYSICAL_BRIDGE\u003d${OVS_PHYSICAL_BRIDGE:-br-ex}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# With the linuxbridge agent, if using VLANs for tenant networks,"},{"line_number":219,"context_line":"# or if using flat or VLAN provider networks, set in ``localrc`` to"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dada55a8_3c1a096f","line":216,"updated":"2016-07-19 15:43:39.000000000","message":"I don\u0027t understand such change as if $OVS_PHYSICAL_BRIDGE is undefined (default case) or empty then it uses br-ex has OVS_PHYSICAL_BRIDGE which is the deprecated behavior! did i miss something?","commit_id":"27d30fdffe623ebd92d7cf659a977de051c72fb0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"11181bcc5e0bfc6d178c97b96f15bb781b4aa945","unresolved":false,"context_lines":[{"line_number":213,"context_line":"# port for external connectivity."},{"line_number":214,"context_line":"#"},{"line_number":215,"context_line":"# Example: ``OVS_PHYSICAL_BRIDGE\u003dbr-eth1``"},{"line_number":216,"context_line":"OVS_PHYSICAL_BRIDGE\u003d${OVS_PHYSICAL_BRIDGE:-br-ex}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# With the linuxbridge agent, if using VLANs for tenant networks,"},{"line_number":219,"context_line":"# or if using flat or VLAN provider networks, set in ``localrc`` to"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dada55a8_c5ae4de5","line":216,"in_reply_to":"dada55a8_3c1a096f","updated":"2016-07-20 09:08:47.000000000","message":"This makes neutron_plugin_configure_plugin_agent function to write out bridge mappings that should be specified when external_network_bridge is empty (the new default now that we enable Q_USE_PROVIDERNET_FOR_PUBLIC in lib/neutron_plugins/services/l3).","commit_id":"27d30fdffe623ebd92d7cf659a977de051c72fb0"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0b1fb999ad235562008233ab06b17be0f25d1e59","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            fi"},{"line_number":200,"context_line":"        fi"},{"line_number":201,"context_line":"        # Create an external network, and a subnet. Configure the external network as router gw"},{"line_number":202,"context_line":"        EXT_NET_ID\u003d$(neutron --os-cloud devstack-admin --os-region \"$REGION_NAME\" net-create \"$PUBLIC_NETWORK_NAME\" -- $EXTERNAL_NETWORK_FLAGS --provider:network_type\u003dflat --provider:physical_network\u003d${PUBLIC_PHYSICAL_NETWORK} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":203,"context_line":"        die_if_not_set $LINENO EXT_NET_ID \"Failure creating EXT_NET_ID for $PUBLIC_NETWORK_NAME\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_b552d9db","line":202,"updated":"2016-07-15 22:06:22.000000000","message":"I suspect it will break several types of setups that may fail to create the network:\n\n1. those overriding type drivers loaded, like midonet gate setting Q_ML2_PLUGIN_TYPE_DRIVERS\u003dmidonet,uplink.\n2. those that actually want vxlan on br-ex, e.g. if something else is plugged into br-ex that would handle the tunneling.\n\nI agree that use cases in 2 are probably exotic if existing at all, but 1. is of concern.","commit_id":"c6a90f16484c3747ff966aca251d511ad9aae7ff"}]}