)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"050906008f74bd27554cffe2f37af58c58e9b47f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"flat_networks is specified."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\u003d\u003d\u003dSet ext_gw_interface to PUBLIC_BRIDGE in provider net case\u003d\u003d\u003d"},{"line_number":23,"context_line":"ext_gw_interface must be a bridge in a bride_mapping when"},{"line_number":24,"context_line":"Q_USE_PROVIDERNET_FOR_PUBLIC is used."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #1605423"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_884e61bf","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":52},"updated":"2016-07-25 09:50:35.000000000","message":"So romantic.","commit_id":"ed69b0864fb8ea7ef9e2a2433962ce6731db4014"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c4a1b00f3503100ff4961c57dfbe7214a0b540aa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"flat_networks is specified."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\u003d\u003d\u003dSet ext_gw_interface to PUBLIC_BRIDGE in provider net case\u003d\u003d\u003d"},{"line_number":23,"context_line":"ext_gw_interface must be a bridge in a bride_mapping when"},{"line_number":24,"context_line":"Q_USE_PROVIDERNET_FOR_PUBLIC is used."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #1605423"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dada55a8_6f85d305","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":52},"updated":"2016-07-25 20:24:12.000000000","message":"still quite romantic","commit_id":"8b5d13700aa2046a89b51ebbf039d12cc4e2486e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"92b2ddc3650bb99eb87c77c20db1de67857b786a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"flat_networks is specified."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\u003d\u003d\u003dSet ext_gw_interface to PUBLIC_BRIDGE in provider net case\u003d\u003d\u003d"},{"line_number":23,"context_line":"ext_gw_interface must be a bridge in a bride_mapping when"},{"line_number":24,"context_line":"Q_USE_PROVIDERNET_FOR_PUBLIC is used."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #1605423"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dada55a8_0a3525d9","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":52},"in_reply_to":"dada55a8_6f85d305","updated":"2016-07-25 20:35:03.000000000","message":"AHHH. I see it now. :)","commit_id":"8b5d13700aa2046a89b51ebbf039d12cc4e2486e"}],"lib/neutron-legacy":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ae78de14d7a8062697927241775bbe1bd9dc60b6","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    local add_ovs_port\u003d$3"},{"line_number":587,"context_line":"    local del_ovs_port\u003d$4"},{"line_number":588,"context_line":"    local af\u003d$5"},{"line_number":589,"context_line":"    if is_neutron_ovs_base_plugin \u0026\u0026 [[ -n \"$from_intf\" \u0026\u0026 -n \"$to_intf\" ]]; then"},{"line_number":590,"context_line":"        # Remove the primary IP address from $from_intf and add it to $to_intf,"},{"line_number":591,"context_line":"        # along with the default route, if it exists.  Also, when called"},{"line_number":592,"context_line":"        # on configure we will also add $from_intf as a port on $to_intf,"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dada55a8_03160fa7","line":589,"updated":"2016-07-22 14:35:36.000000000","message":"I think the cleanup_mutnauq function needs to be changed too.  It calls this method even when neutron L3 agent isn\u0027t enabled.","commit_id":"9cfe8f39c25ab0c1bb5b063c3e312d0d33d8a68c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4882956aee19ba3d3ec23e223e67ec2ee1a9034c","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    local add_ovs_port\u003d$3"},{"line_number":587,"context_line":"    local del_ovs_port\u003d$4"},{"line_number":588,"context_line":"    local af\u003d$5"},{"line_number":589,"context_line":"    if is_neutron_ovs_base_plugin \u0026\u0026 [[ -n \"$from_intf\" \u0026\u0026 -n \"$to_intf\" ]]; then"},{"line_number":590,"context_line":"        # Remove the primary IP address from $from_intf and add it to $to_intf,"},{"line_number":591,"context_line":"        # along with the default route, if it exists.  Also, when called"},{"line_number":592,"context_line":"        # on configure we will also add $from_intf as a port on $to_intf,"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dada55a8_7dfdd66d","line":589,"in_reply_to":"dada55a8_03160fa7","updated":"2016-07-22 21:20:19.000000000","message":"separate patch. this patch is focused on making linux bridge compatible with the provider net option.","commit_id":"9cfe8f39c25ab0c1bb5b063c3e312d0d33d8a68c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"36b4cfef778ef02573c7d8062a1f36e4c4ff76fe","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    local add_ovs_port\u003d$3"},{"line_number":587,"context_line":"    local del_ovs_port\u003d$4"},{"line_number":588,"context_line":"    local af\u003d$5"},{"line_number":589,"context_line":"    if is_neutron_ovs_base_plugin \u0026\u0026 [[ -n \"$from_intf\" \u0026\u0026 -n \"$to_intf\" ]]; then"},{"line_number":590,"context_line":"        # Remove the primary IP address from $from_intf and add it to $to_intf,"},{"line_number":591,"context_line":"        # along with the default route, if it exists.  Also, when called"},{"line_number":592,"context_line":"        # on configure we will also add $from_intf as a port on $to_intf,"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dada55a8_1c03f210","line":589,"in_reply_to":"dada55a8_7dfdd66d","updated":"2016-07-23 11:22:55.000000000","message":"I agree","commit_id":"9cfe8f39c25ab0c1bb5b063c3e312d0d33d8a68c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"050906008f74bd27554cffe2f37af58c58e9b47f","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    local add_ovs_port\u003d$3"},{"line_number":587,"context_line":"    local del_ovs_port\u003d$4"},{"line_number":588,"context_line":"    local af\u003d$5"},{"line_number":589,"context_line":"    if is_neutron_ovs_base_plugin \u0026\u0026 [[ -n \"$from_intf\" \u0026\u0026 -n \"$to_intf\" ]]; then"},{"line_number":590,"context_line":"        # Remove the primary IP address from $from_intf and add it to $to_intf,"},{"line_number":591,"context_line":"        # along with the default route, if it exists.  Also, when called"},{"line_number":592,"context_line":"        # on configure we will also add $from_intf as a port on $to_intf,"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dada55a8_68716d44","line":589,"updated":"2016-07-25 09:50:35.000000000","message":"(No action required) probably suggests that it should not live here but in ovs_base, but it\u0027s unsafe now to move it, so yeah, +1.\n\nIdeally, callers would not even call the function for non ovs cases, but again, that would involve refactoring, and experience shows that will break something somewhere.","commit_id":"ed69b0864fb8ea7ef9e2a2433962ce6731db4014"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9b9f90ae564db41e11e179813cfaf4377ed7990d","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Allow for setup the flat type network"},{"line_number":98,"context_line":"    if [[ -z \"$Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\" \u0026\u0026 -n \"$PHYSICAL_NETWORK\" ]]; then"},{"line_number":99,"context_line":"            Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"flat_networks\u003d$PHYSICAL_NETWORK,$PUBLIC_PHYSICAL_NETWORK\""},{"line_number":100,"context_line":"    fi"},{"line_number":101,"context_line":"    # REVISIT(rkukura): Setting firewall_driver here for"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dada55a8_0351ef0e","line":98,"updated":"2016-07-22 14:25:31.000000000","message":"How about checking PUBLIC_PHYSICAL_NETWORK too?","commit_id":"9cfe8f39c25ab0c1bb5b063c3e312d0d33d8a68c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9b9f90ae564db41e11e179813cfaf4377ed7990d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Allow for setup the flat type network"},{"line_number":98,"context_line":"    if [[ -z \"$Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\" \u0026\u0026 -n \"$PHYSICAL_NETWORK\" ]]; then"},{"line_number":99,"context_line":"            Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"flat_networks\u003d$PHYSICAL_NETWORK,$PUBLIC_PHYSICAL_NETWORK\""},{"line_number":100,"context_line":"    fi"},{"line_number":101,"context_line":"    # REVISIT(rkukura): Setting firewall_driver here for"},{"line_number":102,"context_line":"    # neutron.agent.securitygroups_rpc.is_firewall_enabled() which is"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dada55a8_e005b114","line":99,"range":{"start_line":99,"start_character":58,"end_line":99,"end_character":100},"updated":"2016-07-22 14:25:31.000000000","message":"Both of these have the same default value, but it appears this is okay.","commit_id":"9cfe8f39c25ab0c1bb5b063c3e312d0d33d8a68c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"050906008f74bd27554cffe2f37af58c58e9b47f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS+\u003d\"${PHYSICAL_NETWORK},\""},{"line_number":103,"context_line":"            fi"},{"line_number":104,"context_line":"            if [[ -n \"$PUBLIC_PHYSICAL_NETWORK\" ]]; then"},{"line_number":105,"context_line":"                Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS+\u003d\"${PHYSICAL_PHYSICAL_NETWORK},\""},{"line_number":106,"context_line":"            fi"},{"line_number":107,"context_line":"        fi"},{"line_number":108,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dada55a8_28681521","line":105,"range":{"start_line":105,"start_character":51,"end_line":105,"end_character":76},"updated":"2016-07-25 09:50:35.000000000","message":"PUBLIC_PHYSICAL_NETWORK you mean?","commit_id":"ed69b0864fb8ea7ef9e2a2433962ce6731db4014"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9f38cbe2ff6722168a95bf071c260c78425349a8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS+\u003d\"${PHYSICAL_NETWORK},\""},{"line_number":103,"context_line":"            fi"},{"line_number":104,"context_line":"            if [[ -n \"$PUBLIC_PHYSICAL_NETWORK\" ]]; then"},{"line_number":105,"context_line":"                Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS+\u003d\"${PHYSICAL_PHYSICAL_NETWORK},\""},{"line_number":106,"context_line":"            fi"},{"line_number":107,"context_line":"        fi"},{"line_number":108,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dada55a8_441b9680","line":105,"range":{"start_line":105,"start_character":51,"end_line":105,"end_character":76},"in_reply_to":"dada55a8_28681521","updated":"2016-07-25 20:14:40.000000000","message":"yep","commit_id":"ed69b0864fb8ea7ef9e2a2433962ce6731db4014"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"050906008f74bd27554cffe2f37af58c58e9b47f","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        if is_neutron_ovs_base_plugin; then"},{"line_number":297,"context_line":"            ext_gw_interface\u003d$(_neutron_get_ext_gw_interface)"},{"line_number":298,"context_line":"        elif [[ \"$Q_AGENT\" \u003d \"linuxbridge\" ]]; then"},{"line_number":299,"context_line":"            # Search for the brq device the neutron router and network for $FIXED_RANGE"},{"line_number":300,"context_line":"            # will be using."},{"line_number":301,"context_line":"            if [ \"$Q_USE_PROVIDERNET_FOR_PUBLIC\" \u003d \"True\" ]; then"},{"line_number":302,"context_line":"                # in provider nets a bridge mapping uses the public bridge directly"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dada55a8_73b9622e","line":299,"updated":"2016-07-25 09:50:35.000000000","message":"Now the comment does not seem to apply to the whole section.","commit_id":"ed69b0864fb8ea7ef9e2a2433962ce6731db4014"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9f38cbe2ff6722168a95bf071c260c78425349a8","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        if is_neutron_ovs_base_plugin; then"},{"line_number":297,"context_line":"            ext_gw_interface\u003d$(_neutron_get_ext_gw_interface)"},{"line_number":298,"context_line":"        elif [[ \"$Q_AGENT\" \u003d \"linuxbridge\" ]]; then"},{"line_number":299,"context_line":"            # Search for the brq device the neutron router and network for $FIXED_RANGE"},{"line_number":300,"context_line":"            # will be using."},{"line_number":301,"context_line":"            if [ \"$Q_USE_PROVIDERNET_FOR_PUBLIC\" \u003d \"True\" ]; then"},{"line_number":302,"context_line":"                # in provider nets a bridge mapping uses the public bridge directly"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dada55a8_4f260fbb","line":299,"in_reply_to":"dada55a8_73b9622e","updated":"2016-07-25 20:14:40.000000000","message":"this code is still picking the device. i\u0027ll update it to remove \u0027brq\u0027","commit_id":"ed69b0864fb8ea7ef9e2a2433962ce6731db4014"}]}