)]}'
{"lib/nova":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cc6f132ace634f8110a38457e59aea464549cd75","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        iniset $NOVA_CONF serial_console serialproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":611,"context_line":"        iniset $NOVA_CONF serial_console enabled True"},{"line_number":612,"context_line":"    else"},{"line_number":613,"context_line":"        iniset $NOVA_CONF serial_console enabled False"},{"line_number":614,"context_line":"    fi"},{"line_number":615,"context_line":"    iniset $NOVA_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":616,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dada55a8_8600b635","line":613,"updated":"2016-07-26 19:12:05.000000000","message":"this is not the default if nothing is specified?","commit_id":"08b3973ca73963f2d8a5c05aeed9575f0fb70987"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"28cd6074c40b1fb732435458a3d24548a9a2b1f7","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        iniset $NOVA_CONF serial_console serialproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":611,"context_line":"        iniset $NOVA_CONF serial_console enabled True"},{"line_number":612,"context_line":"    else"},{"line_number":613,"context_line":"        iniset $NOVA_CONF serial_console enabled False"},{"line_number":614,"context_line":"    fi"},{"line_number":615,"context_line":"    iniset $NOVA_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":616,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bacf61ea_fd025a3d","line":613,"in_reply_to":"bacf61ea_4dbaede2","updated":"2016-07-28 12:26:35.000000000","message":"@Ian: You\u0027re right, excellent catch! My change doesn\u0027t make sense but would introduce an issue. Thanks a lot for pointing this out. I\u0027m abandoning this.","commit_id":"08b3973ca73963f2d8a5c05aeed9575f0fb70987"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"aacca14dc0b3b3c0d798001f827e6062b12280dd","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        iniset $NOVA_CONF serial_console serialproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":611,"context_line":"        iniset $NOVA_CONF serial_console enabled True"},{"line_number":612,"context_line":"    else"},{"line_number":613,"context_line":"        iniset $NOVA_CONF serial_console enabled False"},{"line_number":614,"context_line":"    fi"},{"line_number":615,"context_line":"    iniset $NOVA_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":616,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dada55a8_beb848c9","line":613,"in_reply_to":"dada55a8_8600b635","updated":"2016-07-27 09:27:49.000000000","message":"@Ian: You\u0027re right, it is the default if nothing is specified. The same is true for n-spice above in line 582. \nI still think it makes sense in the case when one enables the serial console but doesn\u0027t enable the serialproxy service. The result will be a guest which gets created with a serial console device but is not accessible. The change makes it a little more consistent IMO.","commit_id":"08b3973ca73963f2d8a5c05aeed9575f0fb70987"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"bdcd52361c6961a56c82eca3d13cc95f80577c04","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        iniset $NOVA_CONF serial_console serialproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":611,"context_line":"        iniset $NOVA_CONF serial_console enabled True"},{"line_number":612,"context_line":"    else"},{"line_number":613,"context_line":"        iniset $NOVA_CONF serial_console enabled False"},{"line_number":614,"context_line":"    fi"},{"line_number":615,"context_line":"    iniset $NOVA_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":616,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bacf61ea_4dbaede2","line":613,"in_reply_to":"dada55a8_beb848c9","updated":"2016-07-28 04:27:56.000000000","message":"well that\u0027s an interesting point too ... would anyone want to do that?  does n-sproxy disabled imply that you would *never* want serial_console enabled?  \n\nin multi-node, where there\u0027s one proxy but multiple hosts, on non-proxy hosts wouldn\u0027t you have n-sproxy disabled and then have this setup in local.conf?\n\nin that case it seems like a race to see who gets their entry in the config file last...","commit_id":"08b3973ca73963f2d8a5c05aeed9575f0fb70987"}]}