)]}'
{"id":"openstack%2Fdevstack~347478","triplet_id":"openstack%2Fdevstack~master~Ie28e1f8dda4ea138f08a3a8e3962bdfbe7ec2b06","project":"openstack/devstack","branch":"master","topic":"bug/1606625","hashtags":[],"change_id":"Ie28e1f8dda4ea138f08a3a8e3962bdfbe7ec2b06","subject":"Support patching projects/plugins","status":"ABANDONED","created":"2016-07-26 16:36:31.000000000","updated":"2017-12-20 03:12:21.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"807d7469320b319aca3600f4c458ad81689db940","_number":347478,"virtual_id_number":347478,"owner":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"date":"2016-07-26 20:17:54.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2016-07-26 20:01:57.000000000","_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},{"value":0,"date":"2016-07-26 17:58:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},{"date":"2016-07-26 21:39:19.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"date":"2016-07-27 08:29:30.000000000","_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":-1,"date":"2016-08-01 19:47:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},{"value":-1,"date":"2016-07-26 19:46:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},{"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},{"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-26 16:37:36.000000000","updated_by":{"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},"reviewer":{"_account_id":22342,"name":"Alon Kochba","email":"alonko@hpe.com","username":"alonko"},"state":"REVIEWER"},{"updated":"2016-07-26 17:58:47.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-07-26 19:46:27.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-07-26 20:17:54.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-07-26 21:39:19.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-07-27 08:29:30.000000000","updated_by":{"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},"reviewer":{"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},"state":"REVIEWER"},{"updated":"2016-08-01 19:47:34.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"}],"messages":[{"id":"e4443bab095fbca884f95b079285b7945dc6ea0c","author":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"date":"2016-07-26 16:36:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d1fc94913c069d7c900221553e8e47cc1de9040e","author":{"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},"date":"2016-07-26 16:51:32.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"798efa8117c5adf1d9edc4b77953c97e737216a1","author":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"date":"2016-07-26 16:53:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"75b66ba10edf546bd50b562e7f00173125bb94f1","author":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"date":"2016-07-26 16:54:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"153887debd510f5855064b0c2d5df7d3915c3ee4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-07-26 17:58:47.000000000","message":"Patch Set 2:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/78/347478/2/check/check-ibm-tempest-dsvm-full/c4096a3/ : SUCCESS in 1h 05m 09s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b7827217a85acbca2344c9af7e7e1dc063c9dfb0","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-07-26 19:46:27.000000000","message":"Patch Set 2: Code-Review-1\n\nI realise this is relatively minor code, but I would not like to see this approach in devstack core.  The reason is that next thing you know this will be used in the gate and we\u0027ll be making it even harder to replicate gate failures than it already is by pulling in code changes outside our usual mechanisms.  The idea that \"we\u0027re running $PROJECT, but with the XYZ company patch\" where that patch is built \u0026 maintained outside the usual OpenStack review mechanism is not appealing.\n\nI also realise nothing stops a plugin doing this anyway, but devstack does have to make decisions about what we support.\n\nOur way of bringing in patches is really via the review mechanism [1].  With depends-on you can get cross-project dependencies.  if something isn\u0027t quite ready you can always wip it.  It\u0027s kind of the core thing about openstack that we all use gerrit and collaborate on changes.\n\nI\u0027m willing to listen to the use-case for this and maybe it\u0027s convincing ... but that\u0027s my first thought here.\n\n[1] I\u0027m not sure if you know this -- gerrit does its best to keep it hidden in the \"Download\" pull-down -- but you can pull this change into a tree with \"git pull https://git.openstack.org/openstack-dev/devstack refs/changes/78/347478/2\"","accounts_in_message":[],"_revision_number":2},{"id":"c314a2f387d5e520cc86d9ab6190143fc621233a","author":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"date":"2016-07-26 20:01:57.000000000","message":"Patch Set 2:\n\n\u003e I realise this is relatively minor code, but I would not like to\n \u003e see this approach in devstack core.  The reason is that next thing\n \u003e you know this will be used in the gate and we\u0027ll be making it even\n \u003e harder to replicate gate failures than it already is by pulling in\n \u003e code changes outside our usual mechanisms.  The idea that \"we\u0027re\n \u003e running $PROJECT, but with the XYZ company patch\" where that patch\n \u003e is built \u0026 maintained outside the usual OpenStack review mechanism\n \u003e is not appealing.\n \u003e \n \u003e I also realise nothing stops a plugin doing this anyway, but\n \u003e devstack does have to make decisions about what we support.\n \u003e \n \u003e Our way of bringing in patches is really via the review mechanism\n \u003e [1].  With depends-on you can get cross-project dependencies.  if\n \u003e something isn\u0027t quite ready you can always wip it.  It\u0027s kind of\n \u003e the core thing about openstack that we all use gerrit and\n \u003e collaborate on changes.\n \u003e \n \u003e I\u0027m willing to listen to the use-case for this and maybe it\u0027s\n \u003e convincing ... but that\u0027s my first thought here.\n \u003e \n \u003e [1] I\u0027m not sure if you know this -- gerrit does its best to keep\n \u003e it hidden in the \"Download\" pull-down -- but you can pull this\n \u003e change into a tree with \"git pull https://git.openstack.org/openstack-dev/devstack\n \u003e refs/changes/78/347478/2\"\n\nHi Ian,\n\nWhile I agree that patches/fixes should always go to gerrit, the process is sometimes too long. Some projects don\u0027t have many reviewers, and sometimes it just takes time until a fix is committed, and it is obviously impossible to work with devstack if you have to wait for a fix. I do believe, that everyone that uses devstack to do something more than trivial, has something similar to this commit.\nIf we want devstack users to be satisfied, we must solve the problem of waiting for commits.\nIn our company, waiting for a fix-commit is simply not an option. So we do whatever we can, in order to push forward the fix-commit, but we can\u0027t stop testing/developing until it is committed.\nWe have already been using this patch_plugins method for a while now, and we just wanted to share it with the community, as we are certain it will benefit from it.\nI totally agree about the gating comment - If gates run with different commits, it will definitely make it harder to reproduce bugs, but again - If the gate cannot run because it is waiting for a fix, and the fix-commit is taking time, what is the point of the gate? As you said - whoever is running the gate will do it anyway if they want to, so better standardize it. Maybe we can even find a way to have a gate output whatever patches it was running with (if it was running with).\n\nThat said, I\u0027m always open to other suggestions, especially if they are better :-)","accounts_in_message":[],"_revision_number":2},{"id":"1473ddab37f770a90fbc0359d32e248ee5d82186","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-07-26 20:17:54.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- dsvm-tempest-nova-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/78/347478/2/check/dsvm-tempest-nova-network/d033966 : SUCCESS in 1h 22m 39s\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/78/347478/2/check/dsvm-tempest-neutron-network/9c0fea2 : SUCCESS in 1h 47m 36s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c31fe239ffa630e5035c3767832f01b5c67fb577","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-07-26 20:33:42.000000000","message":"Patch Set 2:\n\n\u003e it is obviously impossible to work with devstack if you have to wait for a fix.\n\nI\u0027m not sure I would agree with this; fundamentally we are using source from git and thus the thing it does really well is manage changes.\n\nIt may not be totally obvious -- git links are hard to find on gerrit, maybe we don\u0027t document it well in devstack.  it\u0027s still not quite clear to me exactly what workflow is holding you up and requiring patches.  it might be we just need better documentation to help expose how to best use the tools we have","accounts_in_message":[],"_revision_number":2},{"id":"d170ffecc18295664b02ee94ecf04e5c051a9897","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-07-26 21:39:19.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-odl http://intel-openstack-ci-logs.ovh/78/347478/2/check/tempest-dsvm-ovsdpdk-odl/e60269a : FAILURE in 57m 56s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6c0477cbf21e3d9c3e5ab1235c871126b75fbeab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-26 21:59:42.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-tempest-dsvm-full http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-full/ff97fac/ : SUCCESS in 1h 05m 48s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-postgres-full/e7f4c14/ : SUCCESS in 1h 10m 34s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-neutron-full/e589495/ : SUCCESS in 1h 24m 05s\n- gate-grenade-dsvm http://logs.openstack.org/78/347478/2/check/gate-grenade-dsvm/63ba4f7/ : SUCCESS in 46m 21s\n- gate-devstack-docs-ubuntu-trusty http://docs-draft.openstack.org/78/347478/2/check/gate-devstack-docs-ubuntu-trusty/94243a2//doc/build/html/ : SUCCESS in 2m 43s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/78/347478/2/check/gate-devstack-docs-ubuntu-xenial/5d58b6c//doc/build/html/ : SUCCESS in 6m 21s\n- gate-devstack-bashate http://logs.openstack.org/78/347478/2/check/gate-devstack-bashate/fdcca2d/ : SUCCESS in 3m 31s\n- gate-devstack-unit-tests http://logs.openstack.org/78/347478/2/check/gate-devstack-unit-tests/214e1c9/ : SUCCESS in 2m 56s\n- gate-tempest-dsvm-ironic-agent_ssh-nv http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-ironic-agent_ssh-nv/8cc1f1c/ : SUCCESS in 47m 33s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/78/347478/2/check/gate-devstack-dsvm-updown/d3d53d5/ : SUCCESS in 37m 53s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/f7fa6f9/ : SUCCESS in 1h 26m 58s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/78/347478/2/check/gate-swift-dsvm-functional-nv/da5c2d4/ : SUCCESS in 39m 31s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/78/347478/2/check/gate-grenade-dsvm-neutron/69c0fdc/ : SUCCESS in 56m 27s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-multinode-full/cfd634c/ : FAILURE in 1h 22m 41s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-neutron-multinode-full/0aa2c35/ : FAILURE in 1h 34m 57s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/78/347478/2/check/gate-grenade-dsvm-multinode/584d0b3/ : SUCCESS in 54m 16s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/78/347478/2/check/gate-grenade-dsvm-neutron-multinode/2dc9ec8/ : FAILURE in 44m 16s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-platform-centos7-nv/42b3609/ : SUCCESS in 58m 53s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/78/347478/2/check/gate-tempest-dsvm-platform-fedora23-nv/6bb03c2/ : SUCCESS in 1h 03m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"af44f5bef72de3ffe7c3c9a315e1d47751d873df","author":{"_account_id":22908,"name":"Koby Aizer","email":"koby.aizer@hpe.com","username":"kobya"},"date":"2016-07-27 08:29:30.000000000","message":"Patch Set 2:\n\nHi Ian,\n\nThanks for you comments, I agree we might be missing something here. I\u0027d like to give three use cases and be happy to hear if there is a better way to handle them:\n\nFirst use is pretty much what Yinon has mentioned before. Assuming you have changes to one of the devstack plugins, and you\u0027ve published the review. Until it is merged, what are your options to use it when running devstack? You were suggesting that you can pull the change from gerrit \"Download\" link, but how can you apply this to the relevant repository (giving that devstack is cloning the plugins repositories on its own).\n\nSecond use case is that you\u0027re currently developing a code to one of the plugins which is still work-in-progress. How can you apply you\u0027re (partial) code changes in order to test them?\n\nThird use case is similar to #1, but assuming you need to use code from several different pending reviews.","accounts_in_message":[],"_revision_number":2},{"id":"c4bcd3afb97f6ab81c0925a0464dcdf10b25af6d","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-08-01 19:47:34.000000000","message":"Patch Set 2: Code-Review-1\n\nI don\u0027t think this is something we should support. There are ways that people can pull in branches, via the *_GIT_REPO and *_BRANCH configuration variables.","accounts_in_message":[],"_revision_number":2},{"id":"979fb298a9210ccc7230f8ff1be10ad5e52d236c","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 04:58:24.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":2},{"id":"d06bbd2ba513b348206110604a4a4b3662339d79","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-12-20 03:12:21.000000000","message":"Abandoned\n\nThis isn\u0027t a path we\u0027d go down.  Removing from the queue, thanks","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2ea4e2cf9e232b3f80d4801f46b23076c0262cb7","revisions":{"f2a76c2d14f8ddc03308206e736291f6bb0ad85f":{"kind":"REWORK","_number":1,"created":"2016-07-26 16:36:31.000000000","uploader":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"ref":"refs/changes/78/347478/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/78/347478/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/347478/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/347478/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/347478/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/78/347478/1"}}},"commit":{"parents":[{"commit":"b12c25a3e60b6deeceec54ccca1592b20bfdb949","subject":"Merge \"Keep old behavior of setuptools for editable installs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b12c25a3e60b6deeceec54ccca1592b20bfdb949"}]}],"author":{"name":"Yinon","email":"yinonby@hpe.com","date":"2016-07-26 16:29:28.000000000","tz":180},"committer":{"name":"Yinon","email":"yinonby@hpe.com","date":"2016-07-26 16:36:12.000000000","tz":180},"subject":"Support patching projects/plugins","message":"Support patching projects/plugins\n\nAdd a patching mechanism right after cloning the\nprojects and fetching plugins, in order to allow the\nuser to supply patches. User will place his patches\nunder a \"patches\" directory under the devstack root\ndirectory. The patch name will start with the name of\nthe project/plugin, and end with \".patch\", and between\nthe user can put a string to identify the patch.\n\nChange-Id: Ie28e1f8dda4ea138f08a3a8e3962bdfbe7ec2b06\nCloses-Bug: #1606625\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2a76c2d14f8ddc03308206e736291f6bb0ad85f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2a76c2d14f8ddc03308206e736291f6bb0ad85f"}]},"branch":"refs/heads/master"},"2ea4e2cf9e232b3f80d4801f46b23076c0262cb7":{"kind":"REWORK","_number":2,"created":"2016-07-26 16:53:27.000000000","uploader":{"_account_id":22305,"name":"Yinon","email":"yinonby@hpe.com","username":"yinonby"},"ref":"refs/changes/78/347478/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/78/347478/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/347478/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/347478/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/78/347478/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/78/347478/2"}}},"commit":{"parents":[{"commit":"b12c25a3e60b6deeceec54ccca1592b20bfdb949","subject":"Merge \"Keep old behavior of setuptools for editable installs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b12c25a3e60b6deeceec54ccca1592b20bfdb949"}]}],"author":{"name":"Yinon","email":"yinonby@hpe.com","date":"2016-07-26 16:29:28.000000000","tz":180},"committer":{"name":"Yinon","email":"yinonby@hpe.com","date":"2016-07-26 16:53:15.000000000","tz":180},"subject":"Support patching projects/plugins","message":"Support patching projects/plugins\n\nAdd a patching mechanism right after cloning the\nprojects and fetching plugins, in order to allow the\nuser to supply patches. User will place his patches\nunder a \"patches\" directory under the devstack root\ndirectory. The patch name will start with the name of\nthe project/plugin, and end with \".patch\", and between\nthe user can put a string to identify the patch.\n\nChange-Id: Ie28e1f8dda4ea138f08a3a8e3962bdfbe7ec2b06\nCloses-Bug: #1606625\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2ea4e2cf9e232b3f80d4801f46b23076c0262cb7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2ea4e2cf9e232b3f80d4801f46b23076c0262cb7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
