)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1ac7ef1abb30c897ce1b1b21dd261ca3a2777436","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    neutron_plugin_configure_l3_agent $Q_L3_CONF_FILE"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # If we\u0027ve given a PUBLIC_INTERFACE to take over, then we assume"},{"line_number":106,"context_line":"    # that we can own the whole thing, and privot it into the OVS"},{"line_number":107,"context_line":"    # bridge. If we are not, we\u0027re probably on a single interface"},{"line_number":108,"context_line":"    # machine, and we just setup NAT so that fixed guests can get out."},{"line_number":109,"context_line":"    if [[ -n \"$PUBLIC_INTERFACE\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bacf61ea_77fd7eb0","line":106,"updated":"2016-08-05 01:04:42.000000000","message":"pivot?","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ffeea3e001d48bd6879c958250f38f439094e694","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    neutron_plugin_configure_l3_agent $Q_L3_CONF_FILE"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # If we\u0027ve given a PUBLIC_INTERFACE to take over, then we assume"},{"line_number":106,"context_line":"    # that we can own the whole thing, and privot it into the OVS"},{"line_number":107,"context_line":"    # bridge. If we are not, we\u0027re probably on a single interface"},{"line_number":108,"context_line":"    # machine, and we just setup NAT so that fixed guests can get out."},{"line_number":109,"context_line":"    if [[ -n \"$PUBLIC_INTERFACE\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bacf61ea_6da11c94","line":106,"in_reply_to":"bacf61ea_77fd7eb0","updated":"2016-08-05 11:31:39.000000000","message":"ah, yeh, good catch :)","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"623642ceff26a143cdac9a08849e928d56dbe41b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        fi"},{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        local default_dev\u003d\"\""},{"line_number":117,"context_line":"        default_dev\u003d$(ip route | grep ^default | awk \u0027{print $5}\u0027)"},{"line_number":118,"context_line":"        sudo iptables -t nat -A POSTROUTING -o $default_dev -s $FLOATING_RANGE -j MASQUERADE"},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ad45d7e_1b883422","line":117,"updated":"2016-08-08 16:44:48.000000000","message":"And just another nit... L116/117 can be combined, no reason to assign it to \"\"","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b71d5c1514fd4abb0d3e55976cbebcfe17636108","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        local default_dev\u003d\"\""},{"line_number":117,"context_line":"        default_dev\u003d$(ip route | grep ^default | awk \u0027{print $5}\u0027)"},{"line_number":118,"context_line":"        sudo iptables -t nat -A POSTROUTING -o $default_dev -s $FLOATING_RANGE -j MASQUERADE"},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bacf61ea_e4db887a","line":118,"updated":"2016-08-04 19:17:31.000000000","message":"if $default_dev is \"\" this will throw an error like \"bad argument\", should probably catch and complain, even though it shouldn\u0027t happen.","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fb506bfd9b8aa5fe7a6164df00a10404ec73f705","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        local default_dev\u003d\"\""},{"line_number":117,"context_line":"        default_dev\u003d$(ip route | grep ^default | awk \u0027{print $5}\u0027)"},{"line_number":118,"context_line":"        sudo iptables -t nat -A POSTROUTING -o $default_dev -s $FLOATING_RANGE -j MASQUERADE"},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bacf61ea_5f37bdfe","line":118,"in_reply_to":"bacf61ea_1f46e54e","updated":"2016-08-04 19:48:36.000000000","message":"I wouldn\u0027t ever expect it to be blank, but it\u0027s going to be easier to debug than a bad iptables error if it ever is.","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"89f1944e450d9b7c771162676ada2588f32580fe","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        local default_dev\u003d\"\""},{"line_number":117,"context_line":"        default_dev\u003d$(ip route | grep ^default | awk \u0027{print $5}\u0027)"},{"line_number":118,"context_line":"        sudo iptables -t nat -A POSTROUTING -o $default_dev -s $FLOATING_RANGE -j MASQUERADE"},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bacf61ea_1f46e54e","line":118,"in_reply_to":"bacf61ea_44041417","updated":"2016-08-04 19:31:18.000000000","message":"Brian, under what scenarios would you imagine that default_dev would end up blank?","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":6672,"name":"Geronimo Orozco","email":"geronimo.orozco@intel.com","username":"gorozco"},"change_message_id":"7113bbf49b49f01785ced6f34391c4969dc0befe","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        local default_dev\u003d\"\""},{"line_number":117,"context_line":"        default_dev\u003d$(ip route | grep ^default | awk \u0027{print $5}\u0027)"},{"line_number":118,"context_line":"        sudo iptables -t nat -A POSTROUTING -o $default_dev -s $FLOATING_RANGE -j MASQUERADE"},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ad45d7e_2dc65048","line":118,"in_reply_to":"bacf61ea_44041417","updated":"2016-08-10 00:11:41.000000000","message":"default to \u0027lo\u0027 will break things latter isn\u0027t it? better to test if the variable is empty for some strange reason and trow an error.","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"03fc0cce19272b0b499cd0832d91f28ae7c85d62","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else"},{"line_number":116,"context_line":"        local default_dev\u003d\"\""},{"line_number":117,"context_line":"        default_dev\u003d$(ip route | grep ^default | awk \u0027{print $5}\u0027)"},{"line_number":118,"context_line":"        sudo iptables -t nat -A POSTROUTING -o $default_dev -s $FLOATING_RANGE -j MASQUERADE"},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bacf61ea_44041417","line":118,"in_reply_to":"bacf61ea_e4db887a","updated":"2016-08-04 19:28:28.000000000","message":"Just default that variable to \u0027lo\u0027 if it\u0027s empty.","commit_id":"6a008fa74bce0497b7902dd95300599a3026e2dd"}],"lib/nova":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c9bca5b80219fec0ec28e9fb18296f7a1915caa6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"# --------------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"NETWORK_MANAGER\u003d${NETWORK_MANAGER:-${NET_MAN:-FlatDHCPManager}}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"VLAN_INTERFACE\u003d${VLAN_INTERFACE:-$GUEST_INTERFACE_DEFAULT}"},{"line_number":133,"context_line":"FLAT_NETWORK_BRIDGE\u003d${FLAT_NETWORK_BRIDGE:-$FLAT_NETWORK_BRIDGE_DEFAULT}"},{"line_number":134,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bacf61ea_de38d3d5","line":131,"updated":"2016-08-04 18:17:47.000000000","message":"Did you intend to make this a blank line?","commit_id":"05423483c66a408cb569770bff218472c0a8928c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"57678d6fce61abf9e16181641684d104d5ea001f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"# --------------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"NETWORK_MANAGER\u003d${NETWORK_MANAGER:-${NET_MAN:-FlatDHCPManager}}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"VLAN_INTERFACE\u003d${VLAN_INTERFACE:-$GUEST_INTERFACE_DEFAULT}"},{"line_number":133,"context_line":"FLAT_NETWORK_BRIDGE\u003d${FLAT_NETWORK_BRIDGE:-$FLAT_NETWORK_BRIDGE_DEFAULT}"},{"line_number":134,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bacf61ea_9e7e5b68","line":131,"in_reply_to":"bacf61ea_de38d3d5","updated":"2016-08-04 18:20:27.000000000","message":"vaguely, yes","commit_id":"05423483c66a408cb569770bff218472c0a8928c"}]}