)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a3b1a743fe2f2bfb7657ebe21f917ee37f4ee8a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7fcac719_faf067fc","updated":"2021-11-04 16:30:08.000000000","message":"we do not have progress since long on moving to new workflow. devstack-gate is deprecated now but devstack can be moved to new workflow of \u0027tempest workspace\u0027 and I will say we do this change along with moving to new workflow which is more work.","commit_id":"dfcd120b413beb5c371444245be231073848e563"}],"lib/tempest":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0305f7b8cf9ae50585e9006061bc9c1ebaf52d9e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"function configure_tempest {"},{"line_number":111,"context_line":"    if [[ \"$INSTALL_TEMPEST\" \u003d\u003d \"True\" ]]; then"},{"line_number":112,"context_line":"        setup_develop $TEMPEST_DIR"},{"line_number":113,"context_line":"        tox -evenv-tempest -- tempest init $TEMPEST_DIR"},{"line_number":114,"context_line":"    else"},{"line_number":115,"context_line":"        # install testr since its used to process tempest logs"},{"line_number":116,"context_line":"        pip_install_gr testrepository"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bacf61ea_2a98c6bf","line":113,"updated":"2016-08-04 21:02:34.000000000","message":"This won\u0027t work for a couple of reasons but the biggest issue is that $TEMPEST_DIR is the tempest git repo. This will fail because tempest init won\u0027t use an existing dir that has something in it. We need to create a new directory for this, I would probably use something like:\n\n    TEMPEST_WORKSPACE\u003d${TEMPEST_WORKSPACE_DIR:-$DATA_DIR/tempest_workspace}\n\nThe other thing is we\u0027re never actually setting up any configuration for the workspace, so it won\u0027t be useable (even assuming this call worked). There are 2 ways to address this, either copy the resulting $TEMPEST_DIR/etc/tempest.conf file to $TEMPEST_WORKSPACE/etc/. or copy it to /etc/tempest/tempest.conf before you run the init command. I think I\u0027d prefer the latter, because that will let tempest init set the options for local state bits (like the lock dir and log output path). THe only issue with doing that is if non-gate users try to init a new workspace for a different cloud on the devstack machine it will default to having the devstack config file.","commit_id":"14f4cb96be1dcff32505d2a2110fb944741809f1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3a74b97be091d2424315afd74c1a12f59f081e4f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"TEMPEST_CONFIG_DIR\u003d${TEMPEST_CONFIG_DIR:-$TEMPEST_DIR/etc}"},{"line_number":49,"context_line":"TEMPEST_CONFIG\u003d$TEMPEST_CONFIG_DIR/tempest.conf"},{"line_number":50,"context_line":"TEMPEST_STATE_PATH\u003d${TEMPEST_STATE_PATH:\u003d$DATA_DIR/tempest}"},{"line_number":51,"context_line":"TEMPEST_WORKSPACE\u003d${TEMPEST_WORKSPACE_DIR:-$DATA_DIR/tempest_workspace}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"NOVA_SOURCE_DIR\u003d$DEST/nova"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bacf61ea_c94f6d90","line":51,"updated":"2016-08-05 05:05:31.000000000","message":"s/TEMPEST_WORKSPACE_DIR/TEMPEST_WORKSPACE/ (that was probably my typo before) We want this to match so people can change the default value using the same variable","commit_id":"1caacbc228b45da5a93d2b0c8eb8c9f5d0ccdc0d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3a74b97be091d2424315afd74c1a12f59f081e4f","unresolved":false,"context_lines":[{"line_number":599,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled api_extensions $volume_api_extensions"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    # set up a workspace for \"tempest run\""},{"line_number":602,"context_line":"    if [[ ! -d \"$TEMPEST_WORKSPACE\" ]]; then"},{"line_number":603,"context_line":"        $TEMPEST_DIR/.tox/tempest/bin/tempest init $TEMPEST_WORKSPACE"},{"line_number":604,"context_line":"    fi"},{"line_number":605,"context_line":"    # copy the config contents to the current config for gate compatibility"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bacf61ea_2941e963","line":602,"updated":"2016-08-05 05:05:31.000000000","message":"I don\u0027t think unstack should, the workspace is the default location for logs, and other artifacts from a run. I\u0027d view removing it as the same as deleting a service log. (although you can append to log files, you can\u0027t really do that with workspaces) removing it as part of clean.sh is probably ok though","commit_id":"1caacbc228b45da5a93d2b0c8eb8c9f5d0ccdc0d"},{"author":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"change_message_id":"5f20c5bbcfdb242e09c1d03d93dc8e012e89098c","unresolved":false,"context_lines":[{"line_number":599,"context_line":"    iniset $TEMPEST_CONFIG volume-feature-enabled api_extensions $volume_api_extensions"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    # set up a workspace for \"tempest run\""},{"line_number":602,"context_line":"    if [[ ! -d \"$TEMPEST_WORKSPACE\" ]]; then"},{"line_number":603,"context_line":"        $TEMPEST_DIR/.tox/tempest/bin/tempest init $TEMPEST_WORKSPACE"},{"line_number":604,"context_line":"    fi"},{"line_number":605,"context_line":"    # copy the config contents to the current config for gate compatibility"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bacf61ea_f7216e9f","line":602,"updated":"2016-08-05 00:51:03.000000000","message":"Should unstack.sh clean up any workspaces? Or is it ok if it\u0027s left lying around? I had to put this in because on multiple stack/unstack runs it was crapping out if the workspace directory was already there.","commit_id":"1caacbc228b45da5a93d2b0c8eb8c9f5d0ccdc0d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3a74b97be091d2424315afd74c1a12f59f081e4f","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    if [[ ! -d \"$TEMPEST_WORKSPACE\" ]]; then"},{"line_number":603,"context_line":"        $TEMPEST_DIR/.tox/tempest/bin/tempest init $TEMPEST_WORKSPACE"},{"line_number":604,"context_line":"    fi"},{"line_number":605,"context_line":"    # copy the config contents to the current config for gate compatibility"},{"line_number":606,"context_line":"    cat $TEMPEST_CONFIG \u003e\u003e $TEMPEST_WORKSPACE/etc/tempest.conf"},{"line_number":607,"context_line":"    cp $TEMPEST_WORKSPACE/etc/tempest.conf $TEMPEST_CONFIG"},{"line_number":608,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bacf61ea_0946a57a","line":605,"updated":"2016-08-05 05:05:31.000000000","message":"Well this is what I was getting at in the last revision. Tempest init will make a shim config file (or overwrite a couple options if it already exists) that sets some basics options:\n\nhttps://github.com/openstack/tempest/blob/master/tempest/cmd/init.py#L92-L104\n\nwhich is how you want things set in a workspace normally. (so it\u0027s logs are self contained and the locks don\u0027t conflict with any other running tempests) If we just do a cp $TEMPEST_CONFIG to $TEMPEST_WORKSPACE this would overwrite those settings. You can\u0027t have a config file in a workspace\u0027s local etc/ before you create a workspace. The only options here are to either bite the bullet and overwrite the config file (and probably manually change the log file and lock path) or use /etc/tempest/tempest.conf.\n\nTempest init will as an early step copy anything in a global config dir (which is found via: https://github.com/openstack/tempest/blob/master/tempest/cmd/init.py#L40-L64) into $TEMPEST_WORKSPACE/etc. So if you put the devstack generated tempest.config in /etc/tempest/tempest.config when you create the workspace with tempest init the config will already be there (and modified to put artifacts in the right place)","commit_id":"1caacbc228b45da5a93d2b0c8eb8c9f5d0ccdc0d"},{"author":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"change_message_id":"c69fe7d928e09d6fa1281ac5ae34db98cc418f57","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    if [[ ! -d \"$TEMPEST_WORKSPACE\" ]]; then"},{"line_number":603,"context_line":"        $TEMPEST_DIR/.tox/tempest/bin/tempest init $TEMPEST_WORKSPACE"},{"line_number":604,"context_line":"    fi"},{"line_number":605,"context_line":"    # copy the config contents to the current config for gate compatibility"},{"line_number":606,"context_line":"    cat $TEMPEST_CONFIG \u003e\u003e $TEMPEST_WORKSPACE/etc/tempest.conf"},{"line_number":607,"context_line":"    cp $TEMPEST_WORKSPACE/etc/tempest.conf $TEMPEST_CONFIG"},{"line_number":608,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bacf61ea_f4132c63","line":605,"updated":"2016-08-05 00:49:14.000000000","message":"Whoops, this needs to happen before I run the init command, not after.","commit_id":"1caacbc228b45da5a93d2b0c8eb8c9f5d0ccdc0d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"75e91e2f5d7affe039924c85d8452450c76667c4","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    fi"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    # Update the current Tempest config with the new merged one created during init"},{"line_number":614,"context_line":"    cp $TEMPEST_WORKSPACE/etc/tempest.conf $TEMPEST_CONFIG"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    # Restore IFS"},{"line_number":617,"context_line":"    IFS\u003d$ifs"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9ad45d7e_d31cf36b","line":614,"updated":"2016-08-11 22:55:31.000000000","message":"One, note while this is good for testing and being able to debug this patch. We don\u0027t want to do this when we land the patch. What will happen is when someone tries to use tempest the old way (straight from the repo) is that they\u0027ll end up with all of their logs and state artifacts stored in the workspace instead of here. Which I imagine would be confusing. But until we un-WIP this I think we should leave it just to make debugging easier","commit_id":"ec20233da57f2f0586ceddf626011cd32b0988cb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"feaedb732b03c0c4002ccc05c835316177cb56dc","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            tox -evenv-tempest -- tempest-account-generator -c $TEMPEST_CONFIG --os-username $admin_username --os-password \"$password\" --os-tenant-name $admin_project_name -r $TEMPEST_CONCURRENCY etc/accounts.yaml"},{"line_number":565,"context_line":"        fi"},{"line_number":566,"context_line":"        iniset $TEMPEST_CONFIG auth use_dynamic_credentials False"},{"line_number":567,"context_line":"        iniset $TEMPEST_CONFIG auth test_accounts_file \"etc/accounts.yaml\""},{"line_number":568,"context_line":"    elif [[ $TEMPEST_HAS_ADMIN \u003d\u003d \"False\" ]]; then"},{"line_number":569,"context_line":"        iniset $TEMPEST_CONFIG auth use_dynamic_credentials ${TEMPEST_ALLOW_TENANT_ISOLATION:-False}"},{"line_number":570,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1a430d35_e2d3ab36","line":567,"range":{"start_line":567,"start_character":56,"end_line":567,"end_character":73},"updated":"2017-02-06 04:21:19.000000000","message":"To have all configurable files in one place we can change this too under tempest folder etc/tempest/accounts.yaml\nBut in different patch.","commit_id":"dfcd120b413beb5c371444245be231073848e563"}]}