)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3a01f8e69a3c1b6471b8de187600b16abaa99f69","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install conntrack in XenServer Dom0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron openvswitch agent running in compute node will controll the"},{"line_number":10,"context_line":"actuall connection of the VMs in Dom0 via conntrack-tools, but Dom0"},{"line_number":11,"context_line":"doesn\u0027t install conntrack-tools RPM by default."},{"line_number":12,"context_line":"This patch is to add such support with XenServer is 7.0 and later."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_6647b077","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":63},"updated":"2016-08-10 11:26:17.000000000","message":"Typo","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"9a1ce7b0f6cd16058d91d5064d0f94b86c10e8b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install conntrack in XenServer Dom0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron openvswitch agent running in compute node will controll the"},{"line_number":10,"context_line":"actuall connection of the VMs in Dom0 via conntrack-tools, but Dom0"},{"line_number":11,"context_line":"doesn\u0027t install conntrack-tools RPM by default."},{"line_number":12,"context_line":"This patch is to add such support with XenServer is 7.0 and later."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ac06dbe_91021208","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":63},"in_reply_to":"9ad45d7e_6647b077","updated":"2016-08-22 06:24:53.000000000","message":"Done","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3a01f8e69a3c1b6471b8de187600b16abaa99f69","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Install conntrack in XenServer Dom0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron openvswitch agent running in compute node will controll the"},{"line_number":10,"context_line":"actuall connection of the VMs in Dom0 via conntrack-tools, but Dom0"},{"line_number":11,"context_line":"doesn\u0027t install conntrack-tools RPM by default."},{"line_number":12,"context_line":"This patch is to add such support with XenServer is 7.0 and later."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_a65d2849","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"updated":"2016-08-10 11:26:17.000000000","message":"Typo","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"9a1ce7b0f6cd16058d91d5064d0f94b86c10e8b0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Install conntrack in XenServer Dom0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron openvswitch agent running in compute node will controll the"},{"line_number":10,"context_line":"actuall connection of the VMs in Dom0 via conntrack-tools, but Dom0"},{"line_number":11,"context_line":"doesn\u0027t install conntrack-tools RPM by default."},{"line_number":12,"context_line":"This patch is to add such support with XenServer is 7.0 and later."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ac06dbe_f109c62d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"in_reply_to":"9ad45d7e_a65d2849","updated":"2016-08-22 06:24:53.000000000","message":"Done","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"}],"lib/nova_plugins/hypervisor-xenserver":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72b8ab472f2a2023147230c335f389474a28b19c","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Install conntrack in Dom0"},{"line_number":93,"context_line":"    # check XenServer verion, only support conntrack from XS7.0"},{"line_number":94,"context_line":"    XS_HOST\u003d`$ssh_dom0 \"xe host-list --minimal\"`"},{"line_number":95,"context_line":"    XS_VER\u003d`$ssh_dom0 \"xe host-param-get uuid\u003d$XS_HOST param-name\u003dsoftware-version param-key\u003dproduct_version_text_short\"`"},{"line_number":96,"context_line":"    XS_VER_MAJOR\u003d`echo $XS_VER | awk -F \".\" \u0027{print $1}\u0027`"},{"line_number":97,"context_line":"    if [ $XS_VER_MAJOR -gt 6 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ad45d7e_28c11e2f","line":94,"updated":"2016-08-10 00:40:47.000000000","message":"use locals, lower case","commit_id":"5f8abd7ac3fa516be727343da0bdd411cf6680e0"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"2bfb2fcb6f9eb0fa45e25efdd714bd2c433e2fce","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Install conntrack in Dom0"},{"line_number":93,"context_line":"    # check XenServer verion, only support conntrack from XS7.0"},{"line_number":94,"context_line":"    XS_HOST\u003d`$ssh_dom0 \"xe host-list --minimal\"`"},{"line_number":95,"context_line":"    XS_VER\u003d`$ssh_dom0 \"xe host-param-get uuid\u003d$XS_HOST param-name\u003dsoftware-version param-key\u003dproduct_version_text_short\"`"},{"line_number":96,"context_line":"    XS_VER_MAJOR\u003d`echo $XS_VER | awk -F \".\" \u0027{print $1}\u0027`"},{"line_number":97,"context_line":"    if [ $XS_VER_MAJOR -gt 6 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ad45d7e_a37251ab","line":94,"in_reply_to":"9ad45d7e_28c11e2f","updated":"2016-08-10 01:18:07.000000000","message":"got it, will change, thanks","commit_id":"5f8abd7ac3fa516be727343da0bdd411cf6680e0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72b8ab472f2a2023147230c335f389474a28b19c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # enable baseurl"},{"line_number":99,"context_line":"        CENTOS_BASEREPO\u003d\"/etc/yum.repos.d/CentOS-Base.repo\""},{"line_number":100,"context_line":"        $ssh_dom0 \"sed -i s/#baseurl\u003d/baseurl\u003d/g $CENTOS_BASEREPO\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # check whether conntrack-tools package is installed"},{"line_number":103,"context_line":"        REPO_VER\u003d`$ssh_dom0 \"yum version nogroups |grep Installed\"`"},{"line_number":104,"context_line":"        CENTOS_VER\u003d$(echo $REPO_VER | awk -F \" \" \u0027{print $2}\u0027 | awk -F \".el\" \u0027{print $1}\u0027 | awk -F \"-\" \u0027{print $1 \".\" $2}\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ad45d7e_c8368251","line":101,"updated":"2016-08-10 00:40:47.000000000","message":"this seems odd?","commit_id":"5f8abd7ac3fa516be727343da0bdd411cf6680e0"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"2bfb2fcb6f9eb0fa45e25efdd714bd2c433e2fce","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # enable baseurl"},{"line_number":99,"context_line":"        CENTOS_BASEREPO\u003d\"/etc/yum.repos.d/CentOS-Base.repo\""},{"line_number":100,"context_line":"        $ssh_dom0 \"sed -i s/#baseurl\u003d/baseurl\u003d/g $CENTOS_BASEREPO\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # check whether conntrack-tools package is installed"},{"line_number":103,"context_line":"        REPO_VER\u003d`$ssh_dom0 \"yum version nogroups |grep Installed\"`"},{"line_number":104,"context_line":"        CENTOS_VER\u003d$(echo $REPO_VER | awk -F \" \" \u0027{print $2}\u0027 | awk -F \".el\" \u0027{print $1}\u0027 | awk -F \"-\" \u0027{print $1 \".\" $2}\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ad45d7e_a3b411d1","line":101,"in_reply_to":"9ad45d7e_c8368251","updated":"2016-08-10 01:18:07.000000000","message":"XenServer Dom0 disabled CentOS\u0027s repo by default, the below is to find the CentOS version, e.g. \"7-2.1511.el7.centos.2.10/x86_64\", but we cannot use 7-2.1511 to install conntrack-tools, so I need to change the value to 7.2.1511","commit_id":"5f8abd7ac3fa516be727343da0bdd411cf6680e0"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4c21493526fd3336dc955c6f4de115b037dcd26d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cat $TOP_DIR/tools/xen/functions"},{"line_number":88,"context_line":"        echo \"create_directory_for_images\""},{"line_number":89,"context_line":"        echo \"create_directory_for_kernels\""},{"line_number":90,"context_line":"    } | $ssh_dom0"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Install conntrack-tools in Dom0 as neutron-openvswitch-agent in compute node will use it"},{"line_number":93,"context_line":"    local xs_host\u003d`$ssh_dom0 \"xe host-list --minimal\"`"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9ad45d7e_66b97079","line":90,"updated":"2016-08-10 11:25:26.000000000","message":"This pattern is useful to run several dom0 commands together","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"9a1ce7b0f6cd16058d91d5064d0f94b86c10e8b0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cat $TOP_DIR/tools/xen/functions"},{"line_number":88,"context_line":"        echo \"create_directory_for_images\""},{"line_number":89,"context_line":"        echo \"create_directory_for_kernels\""},{"line_number":90,"context_line":"    } | $ssh_dom0"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Install conntrack-tools in Dom0 as neutron-openvswitch-agent in compute node will use it"},{"line_number":93,"context_line":"    local xs_host\u003d`$ssh_dom0 \"xe host-list --minimal\"`"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1ac06dbe_71bf96fb","line":90,"in_reply_to":"9ad45d7e_66b97079","updated":"2016-08-22 06:24:53.000000000","message":"got it, I can change my part this way:)","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4c21493526fd3336dc955c6f4de115b037dcd26d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if [[ $xs_ver_major -gt 6 \u0026\u0026 $conntrack_started_dom0 -lt 3 ]]; then"},{"line_number":99,"context_line":"        $ssh_dom0 \"sed -i s/#baseurl\u003d/baseurl\u003d/g /etc/yum.repos.d/CentOS-Base.repo\""},{"line_number":100,"context_line":"        local repo_ver\u003d`$ssh_dom0 \"yum version nogroups |grep Installed\"`"},{"line_number":101,"context_line":"        local centos_ver\u003d$(echo $repo_ver | awk -F \" \" \u0027{print $2}\u0027 | awk -F \".el\" \u0027{print $1}\u0027 | awk -F \"-\" \u0027{print $1 \".\" $2}\u0027)"},{"line_number":102,"context_line":"        $ssh_dom0 \"yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools\""},{"line_number":103,"context_line":"        $ssh_dom0 \"cp /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.bak\""},{"line_number":104,"context_line":"        sudo -u $DOMZERO_USER scp -o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null $TOP_DIR/tools/xen/conntrackd.conf root@$dom0_ip:/etc/conntrackd/"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9ad45d7e_467b8cf5","line":101,"updated":"2016-08-10 11:25:26.000000000","message":"Is there really no better way to get this?\n\nIf we have to get it from version nogroups, then this is better:\nyum version nogroups |grep Installed | cut -d\u0027 \u0027 -f 2 | cut -d\u0027.\u0027 -f1-2 | tr \u0027-\u0027 \u0027.\u0027","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"9a1ce7b0f6cd16058d91d5064d0f94b86c10e8b0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if [[ $xs_ver_major -gt 6 \u0026\u0026 $conntrack_started_dom0 -lt 3 ]]; then"},{"line_number":99,"context_line":"        $ssh_dom0 \"sed -i s/#baseurl\u003d/baseurl\u003d/g /etc/yum.repos.d/CentOS-Base.repo\""},{"line_number":100,"context_line":"        local repo_ver\u003d`$ssh_dom0 \"yum version nogroups |grep Installed\"`"},{"line_number":101,"context_line":"        local centos_ver\u003d$(echo $repo_ver | awk -F \" \" \u0027{print $2}\u0027 | awk -F \".el\" \u0027{print $1}\u0027 | awk -F \"-\" \u0027{print $1 \".\" $2}\u0027)"},{"line_number":102,"context_line":"        $ssh_dom0 \"yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools\""},{"line_number":103,"context_line":"        $ssh_dom0 \"cp /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.bak\""},{"line_number":104,"context_line":"        sudo -u $DOMZERO_USER scp -o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null $TOP_DIR/tools/xen/conntrackd.conf root@$dom0_ip:/etc/conntrackd/"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1ac06dbe_d1e00afd","line":101,"in_reply_to":"9ad45d7e_467b8cf5","updated":"2016-08-22 06:24:53.000000000","message":"With XS7.0, the version to be used is \"7.2.1511\", but the result of \"yum version nogroup\"/\"yum version\" is \"Installed: 7-2.1511.el7.centos.2.10/x86_64\", So I use the above to change it to  the right one. Will check whethere there is a better way","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4c21493526fd3336dc955c6f4de115b037dcd26d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        local repo_ver\u003d`$ssh_dom0 \"yum version nogroups |grep Installed\"`"},{"line_number":101,"context_line":"        local centos_ver\u003d$(echo $repo_ver | awk -F \" \" \u0027{print $2}\u0027 | awk -F \".el\" \u0027{print $1}\u0027 | awk -F \"-\" \u0027{print $1 \".\" $2}\u0027)"},{"line_number":102,"context_line":"        $ssh_dom0 \"yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools\""},{"line_number":103,"context_line":"        $ssh_dom0 \"cp /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.bak\""},{"line_number":104,"context_line":"        sudo -u $DOMZERO_USER scp -o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null $TOP_DIR/tools/xen/conntrackd.conf root@$dom0_ip:/etc/conntrackd/"},{"line_number":105,"context_line":"        $ssh_dom0 \"/usr/sbin/conntrackd -d -C /etc/conntrackd/conntrackd.conf\""},{"line_number":106,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9ad45d7e_26dad84c","line":103,"updated":"2016-08-10 11:25:26.000000000","message":"Rather than carrying a custom conntrackd config, can we have a short awk script that will perform the modifications to the conf file if needed?\nSounds from the config file that the mods should be quite well defined?","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"9a1ce7b0f6cd16058d91d5064d0f94b86c10e8b0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        local repo_ver\u003d`$ssh_dom0 \"yum version nogroups |grep Installed\"`"},{"line_number":101,"context_line":"        local centos_ver\u003d$(echo $repo_ver | awk -F \" \" \u0027{print $2}\u0027 | awk -F \".el\" \u0027{print $1}\u0027 | awk -F \"-\" \u0027{print $1 \".\" $2}\u0027)"},{"line_number":102,"context_line":"        $ssh_dom0 \"yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools\""},{"line_number":103,"context_line":"        $ssh_dom0 \"cp /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.bak\""},{"line_number":104,"context_line":"        sudo -u $DOMZERO_USER scp -o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null $TOP_DIR/tools/xen/conntrackd.conf root@$dom0_ip:/etc/conntrackd/"},{"line_number":105,"context_line":"        $ssh_dom0 \"/usr/sbin/conntrackd -d -C /etc/conntrackd/conntrackd.conf\""},{"line_number":106,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1ac06dbe_d1a80ade","line":103,"in_reply_to":"9ad45d7e_26dad84c","updated":"2016-08-22 06:24:53.000000000","message":"Yes, I don\u0027t need this way. I did some investigation on conntrackd, it has two mode: synchronization and statistic mode. In our case, we only need statistic mode, but the default conntrackd.conf is synchronization mode. There is an example conntrackd.conf which is for statistic mode in /usr/share/doc/conntrack-tools-1.4.2/doc/stats after conntrack-tools is installed, I can use that file","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"4c21493526fd3336dc955c6f4de115b037dcd26d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        $ssh_dom0 \"yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools\""},{"line_number":103,"context_line":"        $ssh_dom0 \"cp /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.bak\""},{"line_number":104,"context_line":"        sudo -u $DOMZERO_USER scp -o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null $TOP_DIR/tools/xen/conntrackd.conf root@$dom0_ip:/etc/conntrackd/"},{"line_number":105,"context_line":"        $ssh_dom0 \"/usr/sbin/conntrackd -d -C /etc/conntrackd/conntrackd.conf\""},{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9ad45d7e_6612100b","line":105,"updated":"2016-08-10 11:25:26.000000000","message":"This just starts it once; is it a service?  In which case we should just use service conntrackd start (or similar)","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"9a1ce7b0f6cd16058d91d5064d0f94b86c10e8b0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        $ssh_dom0 \"yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools\""},{"line_number":103,"context_line":"        $ssh_dom0 \"cp /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.bak\""},{"line_number":104,"context_line":"        sudo -u $DOMZERO_USER scp -o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null $TOP_DIR/tools/xen/conntrackd.conf root@$dom0_ip:/etc/conntrackd/"},{"line_number":105,"context_line":"        $ssh_dom0 \"/usr/sbin/conntrackd -d -C /etc/conntrackd/conntrackd.conf\""},{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1ac06dbe_3197de91","line":105,"in_reply_to":"9ad45d7e_6612100b","updated":"2016-08-22 06:24:53.000000000","message":"For conntrackd to run in daemon mode, it is recommend to use conntrackd -d -C /xxx/conntrackd.conf in its manual.","commit_id":"595717a74291326691614d4cd0ecd7a07afebfe5"}],"tools/xen/conntrackd.conf":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"72b8ab472f2a2023147230c335f389474a28b19c","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# See also: http://conntrack-tools.netfilter.org/support.html"},{"line_number":3,"context_line":"# "},{"line_number":4,"context_line":"# There are 3 different modes of running conntrackd: \"alarm\", \"notrack\" and \"ftfw\""}],"source_content_type":"text/plain","patch_set":5,"id":"9ad45d7e_28aabe70","line":1,"updated":"2016-08-10 00:40:47.000000000","message":"is this actually different to the packaged configuration?  why do we need to keep our own copy?","commit_id":"5f8abd7ac3fa516be727343da0bdd411cf6680e0"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"2bfb2fcb6f9eb0fa45e25efdd714bd2c433e2fce","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# See also: http://conntrack-tools.netfilter.org/support.html"},{"line_number":3,"context_line":"# "},{"line_number":4,"context_line":"# There are 3 different modes of running conntrackd: \"alarm\", \"notrack\" and \"ftfw\""}],"source_content_type":"text/plain","patch_set":5,"id":"9ad45d7e_239021ec","line":1,"in_reply_to":"9ad45d7e_28aabe70","updated":"2016-08-10 01:18:07.000000000","message":"I saw devstack will install the conntrack-tools in compute node or network node as long as we specify it in file/rpm/xxx, but it won\u0027t install this in Dom0 when XenServer is the hypervisor. However, when neutron is used, neutron-openvswitch-agent in compute node will actually control the connection via conntrack-tools in Dom0, so I need to add it in Dom0.\nAfter install the conntrack-tools.conf in Dom0, the default conntrackd.conf is not suitable for use to use, e.g. it contains \nsome other IP addresses \"192.168.x.x\" which should not be here\n\nAddress Ignore {\n     IPv4_address 127.0.0.1 # loopback\n     IPv4_address 192.168.0.100 # virtual IP 1\n     IPv4_address 192.168.1.100 # virtual IP 2\n     IPv4_address 192.168.0.1\n     IPv4_address 192.168.1.1\n     IPv4_address 192.168.100.100 # dedicated link ip","commit_id":"5f8abd7ac3fa516be727343da0bdd411cf6680e0"}],"tools/xen/functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"51da8f8654e3ab97e3ee2bdc8c9480c52ca49aa8","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    xs_host\u003d$(xe host-list --minimal)"},{"line_number":316,"context_line":"    xs_ver_major\u003d$(xe host-param-get uuid\u003d$xs_host param-name\u003dsoftware-version param-key\u003dproduct_version_text_short | cut -d\u0027.\u0027 -f 1)"},{"line_number":317,"context_line":"    if [ $xs_ver_major -gt 6 ]; then"},{"line_number":318,"context_line":"        conntrackd_installed\u003d$(find /usr/sbin -name conntrackd)"},{"line_number":319,"context_line":"        if [ -z \"$conntrackd_installed\" ]; then"},{"line_number":320,"context_line":"            sed -i s/#baseurl\u003d/baseurl\u003d/g /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":321,"context_line":"            centos_ver\u003d$(yum version nogroups |grep Installed | cut -d\u0027 \u0027 -f 2 | cut -d\u0027.\u0027 -f1-2 | tr \u0027-\u0027 \u0027.\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fa7ab95a_6b747f67","line":318,"updated":"2016-08-30 00:59:48.000000000","message":"i think this is better just written\n\n if [ -f /usr/sbin/conntrackd ]; then\n   ...\n fi","commit_id":"73fe20a9aa9b429184c294b5fed63c94093d47fd"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"a144b6a66663bba63d3ad77062bd53d1265aa078","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    xs_host\u003d$(xe host-list --minimal)"},{"line_number":316,"context_line":"    xs_ver_major\u003d$(xe host-param-get uuid\u003d$xs_host param-name\u003dsoftware-version param-key\u003dproduct_version_text_short | cut -d\u0027.\u0027 -f 1)"},{"line_number":317,"context_line":"    if [ $xs_ver_major -gt 6 ]; then"},{"line_number":318,"context_line":"        conntrackd_installed\u003d$(find /usr/sbin -name conntrackd)"},{"line_number":319,"context_line":"        if [ -z \"$conntrackd_installed\" ]; then"},{"line_number":320,"context_line":"            sed -i s/#baseurl\u003d/baseurl\u003d/g /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":321,"context_line":"            centos_ver\u003d$(yum version nogroups |grep Installed | cut -d\u0027 \u0027 -f 2 | cut -d\u0027.\u0027 -f1-2 | tr \u0027-\u0027 \u0027.\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fa7ab95a_cbe02b99","line":318,"in_reply_to":"fa7ab95a_6b747f67","updated":"2016-08-30 01:19:20.000000000","message":"thanks, agree with you, I will change this","commit_id":"73fe20a9aa9b429184c294b5fed63c94093d47fd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"75ce832837bf05fc3c1c0fee38ad8352e99bb824","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        if [ ! -f /usr/sbin/conntrackd ]; then"},{"line_number":319,"context_line":"            sed -i s/#baseurl\u003d/baseurl\u003d/g /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":320,"context_line":"            centos_ver\u003d$(yum version nogroups |grep Installed | cut -d\u0027 \u0027 -f 2 | cut -d\u0027.\u0027 -f1-2 | tr \u0027-\u0027 \u0027.\u0027)"},{"line_number":321,"context_line":"            yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools"},{"line_number":322,"context_line":"            # Backup conntrackd.conf after install conntrack-tools, use the one with statistic mode"},{"line_number":323,"context_line":"            mv /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.back"},{"line_number":324,"context_line":"            conntrack_conf\u003d$(find /usr/share/doc -name conntrackd.conf |grep stats)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa7ab95a_0d422068","line":321,"updated":"2016-08-30 05:58:13.000000000","message":"it seems this gets called as root, so ok","commit_id":"26edd7b071f84e2fd2a9953086209e02b0c27ef3"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"e1a2aca7070540e68f3f6eba77add8930de0e265","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        if [ ! -f /usr/sbin/conntrackd ]; then"},{"line_number":319,"context_line":"            sed -i s/#baseurl\u003d/baseurl\u003d/g /etc/yum.repos.d/CentOS-Base.repo"},{"line_number":320,"context_line":"            centos_ver\u003d$(yum version nogroups |grep Installed | cut -d\u0027 \u0027 -f 2 | cut -d\u0027.\u0027 -f1-2 | tr \u0027-\u0027 \u0027.\u0027)"},{"line_number":321,"context_line":"            yum install -y --enablerepo\u003dbase --releasever\u003d$centos_ver conntrack-tools"},{"line_number":322,"context_line":"            # Backup conntrackd.conf after install conntrack-tools, use the one with statistic mode"},{"line_number":323,"context_line":"            mv /etc/conntrackd/conntrackd.conf /etc/conntrackd/conntrackd.conf.back"},{"line_number":324,"context_line":"            conntrack_conf\u003d$(find /usr/share/doc -name conntrackd.conf |grep stats)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa7ab95a_30f7385a","line":321,"in_reply_to":"fa7ab95a_0d422068","updated":"2016-08-30 07:31:01.000000000","message":"Yes, this will be called as root, see https://review.openstack.org/#/c/352256/14/lib/nova_plugins/hypervisor-xenserver","commit_id":"26edd7b071f84e2fd2a9953086209e02b0c27ef3"}]}