)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7912963a711cee45f20aee3ab4e0c71145276520","unresolved":false,"context_lines":[{"line_number":10,"context_line":"after we have initialized all other plugins. Things like ironic"},{"line_number":11,"context_line":"aren\u0027t setup when we were running this as part of nova setup, and"},{"line_number":12,"context_line":"thus this command can fail."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic7d0115da51d6ea17ee49071af259a7789c62ab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_9b199f7c","line":13,"updated":"2016-08-16 01:23:47.000000000","message":"Related-Bug: #1613417","commit_id":"b2753a3321155eb3669cc48a87e6cc632a4f0119"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6def12d8b70025c35efba16bdf852fa94d85b268","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-16 11:10:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move create_cell to late in the setup process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since this requires compute hosts to be started, we need to do it"},{"line_number":10,"context_line":"after we have initialized all other plugins. Things like ironic"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_e82feb85","line":7,"updated":"2016-08-17 01:05:29.000000000","message":"This doesn\u0027t seem to move the call so much as start making the call\n\nBy I73157128a3e24e49438caca1cbb19a9f5b5a7f7e this seems to basically enable cells v2 by default?  Maybe that is what we want to do, but i\u0027d like to see that mentioned here?","commit_id":"392e833ed4230875e6d41f6c667e1ad057514b82"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"129e4430d1446b550bc5633d817e50bab54dea52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-16 11:10:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move create_cell to late in the setup process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since this requires compute hosts to be started, we need to do it"},{"line_number":10,"context_line":"after we have initialized all other plugins. Things like ironic"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_6c3821f0","line":7,"in_reply_to":"3ac371cc_a895f387","updated":"2016-08-17 09:06:16.000000000","message":"Ian, thanks for review I\u0027ve update commit message.","commit_id":"392e833ed4230875e6d41f6c667e1ad057514b82"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"23a4166fac3cb31f01278b0af8319fd27e49693c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-16 11:10:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move create_cell to late in the setup process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since this requires compute hosts to be started, we need to do it"},{"line_number":10,"context_line":"after we have initialized all other plugins. Things like ironic"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_a895f387","line":7,"in_reply_to":"3ac371cc_e82feb85","updated":"2016-08-17 01:06:59.000000000","message":"OK, after digging about, I see this is essentially a re-implementation of I50a955b97d0e18426406c15397bdfbc9e807d908 that should avoid the problems that introduced for ironic?  it would be good if the changelog said as much to avoid confusion","commit_id":"392e833ed4230875e6d41f6c667e1ad057514b82"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ffbd0b98e91ec0785c342430a1420943f44f46ba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move create_cell to late in the setup process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since this requires compute hosts to be started, we need to do it"},{"line_number":10,"context_line":"after we have initialized all other plugins. Things like ironic"},{"line_number":11,"context_line":"aren\u0027t setup when we were running this as part of nova setup, and"},{"line_number":12,"context_line":"thus this command can fail."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also skip this process for cellsv1, which will never have hosts"},{"line_number":15,"context_line":"at the top level and which will always fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_41cd1c84","line":12,"range":{"start_line":10,"start_character":45,"end_line":12,"end_character":27},"updated":"2016-08-17 13:41:43.000000000","message":"Ian, it says that right here.","commit_id":"392e833ed4230875e6d41f6c667e1ad057514b82"}],"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"187f06fd3d1333ad2eabcc2e93ee7741ab49c622","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    # Only do this step once on the API node for an entire cluster."},{"line_number":682,"context_line":"    if is_service_enabled $DATABASE_BACKENDS \u0026\u0026 is_service_enabled n-api; then"},{"line_number":683,"context_line":"        # (Re)create nova database"},{"line_number":684,"context_line":"        recreate_database nova"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        # Migrate nova database"},{"line_number":687,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_fe8eb677","line":684,"updated":"2016-08-29 13:55:58.000000000","message":"We\u0027re going to need something like this for the cell0 database.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f9833b5928297facb075cf0f1f069f6dda2e71e4","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    # Only do this step once on the API node for an entire cluster."},{"line_number":682,"context_line":"    if is_service_enabled $DATABASE_BACKENDS \u0026\u0026 is_service_enabled n-api; then"},{"line_number":683,"context_line":"        # (Re)create nova database"},{"line_number":684,"context_line":"        recreate_database nova"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        # Migrate nova database"},{"line_number":687,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_17d3dcd5","line":684,"in_reply_to":"fa7ab95a_fe8eb677","updated":"2016-08-30 18:11:15.000000000","message":"This patch should depend on https://review.openstack.org/#/c/362154/.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ae5f2d99f7177585ecb44a1f48629d71ebdded31","unresolved":false,"context_lines":[{"line_number":937,"context_line":"}"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3ac371cc_49c6da9a","line":940,"updated":"2016-08-17 15:59:42.000000000","message":"I think we should add the same wrapper to grenade: https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/upgrade.sh#L78\nor even call create_cell from upgrade.sh","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c93e14cbed45322dd44b62d6ffba60249c2b9e77","unresolved":false,"context_lines":[{"line_number":937,"context_line":"}"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3ac371cc_845d5049","line":940,"in_reply_to":"3ac371cc_0465e0b3","updated":"2016-08-17 18:14:28.000000000","message":"I meant why it is not recommended to use devstack functions in grenade?","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6b84c27efc1029369b6e32894e1d1b8582f4ca4a","unresolved":false,"context_lines":[{"line_number":937,"context_line":"}"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3ac371cc_0465e0b3","line":940,"in_reply_to":"3ac371cc_447fd865","updated":"2016-08-17 18:02:45.000000000","message":"CellsV1 is experimental in Nova and we don\u0027t support any amount of upgrade for it.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2ef195263d93eb377298af41a51a98359524d150","unresolved":false,"context_lines":[{"line_number":937,"context_line":"}"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3ac371cc_691596e3","line":940,"in_reply_to":"3ac371cc_49c6da9a","updated":"2016-08-17 16:01:16.000000000","message":"We don\u0027t run grenade on cellsv1 very specifically and never will.\n\nAlso, grenade cores specifically asked me to not use the devstack function in grenade.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"221616c88b6eccdc184292e6c50c9884bc5c6e05","unresolved":false,"context_lines":[{"line_number":937,"context_line":"}"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3ac371cc_447fd865","line":940,"in_reply_to":"3ac371cc_691596e3","updated":"2016-08-17 18:01:27.000000000","message":"why it is not recommended?","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b34c0ecefff25b710935464d51601db235dc0c9d","unresolved":false,"context_lines":[{"line_number":937,"context_line":"}"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3ac371cc_1f07e9ca","line":940,"in_reply_to":"3ac371cc_845d5049","updated":"2016-08-17 18:25:56.000000000","message":"Presumably to keep grenade as devstack-agnostic as possible. If you\u0027re interested, perhaps you should ask in #openstack-qa.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bf15ca9ca5afc19941f033ead463317866023d93","unresolved":false,"context_lines":[{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"},{"line_number":944,"context_line":"        echo \u0027Skipping cellsv2 setup for this cellsv1 configuration\u0027"},{"line_number":945,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_d4f83c4c","line":942,"updated":"2016-08-26 19:23:34.000000000","message":"I\u0027m looking into a grenade \"issue\" right now where running this command makes Nova think that there\u0027s a cell0 db, but migrations are never run so attempts to query that db fail.\n\nIt\u0027s not an issue yet but I have a patch up that fails on it. So I\u0027d like to figure out the migrations before merging this.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68188a269e77345e6aad4994f2ef46c8ee4bd45e","unresolved":false,"context_lines":[{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"},{"line_number":944,"context_line":"        echo \u0027Skipping cellsv2 setup for this cellsv1 configuration\u0027"},{"line_number":945,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_7e3f0687","line":942,"in_reply_to":"fa7ab95a_6f21594d","updated":"2016-08-29 13:56:34.000000000","message":"See the comment above, but the cell0 database doesn\u0027t exist at this point.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b5443eddb4942c6630a550ea60c8b465ce93e0f5","unresolved":false,"context_lines":[{"line_number":939,"context_line":"# create_cell(): Group the available hosts into a cell"},{"line_number":940,"context_line":"function create_cell {"},{"line_number":941,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":942,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":943,"context_line":"    else"},{"line_number":944,"context_line":"        echo \u0027Skipping cellsv2 setup for this cellsv1 configuration\u0027"},{"line_number":945,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_6f21594d","line":942,"in_reply_to":"fa7ab95a_d4f83c4c","updated":"2016-08-26 19:33:55.000000000","message":"What needs to happen is that this is run before \"nova-manage db sync\" is run. If not then db migrations are not run for the cell0 database. Or db migrations could be run again here.","commit_id":"045c317a50e0da0799d36c67bf3d1d1185b97081"}],"stack.sh":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"908c3b1696caa17b93ff3ccaf4c93c135c415e01","unresolved":false,"context_lines":[{"line_number":1360,"context_line":"# ----------------------"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"# Do this late because it requires compute hosts to have started"},{"line_number":1363,"context_line":"if is_service_enabled nova; then"},{"line_number":1364,"context_line":"    create_cell"},{"line_number":1365,"context_line":"fi"},{"line_number":1366,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3ac371cc_c8ecda2b","line":1363,"updated":"2016-08-16 10:43:10.000000000","message":"does this require a n-cpu dependency?","commit_id":"b2753a3321155eb3669cc48a87e6cc632a4f0119"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5d2c9123ad8addbf3d2f537e34ae2885c8c6917a","unresolved":false,"context_lines":[{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"# Do this late because it requires compute hosts to have started"},{"line_number":1363,"context_line":"if is_service_enabled nova; then"},{"line_number":1364,"context_line":"    create_cell"},{"line_number":1365,"context_line":"fi"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"# Bash completion"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3ac371cc_50ca486e","line":1364,"updated":"2016-08-16 12:56:27.000000000","message":"create_cell function has been reverted, this patch should depend on revert of https://github.com/openstack-dev/devstack/commit/9301e8875b8c50e486a3751b3d894d4ccdc94f84","commit_id":"b2753a3321155eb3669cc48a87e6cc632a4f0119"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"721357faf0be17210397ae7ed192b706784537c7","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"# ----------------------"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"# Do this late because it requires compute hosts to have started"},{"line_number":1387,"context_line":"if is_service_enabled nova \u0026\u0026 [ \"$NOVA_CONFIGURE_CELLSV2\" !\u003d \"False\" ]; then"},{"line_number":1388,"context_line":"    create_cell"},{"line_number":1389,"context_line":"fi"},{"line_number":1390,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"fa7ab95a_1a265568","line":1387,"range":{"start_line":1387,"start_character":33,"end_line":1387,"end_character":56},"updated":"2016-08-31 18:51:06.000000000","message":"Will this be sourced in at this point from lib/nova, or will it equate to \"\" which will equate to True and create the cell, which we don\u0027t want by default.\n\nSeems we should just have this check in the create_cell function which is already in lib/nova. But I guess to call lib/nova it would have to be sourced already so we\u0027d have the variable...still seems like it might be cleaner to keep that check in that function rather than tightly couple it in here.","commit_id":"85e45afdf6c2e8c5ebc45edf8aa40a12b6395534"}]}