)]}'
{"lib/nova_plugins/hypervisor-libvirt":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a454e01de3152700de08825cff27375fc25b8902","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if [[ \"$LIBVIRT_TYPE\" \u003d \"parallels\" ]]; then"},{"line_number":70,"context_line":"        iniset $NOVA_CONF libvirt connection_uri \"parallels:///system\""},{"line_number":71,"context_line":"        LIBVIRT_IMAGES_TYPE\u003d${LIBVIRT_IMAGES_TYPE:-ploop}"},{"line_number":72,"context_line":"        iniset $NOVA_CONF libvirt live_migration_uri \"parallels+ssh://$STACK_USER@%s/system\""},{"line_number":73,"context_line":"        iniset $NOVA_CONF libvirt images_type \"$LIBVIRT_IMAGES_TYPE\""},{"line_number":74,"context_line":"        iniset $NOVA_CONF DEFAULT force_raw_images  \"False\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3ac371cc_6c715ae0","line":71,"updated":"2016-08-16 20:31:10.000000000","message":"I\u0027d rather see this name-spaced (PARALLELS_LIBVIRT_IMAGES_TYPE) rather than have that more global name.\n\nAlso, i\u0027d rather not see it exported, just used if there\n\n  iniset ... \"${FOO:-bar}\"\n\nshould work\n\nI see you have a spec out ... is the idea you will flip this depending on if you are running images or containers?  not sure how this will work with our existing image upload stuff... \n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/runtime-image-type.html","commit_id":"17ab40b90642231fd2b113ba36143e1ba0f09e7f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f97149616022c095c8b83e43ffaad74ade4e5469","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if [[ \"$LIBVIRT_TYPE\" \u003d \"parallels\" ]]; then"},{"line_number":70,"context_line":"        iniset $NOVA_CONF libvirt connection_uri \"parallels:///system\""},{"line_number":71,"context_line":"        LIBVIRT_IMAGES_TYPE\u003d${LIBVIRT_IMAGES_TYPE:-ploop}"},{"line_number":72,"context_line":"        iniset $NOVA_CONF libvirt live_migration_uri \"parallels+ssh://$STACK_USER@%s/system\""},{"line_number":73,"context_line":"        iniset $NOVA_CONF libvirt images_type \"$LIBVIRT_IMAGES_TYPE\""},{"line_number":74,"context_line":"        iniset $NOVA_CONF DEFAULT force_raw_images  \"False\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_feb1ece0","line":71,"in_reply_to":"3ac371cc_401feb6b","updated":"2016-08-30 20:22:09.000000000","message":"sdague had a problem with setting this globally in [1]\n\nI\u0027m not really clear enough on when we want to switch this to decide.  but if we want it as a LIBVIRT_* generic global, we should have consensus on this (i.e. get sdague to agree)\n\n[1] https://review.openstack.org/#/c/318262/1","commit_id":"17ab40b90642231fd2b113ba36143e1ba0f09e7f"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"c15b192726861f2fe225dcdd5c650a2503125fd7","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if [[ \"$LIBVIRT_TYPE\" \u003d \"parallels\" ]]; then"},{"line_number":70,"context_line":"        iniset $NOVA_CONF libvirt connection_uri \"parallels:///system\""},{"line_number":71,"context_line":"        LIBVIRT_IMAGES_TYPE\u003d${LIBVIRT_IMAGES_TYPE:-ploop}"},{"line_number":72,"context_line":"        iniset $NOVA_CONF libvirt live_migration_uri \"parallels+ssh://$STACK_USER@%s/system\""},{"line_number":73,"context_line":"        iniset $NOVA_CONF libvirt images_type \"$LIBVIRT_IMAGES_TYPE\""},{"line_number":74,"context_line":"        iniset $NOVA_CONF DEFAULT force_raw_images  \"False\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3ac371cc_401feb6b","line":71,"in_reply_to":"3ac371cc_6c715ae0","updated":"2016-08-18 17:34:15.000000000","message":"I would argue about PARALLELS_ prefix, as it is not parallels/virtuozzo specific at all. QEMU/KVM also supports different image backend types like LVM, QCOW2, RAW, RBD, thus this newly introduced devstack variable only reflects corresponding parameter that nova libvirt already has, i.e. it can be used along with QEMU/KVM/LXC virt_types as well.\nProposed spec is not related to this review. Currently we don\u0027t have an ability to work with nothing but ploop images in devstack without manual nova.conf editing. Once the spec is implemented we will have to specify \u0027images_type_mapping\u0027 parameter but that is another story.","commit_id":"17ab40b90642231fd2b113ba36143e1ba0f09e7f"}]}